languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ddc] shard runtime_debugger_api_test.

Browse source 
This test appears to be timing out consistently in windows.

We split the test in two shards (sound vs unsound null safety)
as an attempt to address this issue.

Fixes https://github.com/dart-lang/sdk/issues/54894

Change-Id: I2230be95b1685ef1e5656eae2e740a94a0eeb320
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352049
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
This commit is contained in:
Sigmund Cherem 2024-02-13 20:10:17 +00:00 committed by Commit Queue
parent 30a94fceaf
commit 955c8d63f6
2 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
pkg/dev_compiler/test/expression_compiler/runtime_debugger_api_test.dart
View file

@ -10,27 +10,19 @@ import '../shared_test_options.dart';
import 'expression_compiler_e2e_suite.dart'; import 'expression_compiler_e2e_suite.dart';
void main(List<String> args) async { void main(List<String> args) async {
var driver = await ExpressionEvaluationTestDriver.init(); await runAllTests(true, args);
}
Future<void> runAllTests(bool soundNullSafety, List<String> args) async {
var driver = await ExpressionEvaluationTestDriver.init();
tearDownAll(() async { tearDownAll(() async {
await driver.finish(); await driver.finish();
}); });
group('(Sound null safety)', () { final mode = soundNullSafety ? 'Sound' : 'Weak';
group('($mode null safety)', () {
group('(AMD module system)', () { group('(AMD module system)', () {
var setup = SetupCompilerOptions( var setup = SetupCompilerOptions(
soundNullSafety: true, soundNullSafety: soundNullSafety,
moduleFormat: ModuleFormat.amd,
args: args,
enableExperiments: ['inline-class'],
);
runSharedTests(setup, driver);
});
});
group('(Weak null safety)', () {
group('(AMD module system)', () {
var setup = SetupCompilerOptions(
soundNullSafety: false,
moduleFormat: ModuleFormat.amd, moduleFormat: ModuleFormat.amd,
args: args, args: args,
enableExperiments: ['inline-class'], enableExperiments: ['inline-class'],

9
pkg/dev_compiler/test/expression_compiler/runtime_debugger_api_unsound_test.dart Normal file
View file

@ -0,0 +1,9 @@
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'runtime_debugger_api_test.dart' as common_tests;
void main(List<String> args) async {
await common_tests.runAllTests(false, args);
}