languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 22:19:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Constant-fold HTypeInfoReadVariable of constant value"

Browse source 
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org/2276953002 .
This commit is contained in:
Stephen Adams 2016-08-24 09:57:03 -07:00
parent 2e24662c06
commit 953e7c82bc
2 changed files with 0 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/compiler/lib/src/ssa/nodes.dart
View file

@ -3226,8 +3226,6 @@ class HTypeInfoReadVariable extends HInstruction {
setUseGvn();
}
HInstruction get object => inputs.single;
accept(HVisitor visitor) => visitor.visitTypeInfoReadVariable(this);
bool canThrow() => false;

38
pkg/compiler/lib/src/ssa/optimize.dart
View file

@ -1036,44 +1036,6 @@ class SsaInstructionSimplifier extends HBaseVisitor
HInstruction visitOneShotInterceptor(HOneShotInterceptor node) {
return handleInterceptedCall(node);
}
HInstruction visitTypeInfoReadVariable(HTypeInfoReadVariable node) {
TypeVariableType variable = node.variable;
HInstruction object = node.object;
HInstruction finishGroundType(DartType groundType) {
DartType typeAtVariable =
groundType.asInstanceOf(variable.element.enclosingClass);
if (typeAtVariable != null) {
int index = variable.element.index;
DartType typeArgument = typeAtVariable.typeArguments[index];
HInstruction replacement = new HTypeInfoExpression(
TypeInfoExpressionKind.COMPLETE,
typeArgument,
const <HInstruction>[],
backend.dynamicType);
return replacement;
}
return node;
}
// Type variable evaluated in the context of a constant can be replaced with
// a ground term type.
if (object is HConstant) {
ConstantValue value = object.constant;
if (value is ConstructedConstantValue) {
return finishGroundType(value.type);
}
return node;
}
// TODO(sra): HTypeInfoReadVariable on an instance creation can be replaced
// with an input of the instance creation's HTypeInfoExpression (or a
// HTypeInfoExpression of an input). This would in effect store-forward the
// type parameters.
return node;
}
}
class SsaCheckInserter extends HBaseVisitor implements OptimizationPhase {