languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ddc] Copy more .dill files to packaged sdk

Browse source 
Adds the sound full and outline as well as a weak full dill.

The outlines are required when compiling user applications. The full
dills will be used to compile the sdk to JS by the build system.

Change-Id: I74b3f1c34dba5fcdea2dfad07c6bf1af9c1e3f13
Issue: https://github.com/dart-lang/sdk/issues/42253
Fixes: https://github.com/dart-lang/sdk/issues/42083
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153701
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
This commit is contained in:
Nicholas Shahan 2020-07-14 00:09:29 +00:00 committed by commit-bot@chromium.org
parent 71d6b669a3
commit 9460ac3c8d
2 changed files with 15 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
sdk/BUILD.gn
View file

@ -631,27 +631,32 @@ copy("copy_dart2js_dill_files") {
outputs = [ "$root_out_dir/dart-sdk/lib/_internal/{{source_file_part}}" ]
}
# Copies DDC's SDK outline .dill to lib/_internal
copy("copy_dev_compiler_outline") {
# Copies DDC's SDK weak outline .dill to lib/_internal
# TODO(nshahan) Fix the outline to be consistent and merge with below as a
# breaking change.
copy("copy_dev_compiler_weak_outline") {
visibility = [ ":copy_dev_compiler_sdk" ]
deps = [
":copy_libraries",
"../utils/dartdevc:dartdevc_platform",
]
sources = [ "$root_out_dir/ddc_outline.dill" ]
# TODO(nshahan) Fix the name here to be consistent and merge with below.
outputs = [ "$root_out_dir/dart-sdk/lib/_internal/ddc_sdk.dill" ]
}
# Copies DDC's SDK outline .dill with sound null safety to lib/_internal
copy("copy_dev_compiler_outline_sound") {
visibility = [ "../utils/dartdevc:dartdevc_test" ]
# Copies DDC's SDK full and outline .dill files to lib/_internal.
copy("copy_dev_compiler_dills") {
visibility = [ ":copy_dev_compiler_sdk" ]
deps = [
":copy_libraries",
"../utils/dartdevc:dartdevc_platform",
"../utils/dartdevc:dartdevc_platform_sound",
]
sources = [ "$root_out_dir/ddc_outline_sound.dill" ]
sources = [
"$root_out_dir/ddc_outline_sound.dill",
"$root_out_dir/ddc_platform.dill",
"$root_out_dir/ddc_platform_sound.dill",
]
outputs = [ "$root_out_dir/dart-sdk/lib/_internal/{{source_file_part}}" ]
}
@ -731,9 +736,10 @@ copy("copy_dev_compiler_tools") {
group("copy_dev_compiler_sdk") {
visibility = [ ":create_full_sdk" ]
public_deps = [
":copy_dev_compiler_dills",
":copy_dev_compiler_js",
":copy_dev_compiler_outline",
":copy_dev_compiler_tools",
":copy_dev_compiler_weak_outline",
]
}

4
utils/dartdevc/BUILD.gn
View file

@ -141,10 +141,6 @@ group("dartdevc_test") {
":dartdevc_test_kernel_pkg",
"../..:create_sdk",
]
# TODO(nshahan) Temporarily here until we decide if we are going to include
# in the create_sdk target.
deps += [ "../../sdk:copy_dev_compiler_outline_sound" ]
}
# Builds everything needed to run dartdevc tests locally using test.dart without