languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 11:03:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

[macros] Fix flakiness on Windows related to add during flush and timeouts.

Browse source 
R=jakemac@google.com

Change-Id: I48f5829613ca2999caf23a485648054b920596a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352907
Reviewed-by: Jake Macdonald <jakemac@google.com>
Auto-Submit: Morgan :) <davidmorgan@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
This commit is contained in:
David Morgan 2024-02-20 15:47:10 +00:00 committed by Commit Queue
parent e1f1151870
commit 93b7791c0c
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/_fe_analyzer_shared/lib/src/macros/compiler/request_channel.dart
View file

@ -124,7 +124,6 @@ class RequestChannel {
final ByteData lengthByteData = new ByteData(4)..setUint32(0, bytes.length);
_socket.add(lengthByteData.buffer.asUint8List());
_socket.add(bytes);
_socket.flush();
}
/// Serializes and sends the [object].

2
pkg/analyzer/test/src/summary/macro_test.dart
View file

@ -954,6 +954,7 @@ class MacroArgumentsTest extends MacroElementsBaseTest {
@override
bool get keepLinkingLibraries => true;
@TestTimeout(Timeout(Duration(seconds: 60)))
test_error() async {
await _assertTypesPhaseArgumentsText(
fields: {
@ -10913,6 +10914,7 @@ class MacroStaticTypeTest extends MacroElementsBaseTest {
);
}
@TestTimeout(Timeout(Duration(seconds: 60)))
test_isExactly() async {
const testCases = {
('double', 'double', true),