languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 14:49:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[deps] rev package:lints to the latest; address lints

Browse source 
Change-Id: I64032a39c589c291297decade18f6a46c08f9c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310966
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
This commit is contained in:
Devon Carew 2023-06-27 17:03:37 +00:00 committed by Commit Queue
parent 3a9c1e6d6d
commit 9216f830c6
4 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
DEPS
View file

@ -152,7 +152,7 @@ vars = {
"json_rpc_2_rev": "73467f3651669af4870260fea4e99d7ba6ccb7ec",
"leak_tracker_rev": "c75b0a71bb1b92abf2c692459a7cb2df5f2af083",
"linter_rev": "f83b00f1185d6f8d22c7bf206ae7822c423f13d3", # disable rev_sdk_deps.dart
"lints_rev": "4b79906085d48fc4eee241a80e1a1b177dbdaf23",
"lints_rev": "79581ff1c45b6eb3b7db961031e55febf44eed41",
"logging_rev": "f2fe2ac2a61a269b2e0ce65be330f7af1bc67428",
"markdown_rev": "bd6ae8d741327e24319f3e036d57107f91229843",
"matcher_rev": "7e1011772566a8d1817c725a71f091e2791721c8",

2
pkg/dart2wasm/lib/ffi_native_transformer.dart
View file

@ -128,7 +128,7 @@ class WasmFfiNativeTransformer extends FfiNativeTransformer {
final isLeafField =
ffiConstant.fieldValues[nativeIsLeafField.fieldReference];
final isLeaf = (isLeafField as BoolConstant).value;
final assetField = ffiConstant.fieldValues[nativeAssetField];
final assetField = ffiConstant.fieldValues[nativeAssetField.fieldReference];
final assetName = (assetField is StringConstant)
? assetField
: (currentAsset ?? StringConstant("ffi"));

3
pkg/dart2wasm/lib/types.dart
View file

@ -30,9 +30,6 @@ class InterfaceTypeEnvironment {
void _add(InterfaceType type) {
Class cls = type.classNode;
if (_typeOffsets.containsKey(cls)) {
return;
}
int i = 0;
for (TypeParameter typeParameter in cls.typeParameters) {
_typeOffsets[typeParameter] = i++;

2
pkg/test_runner/lib/src/test_progress.dart
View file

@ -175,7 +175,7 @@ class UnexpectedCrashLogger extends EventListener {
final kernelServiceBaseName = 'kernel-service.dart.snapshot';
final kernelService =
File('${binFile.parent.path}/$kernelServiceBaseName');
if (!archivedBinaries.containsKey(kernelService) &&
if (!archivedBinaries.containsKey(kernelService.path) &&
kernelService.existsSync()) {
final archived = "binary.${mode}_${arch}_$kernelServiceBaseName";
TestUtils.copyFile(Path(kernelService.path), Path(archived));