mirror of
https://github.com/dart-lang/sdk
synced 2024-09-15 23:09:48 +00:00
[gen_snapshot] Do not add any dependency file in the kernel flow.
Adding a dependency file triggers resolving its file path using the service isolate. However, in the kernel flow, gen_snapshot does not initialize the service isolate. This does not seem to cause any problems on Mac and Linux, but flutter crashes on Windows. On Linux and Mac, the behaviour with this change matches the current behavior. The correct dependency file to add to the dependencies file in the kernel flow is the app dill file passed as input to gen_snapshot. But, this would call for specifyint the application sources as the dependency for the app dill file itself somewhere. We can revisit this and fix it up correctly if needed. For now, this change unblocks the Windows builds. Change-Id: Ic22a7ccc96548e005b85308c3baaeedb860f4dae Reviewed-on: https://dart-review.googlesource.com/31280 Commit-Queue: Siva Chandra <sivachandra@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
This commit is contained in:
parent
eb7454cb20
commit
914720524a
|
@ -1425,10 +1425,6 @@ static int GenerateSnapshotFromKernelProgram(void* kernel_program) {
|
|||
return kErrorExitCode;
|
||||
}
|
||||
|
||||
if (commandline_packages_file != NULL) {
|
||||
AddDependency(commandline_packages_file);
|
||||
}
|
||||
|
||||
Dart_QualifiedFunctionName* entry_points =
|
||||
ParseEntryPointsManifestIfPresent();
|
||||
SetupStubNativeResolversForPrecompilation(entry_points);
|
||||
|
|
Loading…
Reference in a new issue