languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:17:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

[gardening] Reduce number of samples expected in service/get_cpu_samples_rpc_test, take 2

Browse source 
Now fixing runtime/observatory_2/tests/service_2/get_cpu_samples_rpc_test.dart
in addition to runtime/observatory/tests/service/get_cpu_samples_rpc_test.dart,
which was fixed in https://dart-review.googlesource.com/c/sdk/+/167043.

This test has been failing on vm-kernel-precomp-win-release-x64 bot as
it was getting only 3-10 samples, while expecting >10.
The expectation doesn't look reliable as we cannot guarantee that
profiler would collect enough samples.
Changed the expectation to >0 samples, in an attempt to make this test
less flaky.

Change-Id: Ifbe1b0a4d5ea56bc1b29ef9cbf15df0710187c07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167147
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
This commit is contained in:
Alexander Markov 2020-10-12 23:23:02 +00:00 committed by commit-bot@chromium.org
parent 745f112ef6
commit 8d8f57065d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/observatory_2/tests/service_2/get_cpu_samples_rpc_test.dart
View file

@ -35,7 +35,7 @@ Future checkSamples(Isolate isolate) async {
reason: "Should have many code objects");
final samples = result['samples'];
expect(samples.length, greaterThan(10), reason: "Should have many samples");
expect(samples.length, greaterThan(0), reason: "Should have samples");
final sample = samples.first;
expect(sample['tid'], isInt);
expect(sample['timestamp'], isInt);