Change terms to be more divisive

Based on guidance in https://developers.google.com/style/

Related to https://github.com/dart-lang/sdk/issues/42247

Change-Id: Ia4edb2cb0540781f1119c369406a7b65553e26f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150632
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
This commit is contained in:
Michael Thomsen 2020-06-10 17:14:37 +00:00 committed by commit-bot@chromium.org
parent 5b51895652
commit 8d65076f18
4 changed files with 14 additions and 14 deletions

View file

@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
// Dart test checking that static/instance field shadowing do not conflict.
// Test that certain interfaces/classes are blacklisted from being
// Test that certain interfaces/classes are denylisted from being
// implemented or extended.
// bool.

View file

@ -14,7 +14,7 @@ import 'dart:async';
import 'dart:io';
// Methods to be skipped, by qualified name.
var blacklist = [
var denylist = [
// Don't recurse on this test.
'test.invoke_natives',
@ -39,9 +39,9 @@ var blacklist = [
new RegExp(r"^dart\.async\._.*$"),
];
bool isBlacklisted(Symbol qualifiedSymbol) {
bool isDenylisted(Symbol qualifiedSymbol) {
var qualifiedString = MirrorSystem.getName(qualifiedSymbol);
for (var pattern in blacklist) {
for (var pattern in denylist) {
if (qualifiedString.contains(pattern)) {
print('Skipping $qualifiedString');
return true;
@ -58,7 +58,7 @@ class Task {
var queue = <Task>[];
checkMethod(MethodMirror m, ObjectMirror target, [origin]) {
if (isBlacklisted(m.qualifiedName)) return;
if (isDenylisted(m.qualifiedName)) return;
var task = new Task();
task.name = '${MirrorSystem.getName(m.qualifiedName)} from $origin';
@ -97,7 +97,7 @@ checkClass(classMirror) {
classMirror.declarations.values
.where((d) => d is MethodMirror && d.isConstructor)
.forEach((m) {
if (isBlacklisted(m.qualifiedName)) return;
if (isDenylisted(m.qualifiedName)) return;
var task = new Task();
task.name = MirrorSystem.getName(m.qualifiedName);
@ -112,7 +112,7 @@ checkClass(classMirror) {
checkLibrary(libraryMirror) {
print(libraryMirror.simpleName);
if (isBlacklisted(libraryMirror.qualifiedName)) return;
if (isDenylisted(libraryMirror.qualifiedName)) return;
libraryMirror.declarations.values
.where((d) => d is ClassMirror)

View file

@ -14,7 +14,7 @@ import 'dart:async';
import 'dart:io';
// Methods to be skipped, by qualified name.
var blacklist = [
var denylist = [
// Don't recurse on this test.
'test.invoke_natives',
@ -39,9 +39,9 @@ var blacklist = [
new RegExp(r"^dart\.async\._.*$"),
];
bool isBlacklisted(Symbol qualifiedSymbol) {
bool isDenylisted(Symbol qualifiedSymbol) {
var qualifiedString = MirrorSystem.getName(qualifiedSymbol);
for (var pattern in blacklist) {
for (var pattern in denylist) {
if (qualifiedString.contains(pattern)) {
print('Skipping $qualifiedString');
return true;
@ -58,7 +58,7 @@ class Task {
var queue = new List<Task>();
checkMethod(MethodMirror m, ObjectMirror target, [origin]) {
if (isBlacklisted(m.qualifiedName)) return;
if (isDenylisted(m.qualifiedName)) return;
var task = new Task();
task.name = '${MirrorSystem.getName(m.qualifiedName)} from $origin';
@ -97,7 +97,7 @@ checkClass(classMirror) {
classMirror.declarations.values
.where((d) => d is MethodMirror && d.isConstructor)
.forEach((m) {
if (isBlacklisted(m.qualifiedName)) return;
if (isDenylisted(m.qualifiedName)) return;
var task = new Task();
task.name = MirrorSystem.getName(m.qualifiedName);
@ -112,7 +112,7 @@ checkClass(classMirror) {
checkLibrary(libraryMirror) {
print(libraryMirror.simpleName);
if (isBlacklisted(libraryMirror.qualifiedName)) return;
if (isDenylisted(libraryMirror.qualifiedName)) return;
libraryMirror.declarations.values
.where((d) => d is ClassMirror)

View file

@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
// Dart test checking that static/instance field shadowing do not conflict.
// Test that certain interfaces/classes are blacklisted from being
// Test that certain interfaces/classes are denylisted from being
// implemented or extended (VM corelib only).
library BlackListedTest;