languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 04:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

dart2js cps: Set receiver-nullability in analysis pass.

Browse source 
Setting receiverIsNotNull, objectIsNotNull in the analysis pass
simplifies the transformation pass since predicates like
'isSafeForElimination' depend on them.

This would prevent constant folding of array lengths since
GetLength was not marked as safe for elimination at the
time it was considered for constant folding.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1348233002 .
This commit is contained in:
Asger Feldthaus 2015-09-21 12:43:26 +02:00
parent eee0e77207
commit 8c6b990305
1 changed files with 6 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
pkg/compiler/lib/src/cps_ir/type_propagation.dart
View file

@ -982,8 +982,7 @@ class TransformingVisitor extends LeafVisitor {
CpsFragment cps = new CpsFragment(sourceInfo);
cps.invokeBuiltin(BuiltinMethod.Push,
list,
<Primitive>[addedItem],
receiverIsNotNull: listValue.isDefinitelyNotNull);
<Primitive>[addedItem]);
cps.invokeContinuation(cont, [cps.makeNull()]);
replaceSubtree(node, cps.result);
push(cps.result);
@ -1006,8 +1005,7 @@ class TransformingVisitor extends LeafVisitor {
[list, fail.makeConstant(new IntConstantValue(-1))]);
Primitive removedItem = cps.invokeBuiltin(BuiltinMethod.Pop,
list,
<Primitive>[],
receiverIsNotNull: listValue.isDefinitelyNotNull);
<Primitive>[]);
cps.invokeContinuation(cont, [removedItem]);
replaceSubtree(node, cps.result);
push(cps.result);
@ -1031,8 +1029,7 @@ class TransformingVisitor extends LeafVisitor {
CpsFragment cps = new CpsFragment(sourceInfo);
cps.invokeBuiltin(BuiltinMethod.Push,
list,
addedLiteral.values.map((ref) => ref.definition).toList(),
receiverIsNotNull: listValue.isDefinitelyNotNull);
addedLiteral.values.map((ref) => ref.definition).toList());
cps.invokeContinuation(cont, [cps.makeNull()]);
replaceSubtree(node, cps.result);
push(cps.result);
@ -1480,7 +1477,6 @@ class TransformingVisitor extends LeafVisitor {
if (specializeClosureCall(node)) return;
AbstractValue receiver = getValue(node.receiver.definition);
node.receiverIsNotNull = receiver.isDefinitelyNotNull;
if (node.receiverIsIntercepted &&
node.receiver.definition.sameValue(node.arguments[0].definition)) {
@ -1837,14 +1833,6 @@ class TransformingVisitor extends LeafVisitor {
return null;
}
void visitGetField(GetField node) {
node.objectIsNotNull = getValue(node.object.definition).isDefinitelyNotNull;
}
void visitGetLength(GetLength node) {
node.objectIsNotNull = getValue(node.object.definition).isDefinitelyNotNull;
}
Primitive visitInterceptor(Interceptor node) {
AbstractValue value = getValue(node.input.definition);
// If the exact class of the input is known, replace with a constant
@ -2143,6 +2131,7 @@ class TypePropagationVisitor implements Visitor {
void visitInvokeMethod(InvokeMethod node) {
AbstractValue receiver = getValue(node.receiver.definition);
node.receiverIsNotNull = receiver.isDefinitelyNotNull;
if (receiver.isNothing) {
return; // And come back later.
}
@ -2447,6 +2436,7 @@ class TypePropagationVisitor implements Visitor {
}
void visitGetField(GetField node) {
node.objectIsNotNull = getValue(node.object.definition).isDefinitelyNotNull;
setValue(node, nonConstant(typeSystem.getFieldType(node.field)));
}
@ -2492,6 +2482,7 @@ class TypePropagationVisitor implements Visitor {
@override
void visitGetLength(GetLength node) {
AbstractValue input = getValue(node.object.definition);
node.objectIsNotNull = getValue(node.object.definition).isDefinitelyNotNull;
int length = typeSystem.getContainerLength(input.type);
if (length != null) {
// TODO(asgerf): Constant-folding the length might degrade the VM's