languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-05 18:22:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't emit the lazy deopt sequence when we can't deopt.

Browse source 
Saves 3.2% of instructions size for precompiled hello world on ARM.

R=fschneider@google.com

Review URL: https://codereview.chromium.org//1367573002 .
This commit is contained in:
Ryan Macnak 2015-09-23 12:27:52 -07:00
parent 66f9abc7e3
commit 8c44721965
5 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/vm/flow_graph_compiler_arm.cc
View file

@ -1109,7 +1109,7 @@ void FlowGraphCompiler::CompileGraph() {
ASSERT(assembler()->constant_pool_allowed()); ASSERT(assembler()->constant_pool_allowed());
GenerateDeferredCode(); GenerateDeferredCode();
if (is_optimizing()) { if (is_optimizing() && Compiler::allow_recompilation()) {
// Leave enough space for patching in case of lazy deoptimization from // Leave enough space for patching in case of lazy deoptimization from
// deferred code. // deferred code.
for (intptr_t i = 0; for (intptr_t i = 0;

2
runtime/vm/flow_graph_compiler_arm64.cc
View file

@ -1110,7 +1110,7 @@ void FlowGraphCompiler::CompileGraph() {
ASSERT(assembler()->constant_pool_allowed()); ASSERT(assembler()->constant_pool_allowed());
GenerateDeferredCode(); GenerateDeferredCode();
if (is_optimizing()) { if (is_optimizing() && Compiler::allow_recompilation()) {
// Leave enough space for patching in case of lazy deoptimization from // Leave enough space for patching in case of lazy deoptimization from
// deferred code. // deferred code.
for (intptr_t i = 0; for (intptr_t i = 0;

2
runtime/vm/flow_graph_compiler_ia32.cc
View file

@ -1128,7 +1128,7 @@ void FlowGraphCompiler::CompileGraph() {
__ int3(); __ int3();
GenerateDeferredCode(); GenerateDeferredCode();
if (is_optimizing()) { if (is_optimizing() && Compiler::allow_recompilation()) {
// Leave enough space for patching in case of lazy deoptimization from // Leave enough space for patching in case of lazy deoptimization from
// deferred code. // deferred code.
__ nop(CallPattern::pattern_length_in_bytes()); __ nop(CallPattern::pattern_length_in_bytes());

2
runtime/vm/flow_graph_compiler_mips.cc
View file

@ -1126,7 +1126,7 @@ void FlowGraphCompiler::CompileGraph() {
__ break_(0); __ break_(0);
GenerateDeferredCode(); GenerateDeferredCode();
if (is_optimizing()) { if (is_optimizing() && Compiler::allow_recompilation()) {
// Leave enough space for patching in case of lazy deoptimization from // Leave enough space for patching in case of lazy deoptimization from
// deferred code. // deferred code.
for (intptr_t i = 0; for (intptr_t i = 0;

2
runtime/vm/flow_graph_compiler_x64.cc
View file

@ -1128,7 +1128,7 @@ void FlowGraphCompiler::CompileGraph() {
// Emit function patching code. This will be swapped with the first 13 bytes // Emit function patching code. This will be swapped with the first 13 bytes
// at entry point. // at entry point.
if (is_optimizing()) { if (is_optimizing() && Compiler::allow_recompilation()) {
// Leave enough space for patching in case of lazy deoptimization from // Leave enough space for patching in case of lazy deoptimization from
// deferred code. // deferred code.
__ nop(ShortCallPattern::pattern_length_in_bytes()); __ nop(ShortCallPattern::pattern_length_in_bytes());