languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 08:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollforward of the dart_io_api.h include change, with a fix for flutter.

Browse source 
The fix for the flutter build was to switch include_dirs from . to include/ in the dart_public_config. The other files in include/ were compiling correctly because their #includes were being treated as relative paths, but dart_io_api.h is in a subdirectory. In future, clients should be able to just add include/ to their C++ includes.

Tested: Dart tests, and verified that flutter engine compiles.
Bug: https://github.com/dart-lang/sdk/issues/35172
Change-Id: Ic74d7c1cdedeac32df939c53c1fd57a1260072a3
Reviewed-on: https://dart-review.googlesource.com/c/84686
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
This commit is contained in:
Liam Appelbe 2018-11-19 18:16:11 +00:00 committed by commit-bot@chromium.org
parent 4e8ffc06cf
commit 899d1c15c7
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/BUILD.gn
View file

@ -7,7 +7,7 @@ import("configs.gni")
import("runtime_args.gni")
config("dart_public_config") {
include_dirs = [ "." ]
include_dirs = [ "include" ]
}
# Adds PRODUCT define if Flutter has specified "release" for dart_runtime_mode

2
runtime/include/bin/dart_io_api.h
View file

@ -5,7 +5,7 @@
#ifndef RUNTIME_INCLUDE_BIN_DART_IO_API_H_
#define RUNTIME_INCLUDE_BIN_DART_IO_API_H_
#include "include/dart_tools_api.h"
#include "dart_tools_api.h"
namespace dart {
namespace bin {