languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 09:54:38 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[vm] Remove unused --print-benchmarking-metrics flag

Browse source 
This flag doesn't seem to be used anywhere, neither of
dart/flutter/golem/g3.

Main motivation is to remove the GC triggering code in
Isolate::MakeRunnable.

Issue https://github.com/dart-lang/sdk/issues/36097

Change-Id: If48072f62974dec5f7c19cc08be7904401e38a61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171282
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Martin Kustermann 2020-11-10 18:41:24 +00:00 committed by commit-bot@chromium.org
parent 87cb3ede9e
commit 86fdeab739
3 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/vm/flag_list.h
View file

@ -167,8 +167,6 @@ constexpr bool kDartUseBackgroundCompilation = true;
P(print_snapshot_sizes, bool, false, "Print sizes of generated snapshots.") \
P(print_snapshot_sizes_verbose, bool, false, \
"Print cluster sizes of generated snapshots.") \
P(print_benchmarking_metrics, bool, false, \
"Print additional memory and latency metrics for benchmarking.") \
R(print_ssa_liveranges, false, bool, false, \
"Print live ranges after allocation.") \
R(print_stacktrace_at_api_error, false, bool, false, \

11
runtime/vm/isolate.cc
View file

@ -2091,15 +2091,6 @@ const char* Isolate::MakeRunnable() {
Service::HandleEvent(&runnableEvent);
}
GetRunnableLatencyMetric()->set_value(UptimeMicros());
if (FLAG_print_benchmarking_metrics) {
{
StartIsolateScope scope(this);
heap()->CollectAllGarbage();
}
int64_t heap_size = (heap()->UsedInWords(Heap::kNew) * kWordSize) +
(heap()->UsedInWords(Heap::kOld) * kWordSize);
GetRunnableHeapSizeMetric()->set_value(heap_size);
}
#endif // !PRODUCT
return nullptr;
}
@ -2553,7 +2544,7 @@ void Isolate::LowLevelShutdown() {
"\tisolate: %s\n",
name());
}
if (FLAG_print_metrics || FLAG_print_benchmarking_metrics) {
if (FLAG_print_metrics) {
LogBlock lb;
OS::PrintErr("Printing metrics for %s\n", name());
#define ISOLATE_GROUP_METRIC_PRINT(type, variable, name, unit) \

2
runtime/vm/metrics.cc
View file

@ -206,7 +206,7 @@ void Metric::Init() {
}
void Metric::Cleanup() {
if (FLAG_print_metrics || FLAG_print_benchmarking_metrics) {
if (FLAG_print_metrics) {
// Create a zone to allocate temporary strings in.
StackZone sz(Thread::Current());
OS::PrintErr("Printing metrics for VM\n");