languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 04:06:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid non-web-integer literals in corelib_2/num_sign_test

Browse source 
Change-Id: I756ef8129b0e1c7024833fb98ed96eea987dbb59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108280
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This commit is contained in:
Stephen Adams 2019-07-05 19:43:47 +00:00 committed by commit-bot@chromium.org
parent f0da490328
commit 8673b5e491
2 changed files with 26 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/corelib_2/corelib_2.status
View file

@ -41,7 +41,6 @@ iterable_return_type_test/02: RuntimeError # Dart2js does not support Uint64*.
list_unmodifiable_test: Pass, RuntimeError # Issue 28712
num_parse_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
num_parse_test/none: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
num_sign_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
[ $compiler != dartdevc ]
error_stack_trace_test/static: MissingCompileTimeError
@ -319,7 +318,6 @@ main_test: RuntimeError # Issue 29921
nan_infinity_test/01: RuntimeError # Issue 29921
num_parse_test/01: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
num_parse_test/none: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
num_sign_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
regexp/alternative-length-miscalculation_test: RuntimeError # Issue 29921
regexp/ascii-regexp-subject_test: RuntimeError # Issue 29921
regexp/bol-with-multiline_test: RuntimeError # Issue 29921

13
tests/corelib_2/num_sign_test.dart
View file

@ -44,12 +44,15 @@ var numbers = [
0x10000000000001,
0x1fffffffffffff,
0x20000000000000,
0x20000000000001, // first integer not representable as double.
0x20000000000002,
0x7fffffffffffffff, // ~63 bits
// Use arithmetic to construct values below since they are not valid 'web
// integers'. On platforms that use doubles to represent integers, there will
// be some rounding in the arithmetic, testing a nearby value instead.
0x20000000000000 + 1, // first integer not representable as double.
0x20000000000000 + 2,
0x7ffffffffffff000 + 0xfff, // ~63 bits
0x8000000000000000,
0x8000000000000001,
0xffffffffffffffff, // ~64 bits
0x8000000000000000 + 1,
0xfffffffffffff000 + 0xfff, // ~64 bits
// Doubles.
0.0,
5e-324, // min positive