languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

Make visibleLength/visibleOffset informative.

Browse source 
These summary fields are related to source offsets, so they are
affected by minute changes to the source code that don't affect its
API; therefore they should be marked as "@informative" so that they
don't appear in API summaries.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2432183003 .
This commit is contained in:
Paul Berry 2016-10-19 14:24:42 -07:00
parent 4729ba0055
commit 84ec7f01c0
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/analyzer/lib/src/summary/format.dart
View file

@ -5370,6 +5370,8 @@ class UnlinkedExecutableBuilder extends Object with _UnlinkedExecutableMixin imp
_redirectedConstructor?.flushInformative(); _redirectedConstructor?.flushInformative();
_returnType?.flushInformative(); _returnType?.flushInformative();
_typeParameters?.forEach((b) => b.flushInformative()); _typeParameters?.forEach((b) => b.flushInformative());
_visibleLength = null;
_visibleOffset = null;
} }
/** /**
@ -5430,8 +5432,6 @@ class UnlinkedExecutableBuilder extends Object with _UnlinkedExecutableMixin imp
x?.collectApiSignature(signature); x?.collectApiSignature(signature);
} }
} }
signature.addInt(this._visibleLength ?? 0);
signature.addInt(this._visibleOffset ?? 0);
signature.addInt(this._constCycleSlot ?? 0); signature.addInt(this._constCycleSlot ?? 0);
signature.addBool(this._bodyExpr != null); signature.addBool(this._bodyExpr != null);
this._bodyExpr?.collectApiSignature(signature); this._bodyExpr?.collectApiSignature(signature);

2
pkg/analyzer/lib/src/summary/idl.dart
View file

@ -1926,12 +1926,14 @@ abstract class UnlinkedExecutable extends base.SummaryClass {
/** /**
* If a local function, the length of the visible range; zero otherwise. * If a local function, the length of the visible range; zero otherwise.
*/ */
@informative
@Id(20) @Id(20)
int get visibleLength; int get visibleLength;
/** /**
* If a local function, the beginning of the visible range; zero otherwise. * If a local function, the beginning of the visible range; zero otherwise.
*/ */
@informative
@Id(21) @Id(21)
int get visibleOffset; int get visibleOffset;
} }