languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-21 00:21:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix analyzer warnings in tools/testing/dart/test_progress.dart

Browse source 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2642153002 .
This commit is contained in:
Vyacheslav Egorov 2017-01-19 17:49:52 +01:00
parent 369446f432
commit 84820ba05e
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tools/testing/dart/test_progress.dart
View file

@ -319,17 +319,20 @@ class UnexpectedCrashDumpArchiver extends EventListener {
final archivedBinaries = new Set<String>();
void done(TestCase test) {
if (test.unexpectedOutput && test.result == Expectation.CRASH) {
if (test.unexpectedOutput &&
test.result == Expectation.CRASH &&
test.lastCommandExecuted is ProcessCommand) {
final name = "core.${test.lastCommandOutput.pid}";
final file = new File(name);
final exists = file.existsSync();
if (exists) {
final lastCommand = test.lastCommandExecuted as ProcessCommand;
// We have a coredump for the process. This coredump will be archived by
// CoreDumpArchiver (see tools/utils.py). For debugging purposes we
// need to archive the crashed binary as well. To simplify the
// archiving code we simply copy binaries into current folder next to
// core dumps and name them `core.${mode}_${arch}_${binary_name}`.
final binName = test.lastCommandExecuted.executable;
final binName = lastCommand.executable;
final binFile = new File(binName);
final binBaseName = new Path(binName).filename;
if (archivedBinaries.contains(binBaseName)) {