languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 16:37:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up some hints from the analyzer code base

Browse source 
Change-Id: I5fedd885d2a6853e809803fc46cf7008f76ed9bd
Reviewed-on: https://dart-review.googlesource.com/68000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Brian Wilkerson 2018-08-02 12:39:36 +00:00 committed by commit-bot@chromium.org
parent c5f933fdf7
commit 841f62715a
5 changed files with 15 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analyzer/lib/src/dart/analysis/driver.dart
View file

@ -52,7 +52,7 @@ import 'package:meta/meta.dart';
* but this breaks `AnalysisContext` and code generation. So, for now let's
* work around them, and rewrite generators to [AnalysisDriver].
*/
typedef Future<Null> WorkToWaitAfterComputingResult(String path);
typedef Future<void> WorkToWaitAfterComputingResult(String path);
/**
* This class computes [AnalysisResult]s for Dart files.

2
pkg/analyzer/lib/src/summary/link.dart
View file

@ -1102,6 +1102,8 @@ abstract class CompilationUnitElementForLink
return new FunctionTypeAliasElementForLink(this, t);
} else if (t.style == TypedefStyle.genericFunctionType) {
return new GenericTypeAliasElementForLink(this, t);
} else {
throw new StateError('Unhandled style of typedef: ${t.style}');
}
}).toList();

6
pkg/analyzer/test/src/dart/analysis/driver_test.dart
View file

@ -594,7 +594,7 @@ part 'part.dart';
// We also request a new result, which must include the change.
Future<AnalysisResult> future2;
bool asyncWorkExecuted = false;
driver.test.workToWaitAfterComputingResult = (path) {
driver.test.workToWaitAfterComputingResult = (path) async {
provider.updateFile(path, 'class B {}');
driver.changeFile(path);
future2 = driver.getResult(testFile);
@ -622,7 +622,7 @@ part 'part.dart';
// Simulate a change that happens during computing the result.
bool asyncWorkExecuted = false;
driver.test.workToWaitAfterComputingResult = (p) {
driver.test.workToWaitAfterComputingResult = (p) async {
if (p == path && !asyncWorkExecuted) {
provider.updateFile(path, 'class B');
driver.changeFile(path);
@ -645,7 +645,7 @@ part 'part.dart';
// Simulate a change that happens during computing the result.
bool asyncWorkExecuted = false;
driver.test.workToWaitAfterComputingResult = (p) {
driver.test.workToWaitAfterComputingResult = (p) async {
if (p == path && !asyncWorkExecuted) {
provider.updateFile(path, 'class B {}');
driver.changeFile(path);

8
pkg/analyzer/test/src/task/inputs_test.dart
View file

@ -346,7 +346,7 @@ class ListToListTaskInputTest extends EngineTestCase {
test_create() {
SimpleTaskInput<List> baseAccessor = result.of(target);
GenerateTaskInputs generate = (object) {};
GenerateTaskInputs generate = (object) => null;
ListToListTaskInput input = new ListToListTaskInput(baseAccessor, generate);
expect(input, isNotNull);
expect(input.baseAccessor, baseAccessor);
@ -355,7 +355,7 @@ class ListToListTaskInputTest extends EngineTestCase {
test_createBuilder() {
SimpleTaskInput<List> baseAccessor = result.of(target);
GenerateTaskInputs generate = (object) {};
GenerateTaskInputs generate = (object) => null;
ListToListTaskInput input = new ListToListTaskInput(baseAccessor, generate);
expect(input.createBuilder(), isNotNull);
}
@ -539,7 +539,7 @@ class ListToMapTaskInputTest extends EngineTestCase {
test_create() {
SimpleTaskInput<List> baseAccessor = result.of(target);
GenerateTaskInputs generate = (object) {};
GenerateTaskInputs generate = (object) => null;
ListToMapTaskInput input = new ListToMapTaskInput(baseAccessor, generate);
expect(input, isNotNull);
expect(input.baseAccessor, baseAccessor);
@ -548,7 +548,7 @@ class ListToMapTaskInputTest extends EngineTestCase {
test_createBuilder() {
SimpleTaskInput<List> baseAccessor = result.of(target);
GenerateTaskInputs generate = (object) {};
GenerateTaskInputs generate = (object) => null;
ListToMapTaskInput input = new ListToMapTaskInput(baseAccessor, generate);
expect(input.createBuilder(), isNotNull);
}

10
pkg/analyzer/test/src/task/model_test.dart
View file

@ -103,8 +103,8 @@ class SimpleResultCachingPolicyTest extends EngineTestCase {
class TaskDescriptorImplTest extends EngineTestCase {
test_create_noOptionalArgs() {
String name = 'name';
BuildTask buildTask = (context, target) {};
CreateTaskInputs createTaskInputs = (target) {};
BuildTask buildTask = (context, target) => null;
CreateTaskInputs createTaskInputs = (target) => null;
List<ResultDescriptor> results = <ResultDescriptor>[];
TaskDescriptorImpl descriptor =
new TaskDescriptorImpl(name, buildTask, createTaskInputs, results);
@ -118,8 +118,8 @@ class TaskDescriptorImplTest extends EngineTestCase {
test_create_withIsAppropriateFor() {
String name = 'name';
BuildTask buildTask = (context, target) {};
CreateTaskInputs createTaskInputs = (target) {};
BuildTask buildTask = (context, target) => null;
CreateTaskInputs createTaskInputs = (target) => null;
List<ResultDescriptor> results = <ResultDescriptor>[];
SuitabilityFor suitabilityFor = (target) => TaskSuitability.NONE;
TaskDescriptorImpl descriptor = new TaskDescriptorImpl(
@ -136,7 +136,7 @@ class TaskDescriptorImplTest extends EngineTestCase {
test_createTask() {
BuildTask buildTask =
(context, target) => new TestAnalysisTask(context, target);
CreateTaskInputs createTaskInputs = (target) {};
CreateTaskInputs createTaskInputs = (target) => null;
List<ResultDescriptor> results = <ResultDescriptor>[];
TaskDescriptorImpl descriptor =
new TaskDescriptorImpl('name', buildTask, createTaskInputs, results);