languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 19:21:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add an interface for request parameters"

Browse source 
Review-Url: https://codereview.chromium.org/2683583004 .
This commit is contained in:
Brian Wilkerson 2017-02-07 13:34:58 -08:00
parent fbd281c64a
commit 82d0383566
3 changed files with 14 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
pkg/analyzer_plugin/lib/protocol/generated_protocol.dart
View file

@ -800,7 +800,7 @@ class AnalysisFoldingParams implements HasToJson {
*
* Clients may not extend, implement or mix-in this class.
*/
class AnalysisHandleWatchEventsParams implements RequestParams {
class AnalysisHandleWatchEventsParams implements HasToJson {
List<WatchEvent> _events;
/**
@ -1393,7 +1393,7 @@ class AnalysisOutlineParams implements HasToJson {
*
* Clients may not extend, implement or mix-in this class.
*/
class AnalysisReanalyzeParams implements RequestParams {
class AnalysisReanalyzeParams implements HasToJson {
List<String> _roots;
/**
@ -1574,7 +1574,7 @@ class AnalysisService implements Enum {
*
* Clients may not extend, implement or mix-in this class.
*/
class AnalysisSetContextBuilderOptionsParams implements RequestParams {
class AnalysisSetContextBuilderOptionsParams implements HasToJson {
ContextBuilderOptions _options;
/**
@ -1683,7 +1683,7 @@ class AnalysisSetContextBuilderOptionsResult implements ResponseResult {
*
* Clients may not extend, implement or mix-in this class.
*/
class AnalysisSetContextRootsParams implements RequestParams {
class AnalysisSetContextRootsParams implements HasToJson {
List<ContextRoot> _roots;
/**
@ -1792,7 +1792,7 @@ class AnalysisSetContextRootsResult implements ResponseResult {
*
* Clients may not extend, implement or mix-in this class.
*/
class AnalysisSetPriorityFilesParams implements RequestParams {
class AnalysisSetPriorityFilesParams implements HasToJson {
List<String> _files;
/**
@ -1901,7 +1901,7 @@ class AnalysisSetPriorityFilesResult implements ResponseResult {
*
* Clients may not extend, implement or mix-in this class.
*/
class AnalysisSetSubscriptionsParams implements RequestParams {
class AnalysisSetSubscriptionsParams implements HasToJson {
Map<AnalysisService, List<String>> _subscriptions;
/**
@ -2012,7 +2012,7 @@ class AnalysisSetSubscriptionsResult implements ResponseResult {
*
* Clients may not extend, implement or mix-in this class.
*/
class AnalysisUpdateContentParams implements RequestParams {
class AnalysisUpdateContentParams implements HasToJson {
Map<String, dynamic> _files;
/**
@ -2202,7 +2202,7 @@ class ChangeContentOverlay implements HasToJson {
*
* Clients may not extend, implement or mix-in this class.
*/
class CompletionGetSuggestionsParams implements RequestParams {
class CompletionGetSuggestionsParams implements HasToJson {
String _file;
int _offset;
@ -3513,7 +3513,7 @@ class ConvertMethodToGetterOptions extends RefactoringOptions implements HasToJs
*
* Clients may not extend, implement or mix-in this class.
*/
class EditGetAssistsParams implements RequestParams {
class EditGetAssistsParams implements HasToJson {
String _file;
int _offset;
@ -3728,7 +3728,7 @@ class EditGetAssistsResult implements ResponseResult {
*
* Clients may not extend, implement or mix-in this class.
*/
class EditGetAvailableRefactoringsParams implements RequestParams {
class EditGetAvailableRefactoringsParams implements HasToJson {
String _file;
int _offset;
@ -3952,7 +3952,7 @@ class EditGetAvailableRefactoringsResult implements ResponseResult {
*
* Clients may not extend, implement or mix-in this class.
*/
class EditGetFixesParams implements RequestParams {
class EditGetFixesParams implements HasToJson {
String _file;
int _offset;
@ -4145,7 +4145,7 @@ class EditGetFixesResult implements ResponseResult {
*
* Clients may not extend, implement or mix-in this class.
*/
class EditGetRefactoringParams implements RequestParams {
class EditGetRefactoringParams implements HasToJson {
RefactoringKind _kind;
String _file;
@ -8357,7 +8357,7 @@ class PluginErrorParams implements HasToJson {
*
* Clients may not extend, implement or mix-in this class.
*/
class PluginShutdownParams implements RequestParams {
class PluginShutdownParams {
Request toRequest(String id) {
return new Request(id, "plugin.shutdown", null);
}
@ -8414,7 +8414,7 @@ class PluginShutdownResult implements ResponseResult {
*
* Clients may not extend, implement or mix-in this class.
*/
class PluginVersionCheckParams implements RequestParams {
class PluginVersionCheckParams implements HasToJson {
String _byteStorePath;
String _version;

8
pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart
View file

@ -471,14 +471,6 @@ class RequestDecoder extends JsonDecoder {
}
}
abstract class RequestParams implements HasToJson {
/**
* Return a request whose parameters are taken from this object and that has
* the given [id].
*/
Request toRequest(String id);
}
/**
* JsonDecoder for decoding responses from the server. This is intended to be
* used only for testing. Errors are reported using bare [Exception] objects.

4
pkg/analyzer_plugin/tool/spec/codegen_dart_protocol.dart
View file

@ -223,8 +223,6 @@ class CodegenProtocolVisitor extends DartCodegenVisitor with CodeGenerator {
writeln(' extends RefactoringFeedback implements HasToJson {');
} else if (impliedType.kind == 'refactoringOptions') {
writeln(' extends RefactoringOptions implements HasToJson {');
} else if (impliedType.kind == 'requestParams') {
writeln(' implements RequestParams {');
} else if (impliedType.kind == 'requestResult') {
writeln(' implements ResponseResult {');
} else {
@ -407,8 +405,6 @@ class CodegenProtocolVisitor extends DartCodegenVisitor with CodeGenerator {
writeln(' extends RefactoringFeedback {');
} else if (impliedType.kind == 'refactoringOptions') {
writeln(' extends RefactoringOptions {');
} else if (impliedType.kind == 'requestParams') {
writeln(' implements RequestParams {');
} else if (impliedType.kind == 'requestResult') {
writeln(' implements ResponseResult {');
} else {