mirror of
https://github.com/dart-lang/sdk
synced 2024-09-15 23:39:48 +00:00
[vm] Fix constant in PcRelativeCall pattern on x64
This fixes windows build which has different integer size so the literal constant makes a difference. This is a follow-up to [0] which added a test that revealed this issue. [0] https://dart-review.googlesource.com/c/sdk/+/195682 TEST=Fixes vm/cc/PCRelativeCallPatterns on windows. Change-Id: I82403753126e95b86ccca5de039fd703b61a119b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195921 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
This commit is contained in:
parent
b7c19384b7
commit
8156646b0c
|
@ -187,8 +187,8 @@ class PcRelativeTrampolineJumpPattern : public ValueObject {
|
||||||
|
|
||||||
class PcRelativeTailCallPattern : public PcRelativeTrampolineJumpPattern {
|
class PcRelativeTailCallPattern : public PcRelativeTrampolineJumpPattern {
|
||||||
public:
|
public:
|
||||||
static constexpr intptr_t kLowerCallingRange = -(1ul << 31) + kLengthInBytes;
|
static constexpr intptr_t kLowerCallingRange = -(DART_INT64_C(1) << 31) + kLengthInBytes;
|
||||||
static constexpr intptr_t kUpperCallingRange = (1ul << 31) - 1;
|
static constexpr intptr_t kUpperCallingRange = (DART_INT64_C(1) << 31) - 1;
|
||||||
|
|
||||||
explicit PcRelativeTailCallPattern(uword pc)
|
explicit PcRelativeTailCallPattern(uword pc)
|
||||||
: PcRelativeTrampolineJumpPattern(pc) {}
|
: PcRelativeTrampolineJumpPattern(pc) {}
|
||||||
|
|
Loading…
Reference in a new issue