languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 14:32:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[llvm] Make sure llvm groups don't break the build

Browse source 
This change makes it so that the llvm targets are empty on builds that
do not checkout llvm. Without this GN will perform certian sanity checks
against the build and those sanity checks will cause GN to fail when
those files are missing for one reason or another. Additionally if one
trys to build with the 'all' target in ninja these groups would fail at
build time even in posix systems like linux and mac where those sanity
checks pass even if the rules would still be bogus. All of these issues
go away if we make these groups no-ops when they would be bogus.

Change-Id: Iac973ff16a4b7258067a5d847da30e05c374969a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111521
Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
This commit is contained in:
Jake Ehrlich 2019-07-31 20:29:11 +00:00 committed by commit-bot@chromium.org
parent 521a106332
commit 7ffef4c616
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
BUILD.gn
View file

@ -126,16 +126,20 @@ group("analysis_server") {
}
group("check_llvm") {
deps = [
"runtime/llvm_codegen/test",
]
if (checkout_llvm) {
deps = [
"runtime/llvm_codegen/test",
]
}
}
group("llvm_codegen") {
deps = [
"runtime/llvm_codegen/codegen",
"runtime/llvm_codegen/bit",
]
if (checkout_llvm) {
deps = [
"runtime/llvm_codegen/codegen",
"runtime/llvm_codegen/bit",
]
}
}
# This is the target that is built on the dart2js build bots.