languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-03 00:08:46 +00:00
Code Issues Projects Releases Wiki Activity

[SDK] Remove conditional logic guarding generation of dds and dartdev snapshots on ARM

Browse Source 
The `sdk:copy_full_sdk_snapshots` target is dependent on
`utils/dartdev:dartdev` and `utils/dds:dds`, so these targets have been
getting built anyways when building the SDK.

TEST=Confirmed that
`./tools/build.py -mdebug -aarm_x64 --os=android create_sdk` does not
crash.

Fixes: https://github.com/dart-lang/sdk/issues/41776
Change-Id: I356218e542313f393ff2ea812d761ab8868955d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322520
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
This commit is contained in:
Derek Xu 2023-08-25 16:02:28 +00:00 committed by Commit Queue
parent 3094d06f81
commit 7f82667867
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
BUILD.gn
View File

@ -48,18 +48,11 @@ group("runtime") {
"runtime/bin:process_test",
"runtime/bin:run_vm_tests",
"runtime/vm:kernel_platform_files($host_toolchain)",
"utils/dartdev:dartdev",
"utils/dds:dds",
"utils/kernel-service:kernel-service",
]
# TODO(bkonyi): this dep causes a segfault on Android XARM_X64 builds.
# See issue #41776.
if (dart_target_arch != "arm") {
deps += [
"utils/dartdev:dartdev",
"utils/dds:dds",
]
}
# This flag is set in runtime/runtime_args.gni
# The analyze_snapshot tool is only supported on 64 bit AOT builds running
# under linux and android platforms