Issue 52202. Fix crash when object pattern type is potentially nullable.

Bug: https://github.com/dart-lang/sdk/issues/52202
Change-Id: I54068a58f68f46c3d75c1586e6ed575b361a22fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/299380
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>

pkg/_fe_analyzer_shared/lib/src/type_inference/type_analyzer.dart

@@ -1280,6 +1280,7 @@ mixin TypeAnalyzer<
     for (RecordPatternField<Node, Pattern> field in fields) {
       Type propertyType = overridePropertyGetType ??
           resolveObjectPatternPropertyGet(
+            objectPattern: node,
             receiverType: requiredType,
             field: field,
           );
@@ -2267,6 +2268,7 @@ mixin TypeAnalyzer<
   /// the name of the [field].  If the property cannot be resolved, the client
   /// should report an error, and return `dynamic` for recovery.
   Type resolveObjectPatternPropertyGet({
+    required Pattern objectPattern,
     required Type receiverType,
     required RecordPatternField<Node, Pattern> field,
   });

pkg/_fe_analyzer_shared/test/mini_ast.dart

@@ -3065,6 +3065,15 @@ class _MiniAstErrors
     });
   }
 
+  @override
+  void emptyMapPattern({
+    required Pattern pattern,
+  }) {
+    _recordError('emptyMapPattern', {
+      'pattern': pattern,
+    });
+  }
+
   @override
   void inconsistentJoinedPatternVariable({
     required covariant PatternVariableJoin variable,
@@ -3234,15 +3243,6 @@ class _MiniAstErrors
       fail('Same error reported twice: $errorText');
     }
   }
-
-  @override
-  void emptyMapPattern({
-    required Pattern pattern,
-  }) {
-    _recordError('emptyMapPattern', {
-      'pattern': pattern,
-    });
-  }
 }
 
 class _MiniAstTypeAnalyzer
@@ -3917,6 +3917,7 @@ class _MiniAstTypeAnalyzer
 
   @override
   Type resolveObjectPatternPropertyGet({
+    required Pattern objectPattern,
     required Type receiverType,
     required shared.RecordPatternField<Node, Pattern> field,
   }) {

pkg/analyzer/lib/src/generated/resolver.dart

@@ -1618,6 +1618,7 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
 
   @override
   DartType resolveObjectPatternPropertyGet({
+    required covariant ObjectPatternImpl objectPattern,
     required DartType receiverType,
     required covariant SharedPatternField field,
   }) {
@@ -1632,7 +1633,7 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
       receiver: null,
       receiverType: receiverType,
       name: nameToken.lexeme,
-      propertyErrorEntity: nameToken,
+      propertyErrorEntity: objectPattern.type,
       nameErrorEntity: nameToken,
     );
 

pkg/analyzer/test/src/dart/resolution/object_pattern_test.dart

@@ -787,6 +787,47 @@ ObjectPattern
 ''');
   }
 
+  test_typeAlias_nullable() async {
+    await assertErrorsInCode(r'''
+typedef A = int?;
+
+void f(x) {
+  switch (x) {
+    case A(foo: 0):
+      break;
+  }
+}
+''', [
+      error(CompileTimeErrorCode.UNCHECKED_PROPERTY_ACCESS_OF_NULLABLE_VALUE,
+          55, 1),
+    ]);
+    final node = findNode.singleGuardedPattern.pattern;
+    assertResolvedNodeText(node, r'''
+ObjectPattern
+  type: NamedType
+    name: SimpleIdentifier
+      token: A
+      staticElement: self::@typeAlias::A
+      staticType: null
+    type: int?
+      alias: self::@typeAlias::A
+  leftParenthesis: (
+  fields
+    PatternField
+      name: PatternFieldName
+        name: foo
+        colon: :
+      pattern: ConstantPattern
+        expression: IntegerLiteral
+          literal: 0
+          staticType: int
+        matchedValueType: dynamic
+      element: <null>
+  rightParenthesis: )
+  matchedValueType: dynamic
+''');
+  }
+
   test_typedef_dynamic_hasName_unresolved() async {
     await assertErrorsInCode(r'''
 typedef A = dynamic;

pkg/front_end/lib/src/fasta/type_inference/inference_visitor.dart

@@ -11066,6 +11066,7 @@ class InferenceVisitorImpl extends InferenceVisitorBase
 
   @override
   DartType resolveObjectPatternPropertyGet({
+    required Pattern objectPattern,
     required DartType receiverType,
     required shared.RecordPatternField<TreeNode, Pattern> field,
   }) {

tests/language/patterns/issue52202_test.dart

@@ -0,0 +1,11 @@
+typedef A = int?;
+
+void f(x) {
+  switch (x) {
+    case A(foo: 0):
+//       ^
+// [analyzer] COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
+// [cfe] unspecified
+      break;
+  }
+}