languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:21:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up - unused typedef and lint ignore for html.

Browse source 
Change-Id: I50f89a2d59478c8e2a63a81d106e0943b496ad46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257427
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
This commit is contained in:
Kallen Tu 2022-09-08 20:59:24 +00:00 committed by Commit Bot
parent 2dddeeec99
commit 7e13c388fe
2 changed files with 12 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
sdk/lib/html/dart2js/html_dart2js.dart
View file

@ -37323,10 +37323,6 @@ class _ElementListEventStreamImpl<T extends Event> extends Stream<T>
bool get isBroadcast => true;
}
// We would like this to just be EventListener<T> but that typdef cannot
// use generics until dartbug/26276 is fixed.
typedef _EventListener<T extends Event>(T event);
class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
int _pauseCount = 0;
EventTarget? _target;
@ -37334,19 +37330,13 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
EventListener? _onData;
final bool _useCapture;
// TODO(leafp): It would be better to write this as
// _onData = onData == null ? null :
// onData is void Function(Event)
// ? _wrapZone<Event>(onData)
// : _wrapZone<Event>((e) => onData(e as T))
// In order to support existing tests which pass the wrong type of events but
// use a more general listener, without causing as much slowdown for things
// which are typed correctly. But this currently runs afoul of restrictions
// on is checks for compatibility with the VM.
_EventStreamSubscription(
this._target, this._eventType, void onData(T event)?, this._useCapture)
: _onData = onData == null
? null
// If removed, we would need an `is` check on a function type which
// is ultimately more expensive.
// ignore: avoid_dynamic_calls
: _wrapZone<Event>((e) => (onData as dynamic)(e)) {
_tryResume();
}
@ -37371,6 +37361,9 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
_unlisten();
_onData = handleData == null
? null
// If removed, we would need an `is` check on a function type which is
// ultimately more expensive.
// ignore: avoid_dynamic_calls
: _wrapZone<Event>((e) => (handleData as dynamic)(e));
_tryResume();
}

19
tools/dom/src/EventStreamProvider.dart
View file

@ -219,10 +219,6 @@ class _ElementListEventStreamImpl<T extends Event> extends Stream<T>
bool get isBroadcast => true;
}
// We would like this to just be EventListener<T> but that typdef cannot
// use generics until dartbug/26276 is fixed.
typedef _EventListener<T extends Event>(T event);
class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
int _pauseCount = 0;
EventTarget? _target;
@ -230,19 +226,13 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
EventListener? _onData;
final bool _useCapture;
// TODO(leafp): It would be better to write this as
// _onData = onData == null ? null :
// onData is void Function(Event)
// ? _wrapZone<Event>(onData)
// : _wrapZone<Event>((e) => onData(e as T))
// In order to support existing tests which pass the wrong type of events but
// use a more general listener, without causing as much slowdown for things
// which are typed correctly. But this currently runs afoul of restrictions
// on is checks for compatibility with the VM.
_EventStreamSubscription(
this._target, this._eventType, void onData(T event)?, this._useCapture)
: _onData = onData == null
? null
// If removed, we would need an `is` check on a function type which
// is ultimately more expensive.
// ignore: avoid_dynamic_calls
: _wrapZone<Event>((e) => (onData as dynamic)(e)) {
_tryResume();
}
@ -267,6 +257,9 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
_unlisten();
_onData = handleData == null
? null
// If removed, we would need an `is` check on a function type which is
// ultimately more expensive.
// ignore: avoid_dynamic_calls
: _wrapZone<Event>((e) => (handleData as dynamic)(e));
_tryResume();
}