languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 09:27:03 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Avoid setting node.staticType twice in PostfixExpressionResolver.

Browse source 
Also, add an assertion to `SharedInferenceLogWriter` to prevent
accidentally setting static types more than once in the future.

Change-Id: If96a40c5490d91b67e061158b2b92af90c05d4d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372602
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Paul Berry 2024-06-21 15:44:33 +00:00 committed by Commit Queue
parent 63de2edc74
commit 7d649303c2
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkg/_fe_analyzer_shared/lib/src/type_inference/shared_inference_log.dart
View file

@ -675,7 +675,11 @@ abstract class SharedInferenceLogWriterImpl<Type extends SharedType,
expectedKind: StateKind.expression);
addEvent(
new Event(message: 'EXPRESSION ${describe(expression)} HAS NO TYPE'));
(state as ExpressionState).typeRecorded = true;
ExpressionState state = this.state as ExpressionState;
if (state.typeRecorded) {
fail('A type (or lack thereof) was already recorded for this expression');
}
state.typeRecorded = true;
}
@override
@ -736,7 +740,11 @@ abstract class SharedInferenceLogWriterImpl<Type extends SharedType,
expectedKind: StateKind.expression);
addEvent(
new Event(message: 'STATIC TYPE OF ${describe(expression)} IS $type'));
(state as ExpressionState).typeRecorded = true;
ExpressionState state = this.state as ExpressionState;
if (state.typeRecorded) {
fail('A type (or lack thereof) was already recorded for this expression');
}
state.typeRecorded = true;
}
}

2
pkg/analyzer/lib/src/dart/resolver/postfix_expression_resolver.dart
View file

@ -179,9 +179,9 @@ class PostfixExpressionResolver {
?.write(node, element, operatorReturnType, null);
}
}
node.recordStaticType(receiverType, resolver: _resolver);
}
node.recordStaticType(receiverType, resolver: _resolver);
_resolver.nullShortingTermination(node);
}