languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dart2wasm] Abbreviate high stacks in textual instruction trace.

Browse source 
This avoids a pathological case in some tests.

Change-Id: Ib713ad08eb613a709949bee07fa1e583e15cad9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245163
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
This commit is contained in:
Aske Simon Christensen 2022-05-20 12:15:32 +00:00 committed by Commit Bot
parent b24db9cd46
commit 7b1675f1a5
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
pkg/wasm_builder/lib/src/instructions.dart
View file

@ -114,6 +114,11 @@ class Instructions with SerializerMixin {
/// Column width for the instructions.
int instructionColumnWidth = 50;
/// The maximum number of stack slots for which to print the types after each
/// instruction. When the stack is higher than this, some elements in the
/// middle of the stack are left out.
int maxStackShown = 10;
int _indent = 1;
final List<String> _traceLines = [];
@ -149,7 +154,16 @@ class Instructions with SerializerMixin {
instr = instr.length > instructionColumnWidth - 2
? instr.substring(0, instructionColumnWidth - 4) + "... "
: instr.padRight(instructionColumnWidth);
final String stack = reachableAfter ? _stackTypes.join(', ') : "-";
final int stackHeight = _stackTypes.length;
final String stack = reachableAfter
? stackHeight <= maxStackShown
? _stackTypes.join(', ')
: [
..._stackTypes.sublist(0, maxStackShown ~/ 2),
"... ${stackHeight - maxStackShown} omitted ...",
..._stackTypes.sublist(stackHeight - (maxStackShown + 1) ~/ 2)
].join(', ')
: "-";
final String line = "$byteOffset$instr$stack\n";
_indent += indentAfter;