Move runtime js files down to lib/runtime/dart

Prepare for writing all the runtime in Dart:
- Move js runtime files to lib/runtime/dart (dart_runtime.js ->
dart/_runtime.js),
- Use rest params instead of arguments slicing in a couple of places.

BUG=https://github.com/dart-lang/dev_compiler/issues/310
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1413683006 .

pkg/dev_compiler/lib/runtime/dart/_classes.js

@@ -10,12 +10,12 @@
  */
 
 // TODO(leafp): Consider splitting some of this out.
-dart_library.library('dart_runtime/_classes', null, /* Imports */[
+dart_library.library('dart/_classes', null, /* Imports */[
 ], /* Lazy Imports */[
   'dart/core',
   'dart/_interceptors',
-  'dart_runtime/_types',
-  'dart_runtime/_rtti',
+  'dart/_types',
+  'dart/_rtti',
 ], function(exports, core, _interceptors, types, rtti) {
   'use strict';
 
@@ -30,8 +30,6 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
   const getOwnPropertyDescriptor = Object.getOwnPropertyDescriptor;
   const getOwnPropertySymbols = Object.getOwnPropertySymbols;
 
-  const slice = [].slice;
-
   /** The Symbol for storing type arguments on a specialized generic type. */
   const _mixins = Symbol('mixins');
   const _implements = Symbol('implements');
@@ -48,15 +46,14 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
    * For each mixin, we only take its own properties, not anything from its
    * superclass (prototype).
    */
-  function mixin(base/*, ...mixins*/) {
+  function mixin(base, ...mixins) {
     // Create an initializer for the mixin, so when derived constructor calls
     // super, we can correctly initialize base and mixins.
-    let mixins = slice.call(arguments, 1);
 
     // Create a class that will hold all of the mixin methods.
     class Mixin extends base {
       // Initializer method: run mixin initializers, then the base.
-      [base.name](/*...args*/) {
+      [base.name](...args) {
         // Run mixin initializers. They cannot have arguments.
         // Run them backwards so most-derived mixin is initialized first.
         for (let i = mixins.length - 1; i >= 0; i--) {
@@ -66,7 +63,7 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
         }
         // Run base initializer.
         let init = base.prototype[base.name];
-        if (init) init.apply(this, arguments);
+        if (init) init.apply(this, args);
       }
     }
     // Copy each mixin's methods, with later ones overwriting earlier entries.
@@ -113,11 +110,10 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
       throwInternalError('must have at least one generic type argument');
     }
     let resultMap = new Map();
-    function makeGenericType(/*...arguments*/) {
-      if (arguments.length != length && arguments.length != 0) {
+    function makeGenericType(...args) {
+      if (args.length != length && args.length != 0) {
         throwInternalError('requires ' + length + ' or 0 type arguments');
       }
-      let args = slice.call(arguments);
       while (args.length < length) args.push(types.dynamic);
 
       let value = resultMap;
@@ -366,7 +362,7 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
    */
   // TODO(jmesserly): essentially this gives two names to the same method.
   // This benefit is roughly equivalent call performance either way, but the
-  // cost is we need to call defineExtensionMembers any time a subclass 
+  // cost is we need to call defineExtensionMembers any time a subclass
   // overrides one of these methods.
   function defineExtensionMembers(type, methodNames) {
     let proto = type.prototype;

pkg/dev_compiler/lib/runtime/dart/_errors.js

@@ -7,9 +7,9 @@
  *
  */
 
-dart_library.library('dart_runtime/_errors', null, /* Imports */[
+dart_library.library('dart/_errors', null, /* Imports */[
 ], /* Lazy Imports */[
-  'dart_runtime/_operations',
+  'dart/_operations',
   'dart/core',
   'dart/_js_helper'
 ], function(exports, operations, core, _js_helper) {

pkg/dev_compiler/lib/runtime/dart/_foreign_helper.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_foreign_helper', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/lib/runtime/dart/_generators.js

@@ -14,9 +14,9 @@
  * Inspired by `co`: https://github.com/tj/co/blob/master/index.js, which is a
  * stepping stone for proposed ES7 async/await, and uses ES6 Promises.
  */
-dart_library.library('dart_runtime/_generators', null, /* Imports */[
+dart_library.library('dart/_generators', null, /* Imports */[
 ], /* Lazy Imports */[
-  'dart_runtime/_operations',
+  'dart/_operations',
   'dart/_js_helper',
   'dart/core',
   'dart/collection',

pkg/dev_compiler/lib/runtime/dart/_interceptors.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_interceptors', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/_internal',
   'dart/collection',

pkg/dev_compiler/lib/runtime/dart/_internal.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_internal', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/collection'
 ], /* Lazy imports */[

pkg/dev_compiler/lib/runtime/dart/_isolate_helper.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_isolate_helper', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/_interceptors',
   'dart/_js_helper',

pkg/dev_compiler/lib/runtime/dart/_js_embedded_names.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_js_embedded_names', null, /* Imports */[
-  "dart_runtime/dart"
+  "dart/_runtime"
 ], /* Lazy imports */[
 ], function(exports, dart) {
   'use strict';

pkg/dev_compiler/lib/runtime/dart/_js_helper.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_js_helper', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/collection',
   'dart/_interceptors',

pkg/dev_compiler/lib/runtime/dart/_js_mirrors.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_js_mirrors', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/_internal',
   'dart/core',
   'dart/mirrors'

pkg/dev_compiler/lib/runtime/dart/_js_primitives.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_js_primitives', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/lib/runtime/dart/_native_typed_data.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/_native_typed_data', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/typed_data',
   'dart/_js_helper',

pkg/dev_compiler/lib/runtime/dart/_operations.js

@@ -5,16 +5,16 @@
 /* This library defines runtime operations on objects used by the code
  * generator.
  */
-dart_library.library('dart_runtime/_operations', null, /* Imports */[
+dart_library.library('dart/_operations', null, /* Imports */[
 ], /* Lazy Imports */[
   'dart/async',
   'dart/collection',
   'dart/core',
   'dart/_js_helper',
-  'dart_runtime/_classes',
-  'dart_runtime/_errors',
-  'dart_runtime/_rtti',
-  'dart_runtime/_types'
+  'dart/_classes',
+  'dart/_errors',
+  'dart/_rtti',
+  'dart/_types'
 ], function(exports, async, collection, core, _js_helper, classes, errors, rtti,
             types) {
   'use strict';
@@ -25,8 +25,6 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
   const getOwnPropertyNames = Object.getOwnPropertyNames;
   const hasOwnProperty = Object.prototype.hasOwnProperty;
 
-  const slice = [].slice;
-
   function _canonicalFieldName(obj, name, args, displayName) {
     name = classes.canonicalMember(obj, name);
     if (name) return name;
@@ -143,8 +141,7 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
     throwNoSuchMethod(obj, name, args, f);
   }
 
-  function dcall(f/*, ...args*/) {
-    let args = slice.call(arguments, 1);
+  function dcall(f, ...args) {
     let ftype = rtti.read(f);
     return checkAndCall(f, ftype, void 0, args, 'call');
   }
@@ -158,8 +155,8 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
     return checkAndCall(f, ftype, obj, args, displayName);
   }
 
-  function dsend(obj, method/*, ...args*/) {
-    return callMethod(obj, method, slice.call(arguments, 2), method);
+  function dsend(obj, method, ...args) {
+    return callMethod(obj, method, args, method);
   }
   exports.dsend = dsend;
 
@@ -335,8 +332,7 @@ dart_library.library('dart_runtime/_operations', null, /* Imports */[
    * Will call each successive callback, unless one returns null, which stops
    * the sequence.
    */
-  function nullSafe(obj /*, ...callbacks*/) {
-    let callbacks = slice.call(arguments, 1);
+  function nullSafe(obj, ...callbacks) {
     if (obj == null) return obj;
     for (const callback of callbacks) {
       obj = callback(obj);

pkg/dev_compiler/lib/runtime/dart/_rtti.js

@@ -6,10 +6,10 @@
  * runtime types.
 */
 
-dart_library.library('dart_runtime/_rtti', null, /* Imports */[
+dart_library.library('dart/_rtti', null, /* Imports */[
 ], /* Lazy Imports */[
   'dart/core',
-  'dart_runtime/_types'
+  'dart/_types'
 ], function(exports, core, types) {
   'use strict';
 
@@ -17,8 +17,6 @@ dart_library.library('dart_runtime/_rtti', null, /* Imports */[
 
   const defineProperty = Object.defineProperty;
 
-  const slice = [].slice;
-
   /**
    * Runtime type information.  This module defines the mapping from
    * runtime objects to their runtime type information.  See the types
@@ -63,22 +61,20 @@ dart_library.library('dart_runtime/_rtti', null, /* Imports */[
    * Note that since we are producing a type for a concrete function,
    * it is sound to use the definite arrow type.
    */
-  function fn(closure/* ...args*/) {
+  function fn(closure, ...args) {
     // Closure and a lazy type constructor
-    if (arguments.length == 2) {
-      defineLazyProperty(closure, _runtimeType, {get : arguments[1]});
+    if (args.length == 1) {
+      defineLazyProperty(closure, _runtimeType, {get : args[0]});
       return closure;
     }
     let t;
-    if (arguments.length == 1) {
+    if (args.length == 0) {
       // No type arguments, it's all dynamic
-      let len = closure.length;
-      let args = Array.apply(null, new Array(len)).map(() => types.dynamic);
-      t = types.definiteFunctionType(types.dynamic, args);
+      t = types.definiteFunctionType(
+        types.dynamic, Array(closure.length).fill(types.dynamic));
     } else {
       // We're passed the piecewise components of the function type,
       // construct it.
-      let args = slice.call(arguments, 1);
       t = types.definiteFunctionType.apply(null, args);
     }
     tag(closure, t);
@@ -117,8 +113,7 @@ dart_library.library('dart_runtime/_rtti', null, /* Imports */[
 
   function getFunctionType(obj) {
     // TODO(vsm): Encode this properly on the function for Dart-generated code.
-    let args =
-      Array.apply(null, new Array(obj.length)).map(() => types.dynamic);
+    let args = Array(obj.length).fill(types.dynamic);
     return types.definiteFunctionType(types.bottom, args);
   }
 
@@ -153,7 +148,7 @@ dart_library.library('dart_runtime/_rtti', null, /* Imports */[
   }
   exports.LazyTagged = LazyTagged;
 
-  function read(value) { 
+  function read(value) {
     return value[_runtimeType];
   }
   exports.read = read;

pkg/dev_compiler/lib/runtime/dart/_runtime.js

@@ -2,13 +2,13 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-dart_library.library('dart_runtime/dart', null, /* Imports */[
-  'dart_runtime/_classes',
-  'dart_runtime/_errors',
-  'dart_runtime/_generators',
-  'dart_runtime/_operations',
-  'dart_runtime/_rtti',
-  'dart_runtime/_types',
+dart_library.library('dart/_runtime', null, /* Imports */[
+  'dart/_classes',
+  'dart/_errors',
+  'dart/_generators',
+  'dart/_operations',
+  'dart/_rtti',
+  'dart/_types',
 ], /* Lazy Imports */[
   'dart/_js_helper'
 ], function(exports, classes, errors, generators, operations, rtti, types,

pkg/dev_compiler/lib/runtime/dart/_types.js

@@ -5,11 +5,11 @@
 /* This library defines the representation of runtime types.
 */
 
-dart_library.library('dart_runtime/_types', null, /* Imports */[
+dart_library.library('dart/_types', null, /* Imports */[
 ], /* Lazy Imports */[
   'dart/core',
-  'dart_runtime/_classes',
-  'dart_runtime/_rtti'
+  'dart/_classes',
+  'dart/_rtti'
 ], function(exports, core, classes, rtti) {
   'use strict';
 

pkg/dev_compiler/lib/runtime/dart/async.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/async', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/_internal',
   'dart/collection'

pkg/dev_compiler/lib/runtime/dart/collection.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/collection', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
   'dart/_internal',

pkg/dev_compiler/lib/runtime/dart/convert.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/convert', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/async',
   'dart/typed_data',

pkg/dev_compiler/lib/runtime/dart/core.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/core', null, /* Imports */[
-  "dart_runtime/dart"
+  "dart/_runtime"
 ], /* Lazy imports */[
   'dart/_js_helper',
   'dart/_internal',

pkg/dev_compiler/lib/runtime/dart/isolate.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/isolate', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/async'
 ], /* Lazy imports */[

pkg/dev_compiler/lib/runtime/dart/js.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/js', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/collection',
   'dart/_js_helper'

pkg/dev_compiler/lib/runtime/dart/math.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/math', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
   'dart/_js_helper'

pkg/dev_compiler/lib/runtime/dart/mirrors.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/mirrors', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
   'dart/_js_mirrors'

pkg/dev_compiler/lib/runtime/dart/typed_data.js

@@ -1,5 +1,5 @@
 dart_library.library('dart/typed_data', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
   'dart/_native_typed_data'

pkg/dev_compiler/lib/runtime/dart_utils.js

@@ -19,8 +19,6 @@ var dart_utils =
 
   const hasOwnProperty = Object.prototype.hasOwnProperty;
 
-  const slice = [].slice;
-
   class StrongModeError extends Error {
     constructor(message) {
       super(message);

pkg/dev_compiler/lib/src/codegen/js_codegen.dart

@@ -39,7 +39,7 @@ import 'side_effect_analysis.dart';
 
 // Various dynamic helpers we call.
 // If renaming these, make sure to check other places like the
-// dart_runtime.js file and comments.
+// _runtime.js file and comments.
 // TODO(jmesserly): ideally we'd have a "dynamic call" dart library we can
 // import and generate calls to, rather than dart_runtime.js
 const DPUT = 'dput';
@@ -195,7 +195,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ClosureAnnotator {
       list.add(js.string(compiler.getModuleName(library.source.uri), "'"));
     };
 
-    var imports = <JS.Expression>[js.string('dart_runtime/dart')];
+    var imports = <JS.Expression>[js.string('dart/_runtime')];
     _imports.forEach((library, temp) {
       if (_loader.libraryIsLoaded(library)) {
         processImport(library, temp, imports);

pkg/dev_compiler/lib/src/compiler.dart

@@ -520,13 +520,13 @@ final defaultRuntimeFiles = () {
     'harmony_feature_check.js',
     'dart_utils.js',
     'dart_library.js',
-    '_errors.js',
-    '_generators.js',
-    '_types.js',
-    '_rtti.js',
-    '_classes.js',
-    '_operations.js',
-    'dart_runtime.js',
+    'dart/_errors.js',
+    'dart/_generators.js',
+    'dart/_types.js',
+    'dart/_rtti.js',
+    'dart/_classes.js',
+    'dart/_operations.js',
+    'dart/_runtime.js',
   ];
   files.addAll(corelibOrder.map((l) => l.replaceAll('.', '/') + '.js'));
   return files;

pkg/dev_compiler/lib/src/options.dart

@@ -318,7 +318,7 @@ final ArgParser argParser = new ArgParser()
   ..addFlag('dump-info',
       abbr: 'i', help: 'Dump summary information', defaultsTo: null)
   ..addFlag('html-report',
-      help: 'Output compilation results to html', defaultsTo: null)
+      help: 'Output compilation results to html', defaultsTo: false)
   ..addOption('v8-binary',
       help: 'V8-based binary to run JavaScript output with (iojs, node, d8)',
       defaultsTo: 'iojs')

pkg/dev_compiler/test/browser/runtime_tests.js

@@ -5,14 +5,14 @@
 var assert = chai.assert;
 var core = dart_library.import('dart/core');
 var collection = dart_library.import('dart/collection');
-var dart = dart_library.import('dart_runtime/dart');
+var dart = dart_library.import('dart/_runtime');
 var dartx = dart.dartx;
 
 // TODO(leafp): These are here to test some things not
 // currently exposed through the main dart entry point.
 // If we decide to expose them, this can go away.
-var classes = dart_library.import('dart_runtime/_classes');
-var types = dart_library.import('dart_runtime/_types');
+var classes = dart_library.import('dart/_classes');
+var types = dart_library.import('dart/_types');
 
 suite('generic', () => {
   "use strict";

pkg/dev_compiler/test/codegen/expect/8invalid-chars.in+file_name.js

@@ -1,5 +1,5 @@
 dart_library.library('8invalid-chars.in+file_name', null, /* Imports */[
-  "dart_runtime/dart"
+  "dart/_runtime"
 ], /* Lazy imports */[
 ], function(exports, dart) {
   'use strict';

pkg/dev_compiler/test/codegen/expect/BenchmarkBase.js

@@ -1,5 +1,5 @@
 dart_library.library('BenchmarkBase', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/DeltaBlue.js

@@ -1,5 +1,5 @@
 dart_library.library('DeltaBlue', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'BenchmarkBase',
   'dart/core'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/async_helper.js

@@ -1,5 +1,5 @@
 dart_library.library('async_helper', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/async_helper/async_helper.js

@@ -1,5 +1,5 @@
 dart_library.library('async_helper/async_helper', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/cascade.js

@@ -1,5 +1,5 @@
 dart_library.library('cascade', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/closure.js

@@ -1,5 +1,5 @@
 dart_library.library('closure', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/js'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/collection/algorithms.js

@@ -1,5 +1,5 @@
 dart_library.library('collection/algorithms', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/math'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/collection/iterable_zip.js

@@ -1,5 +1,5 @@
 dart_library.library('collection/iterable_zip', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/collection',
   'dart/core'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/collection/priority_queue.js

@@ -1,5 +1,5 @@
 dart_library.library('collection/priority_queue', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/collection'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/collection/src/canonicalized_map.js

@@ -1,5 +1,5 @@
 dart_library.library('collection/src/canonicalized_map', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'collection/src/utils',
   'dart/collection'

pkg/dev_compiler/test/codegen/expect/collection/src/queue_list.js

@@ -1,5 +1,5 @@
 dart_library.library('collection/src/queue_list', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/collection'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/collection/src/queue_list.txt

@@ -1,5 +1,7 @@
 // Messages from compiling queue_list.dart
+warning: [DownCastComposite] source (Iterable<E>) will need runtime check to cast to type List<dynamic> (package:collection/src/queue_list.dart, line 44, col 25)
 warning: [DownCastComposite] sourceList (List<dynamic>) will need runtime check to cast to type Iterable<E> (package:collection/src/queue_list.dart, line 45, col 40)
+warning: [DownCastComposite] elements (Iterable<E>) will need runtime check to cast to type List<dynamic> (package:collection/src/queue_list.dart, line 61, col 19)
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<E> (package:collection/src/queue_list.dart, line 67, col 52)
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<E> (package:collection/src/queue_list.dart, line 73, col 52)
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<E> (package:collection/src/queue_list.dart, line 77, col 52)

pkg/dev_compiler/test/codegen/expect/collection/src/unmodifiable_wrappers.js

@@ -1,5 +1,5 @@
 dart_library.library('collection/src/unmodifiable_wrappers', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/collection',
   'dart/core'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/collection/src/utils.js

@@ -1,5 +1,5 @@
 dart_library.library('collection/src/utils', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/collection/wrappers.js

@@ -1,5 +1,5 @@
 dart_library.library('collection/wrappers', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'collection/src/canonicalized_map',
   'dart/core',
   'dart/math',

pkg/dev_compiler/test/codegen/expect/collection/wrappers.txt

@@ -1,7 +1,4 @@
 // Messages from compiling wrappers.dart
-warning: [DownCastComposite] _base (Iterable<E>) will need runtime check to cast to type List<E> (package:collection/wrappers.dart, line 120, col 28)
-warning: [DownCastComposite] _base (Iterable<E>) will need runtime check to cast to type Set<E> (package:collection/wrappers.dart, line 219, col 26)
-warning: [DownCastComposite] _base (Iterable<E>) will need runtime check to cast to type Queue<E> (package:collection/wrappers.dart, line 272, col 30)
 warning: [DownCastComposite] _keyForValue(value) (dynamic) will need runtime check to cast to type K (package:collection/wrappers.dart, line 483, col 13)
 warning: [UninferredClosure] () {result = true; return value;} (() → dynamic) will need runtime check to cast to type () → V (package:collection/wrappers.dart, line 485, col 31)
 warning: [DownCastComposite] value (dynamic) will need runtime check to cast to type V (package:collection/wrappers.dart, line 536, col 16)

pkg/dev_compiler/test/codegen/expect/constructors.js

@@ -1,5 +1,5 @@
 dart_library.library('constructors', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/covariance.js

@@ -1,5 +1,5 @@
 dart_library.library('covariance', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/dir/html_input_a.js

@@ -1,5 +1,5 @@
 dart_library.library('dir/html_input_a', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dir/html_input_b',
   'dir/html_input_c',

pkg/dev_compiler/test/codegen/expect/dir/html_input_b.js

@@ -1,5 +1,5 @@
 dart_library.library('dir/html_input_b', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dir/html_input_d'
 ], /* Lazy imports */[
 ], function(exports, dart, html_input_d) {

pkg/dev_compiler/test/codegen/expect/dir/html_input_c.js

@@ -1,5 +1,5 @@
 dart_library.library('dir/html_input_c', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dir/html_input_e'
 ], /* Lazy imports */[
 ], function(exports, dart, html_input_e) {

pkg/dev_compiler/test/codegen/expect/dir/html_input_d.js

@@ -1,5 +1,5 @@
 dart_library.library('dir/html_input_d', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/dir/html_input_e.js

@@ -1,5 +1,5 @@
 dart_library.library('dir/html_input_e', null, /* Imports */[
-  "dart_runtime/dart"
+  "dart/_runtime"
 ], /* Lazy imports */[
 ], function(exports, dart) {
   'use strict';

pkg/dev_compiler/test/codegen/expect/dom/dom.js

@@ -1,5 +1,5 @@
 dart_library.library('dom/dom', window, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/domtest.js

@@ -1,5 +1,5 @@
 dart_library.library('domtest', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'sunflower/dom',
   'dart/core'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/expect.js

@@ -1,5 +1,5 @@
 dart_library.library('expect', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/expect/expect.js

@@ -1,5 +1,5 @@
 dart_library.library('expect/expect', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/fieldtest.js

@@ -1,5 +1,5 @@
 dart_library.library('fieldtest', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/functions.js

@@ -1,5 +1,5 @@
 dart_library.library('functions', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/html_input.html

@@ -2,13 +2,13 @@
 <script src="dev_compiler/runtime/harmony_feature_check.js"></script>
 <script src="dev_compiler/runtime/dart_utils.js"></script>
 <script src="dev_compiler/runtime/dart_library.js"></script>
-<script src="dev_compiler/runtime/_errors.js"></script>
-<script src="dev_compiler/runtime/_generators.js"></script>
-<script src="dev_compiler/runtime/_types.js"></script>
-<script src="dev_compiler/runtime/_rtti.js"></script>
-<script src="dev_compiler/runtime/_classes.js"></script>
-<script src="dev_compiler/runtime/_operations.js"></script>
-<script src="dev_compiler/runtime/dart_runtime.js"></script>
+<script src="dev_compiler/runtime/dart/_errors.js"></script>
+<script src="dev_compiler/runtime/dart/_generators.js"></script>
+<script src="dev_compiler/runtime/dart/_types.js"></script>
+<script src="dev_compiler/runtime/dart/_rtti.js"></script>
+<script src="dev_compiler/runtime/dart/_classes.js"></script>
+<script src="dev_compiler/runtime/dart/_operations.js"></script>
+<script src="dev_compiler/runtime/dart/_runtime.js"></script>
 <script src="dev_compiler/runtime/dart/core.js"></script>
 <script src="dev_compiler/runtime/dart/collection.js"></script>
 <script src="dev_compiler/runtime/dart/_internal.js"></script>

pkg/dev_compiler/test/codegen/expect/map_keys.js

@@ -1,5 +1,5 @@
 dart_library.library('map_keys', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'dart/math'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/methods.js

@@ -1,5 +1,5 @@
 dart_library.library('methods', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/misc.js

@@ -1,5 +1,5 @@
 dart_library.library('misc', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/names.js

@@ -1,5 +1,5 @@
 dart_library.library('names', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/opassign.js

@@ -1,5 +1,5 @@
 dart_library.library('opassign', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/script.js

@@ -1,5 +1,5 @@
 dart_library.library('script', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/sunflower/circle.js

@@ -1,5 +1,5 @@
 dart_library.library('sunflower/circle', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/sunflower/dom.js

@@ -1,5 +1,5 @@
 dart_library.library('sunflower/dom', window, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/sunflower/painter.js

@@ -1,5 +1,5 @@
 dart_library.library('sunflower/painter', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/math',
   'sunflower/dom',
   'dart/core',

pkg/dev_compiler/test/codegen/expect/sunflower/sunflower.html

@@ -26,13 +26,13 @@
     <script src="../dev_compiler/runtime/harmony_feature_check.js"></script>
 <script src="../dev_compiler/runtime/dart_utils.js"></script>
 <script src="../dev_compiler/runtime/dart_library.js"></script>
-<script src="../dev_compiler/runtime/_errors.js"></script>
-<script src="../dev_compiler/runtime/_generators.js"></script>
-<script src="../dev_compiler/runtime/_types.js"></script>
-<script src="../dev_compiler/runtime/_rtti.js"></script>
-<script src="../dev_compiler/runtime/_classes.js"></script>
-<script src="../dev_compiler/runtime/_operations.js"></script>
-<script src="../dev_compiler/runtime/dart_runtime.js"></script>
+<script src="../dev_compiler/runtime/dart/_errors.js"></script>
+<script src="../dev_compiler/runtime/dart/_generators.js"></script>
+<script src="../dev_compiler/runtime/dart/_types.js"></script>
+<script src="../dev_compiler/runtime/dart/_rtti.js"></script>
+<script src="../dev_compiler/runtime/dart/_classes.js"></script>
+<script src="../dev_compiler/runtime/dart/_operations.js"></script>
+<script src="../dev_compiler/runtime/dart/_runtime.js"></script>
 <script src="../dev_compiler/runtime/dart/core.js"></script>
 <script src="../dev_compiler/runtime/dart/collection.js"></script>
 <script src="../dev_compiler/runtime/dart/_internal.js"></script>

pkg/dev_compiler/test/codegen/expect/sunflower/sunflower.js

@@ -1,5 +1,5 @@
 dart_library.library('sunflower/sunflower', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'sunflower/dom',
   'dart/core',
   'dart/math',

pkg/dev_compiler/test/codegen/expect/syncstar_syntax.js

@@ -1,5 +1,5 @@
 dart_library.library('syncstar_syntax', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core',
   'expect/expect'
 ], /* Lazy imports */[

pkg/dev_compiler/test/codegen/expect/temps.js

@@ -1,5 +1,5 @@
 dart_library.library('temps', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/try_catch.js

@@ -1,5 +1,5 @@
 dart_library.library('try_catch', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'dart/core'
 ], /* Lazy imports */[
 ], function(exports, dart, core) {

pkg/dev_compiler/test/codegen/expect/unittest.js

@@ -1,5 +1,5 @@
 dart_library.library('unittest', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'matcher/matcher',
   'dom/dom',
   'dart/core',

pkg/dev_compiler/test/codegen/expect/unittest/unittest.js

@@ -1,5 +1,5 @@
 dart_library.library('unittest/unittest', null, /* Imports */[
-  "dart_runtime/dart",
+  "dart/_runtime",
   'matcher/matcher',
   'dom/dom',
   'dart/core',

pkg/dev_compiler/tool/sdk_expected_errors.txt

@@ -25,7 +25,6 @@ warning: [DownCastComposite] match (List<dynamic>) will need runtime check to ca
 warning: [DownCastComposite] pattern.allMatches(receiver) (dynamic) will need runtime check to cast to type Iterable<Match> (dart:_js_helper/string_helper.dart, line 137, col 23)
 warning: [DownCastComposite] controller (_StreamControllerLifecycle<dynamic>) will need runtime check to cast to type _StreamControllerLifecycle<T> (dart:async/broadcast_stream_controller.dart, line 8, col 67)
 warning: [DownCastComposite] controller (_StreamControllerLifecycle<dynamic>) will need runtime check to cast to type _StreamControllerLifecycle<T> (dart:async/broadcast_stream_controller.dart, line 36, col 15)
-warning: [DownCastComposite] super._controller (_StreamControllerLifecycle<T>) will need runtime check to cast to type _BroadcastStreamController<T> (dart:async/broadcast_stream_controller.dart, line 40, col 52)
 warning: [DownCastComposite] subscription (StreamSubscription<dynamic>) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 196, col 18)
 warning: [DownCastComposite] subscription (StreamSubscription<dynamic>) will need runtime check to cast to type StreamSubscription<T> (dart:async/broadcast_stream_controller.dart, line 201, col 12)
 warning: [DownCastComposite] link (_BroadcastSubscriptionLink) will need runtime check to cast to type _BroadcastSubscription<T> (dart:async/broadcast_stream_controller.dart, line 310, col 48)
@@ -44,7 +43,6 @@ warning: [DownCastComposite] _resultOrListeners (dynamic) will need runtime chec
 warning: [DownCastComposite] value (dynamic) will need runtime check to cast to type T (dart:async/future_impl.dart, line 347, col 17)
 warning: [DownCastComposite] value (dynamic) will need runtime check to cast to type T (dart:async/future_impl.dart, line 357, col 15)
 warning: [DownCastComposite] value (dynamic) will need runtime check to cast to type Future<T> (dart:async/future_impl.dart, line 386, col 31)
-warning: [DownCastComposite] typedFuture (Future<T>) will need runtime check to cast to type _Future<T> (dart:async/future_impl.dart, line 388, col 33)
 warning: [DownCastComposite] value (dynamic) will need runtime check to cast to type T (dart:async/future_impl.dart, line 407, col 22)
 warning: [DownCastComposite] callback (dynamic) will need runtime check to cast to type () → void (dart:async/schedule_microtask.dart, line 66, col 61)
 warning: [DownCastComposite] callback (dynamic) will need runtime check to cast to type () → void (dart:async/schedule_microtask.dart, line 71, col 60)
@@ -140,6 +138,7 @@ warning: [DownCastComposite] _next (_LinkedListLink) will need runtime check to
 warning: [DownCastComposite] current (_LinkedListLink) will need runtime check to cast to type E (dart:collection/linked_list.dart, line 134, col 14)
 warning: [DownCastComposite] _next (_LinkedListLink) will need runtime check to cast to type E (dart:collection/linked_list.dart, line 192, col 16)
 warning: [DownCastComposite] _next (_LinkedListLink) will need runtime check to cast to type E (dart:collection/linked_list.dart, line 249, col 16)
+warning: [DownCastComposite] iterable (Iterable<E>) will need runtime check to cast to type List<dynamic> (dart:collection/list.dart, line 365, col 19)
 warning: [DownCastComposite] otherList[otherStart + i] (dynamic) will need runtime check to cast to type E (dart:collection/list.dart, line 377, col 27)
 warning: [DownCastComposite] otherList[otherStart + i] (dynamic) will need runtime check to cast to type E (dart:collection/list.dart, line 381, col 27)
 warning: [DownCastComposite] _map[_map.keys.first] (dynamic) will need runtime check to cast to type V (dart:collection/maps.dart, line 122, col 18)
@@ -147,9 +146,9 @@ warning: [DownCastComposite] _map[_map.keys.single] (dynamic) will need runtime
 warning: [DownCastComposite] _map[_map.keys.last] (dynamic) will need runtime check to cast to type V (dart:collection/maps.dart, line 124, col 17)
 warning: [DownCastComposite] _map[_keys.current] (dynamic) will need runtime check to cast to type V (dart:collection/maps.dart, line 144, col 18)
 warning: [DownCastComposite] elements (Iterable<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/queue.dart, line 208, col 23)
-warning: [DownCastComposite] list (Queue<E>) will need runtime check to cast to type DoubleLinkedQueue<E> (dart:collection/queue.dart, line 211, col 12)
 warning: [DownCastComposite] sourceList (List<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/queue.dart, line 402, col 40)
 warning: [DownCastComposite] elements (Iterable<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/queue.dart, line 411, col 31)
+warning: [DownCastComposite] elements (Iterable<E>) will need runtime check to cast to type List<dynamic> (dart:collection/queue.dart, line 474, col 19)
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/queue.dart, line 480, col 52)
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/queue.dart, line 486, col 52)
 warning: [DownCastComposite] list (List<dynamic>) will need runtime check to cast to type Iterable<E> (dart:collection/queue.dart, line 490, col 52)
@@ -161,12 +160,15 @@ warning: [DownCastComposite] (compare == null) ? Comparable.compare : compare (F
 warning: [DownCastComposite] k (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 279, col 35)
 warning: [DownCastComposite] v (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 279, col 40)
 warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 332, col 25)
+warning: [DownCastComposite] _root (_SplayTreeNode<K>) will need runtime check to cast to type _SplayTreeMapNode<dynamic, dynamic> (dart:collection/splay_tree.dart, line 334, col 37)
 warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 335, col 16)
 warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 343, col 41)
 warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 344, col 33)
+warning: [DownCastComposite] _root (_SplayTreeNode<K>) will need runtime check to cast to type _SplayTreeMapNode<dynamic, dynamic> (dart:collection/splay_tree.dart, line 354, col 35)
+warning: [DownCastComposite] _root (_SplayTreeNode<K>) will need runtime check to cast to type _SplayTreeMapNode<dynamic, dynamic> (dart:collection/splay_tree.dart, line 366, col 35)
 warning: [DownCastComposite] mapRoot.value (dynamic) will need runtime check to cast to type V (dart:collection/splay_tree.dart, line 367, col 14)
-warning: [DownCastComposite] nodes.current (_SplayTreeNode<K>) will need runtime check to cast to type _SplayTreeMapNode<K, V> (dart:collection/splay_tree.dart, line 398, col 38)
 warning: [DownCastComposite] key (Object) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 412, col 37)
+warning: [DownCastComposite] _root (_SplayTreeNode<K>) will need runtime check to cast to type _SplayTreeMapNode<dynamic, dynamic> (dart:collection/splay_tree.dart, line 429, col 18)
 warning: [DownCastComposite] _first.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 445, col 12)
 warning: [DownCastComposite] _last.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 453, col 12)
 warning: [DownCastComposite] node.key (dynamic) will need runtime check to cast to type K (dart:collection/splay_tree.dart, line 632, col 39)
@@ -198,6 +200,7 @@ warning: [DownCastComposite] sink (Sink<dynamic>) will need runtime check to cas
 warning: [DownCastComposite] (generator != null) ? generator : _id (Function) will need runtime check to cast to type (int) → E (dart:core/iterable.dart, line 319, col 22)
 warning: [DownCastComposite] e (dynamic) will need runtime check to cast to type E (dart:core/list.dart, line 121, col 16)
 warning: [DownCastComposite] makeListFixedLength(list) (List<dynamic>) will need runtime check to cast to type List<E> (dart:core/list.dart, line 124, col 12)
+warning: [DownCastComposite] charCodes (Iterable<int>) will need runtime check to cast to type List<dynamic> (dart:core/string.dart, line 121, col 17)
 warning: [DownCastComposite] _userinfoTable (List<dynamic>) will need runtime check to cast to type List<int> (dart:core/uri.dart, line 1131, col 45)
 warning: [DownCastComposite] _pathCharOrSlashTable (List<dynamic>) will need runtime check to cast to type List<int> (dart:core/uri.dart, line 1144, col 45)
 warning: [DownCastComposite] _pathCharTable (List<dynamic>) will need runtime check to cast to type List<int> (dart:core/uri.dart, line 1146, col 51)