languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 17:56:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that for statements promote properly in unreachable code.

Browse source 
Bug: https://github.com/dart-lang/sdk/issues/40009
Change-Id: I87ea8c8cd943c0c44d795aec084e012b3e2b4496
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166500
Reviewed-by: Johnni Winther <johnniwinther@google.com>
This commit is contained in:
Paul Berry 2020-10-07 20:01:34 +00:00 committed by commit-bot@chromium.org
parent c39b1642b6
commit 7aa9444059
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/_fe_analyzer_shared/lib/src/flow_analysis/flow_analysis.dart
View file

@ -2882,7 +2882,7 @@ class _FlowAnalysisImpl<Node, Statement extends Node, Expression, Variable,
void for_conditionBegin(Node node) {
AssignedVariablesNodeInfo<Variable> info =
_assignedVariables._getInfoForNode(node);
_current = _current.conservativeJoin(info._written, info._captured);
_current = _current.conservativeJoin(info._written, info._captured).split();
}
@override
@ -2893,7 +2893,7 @@ class _FlowAnalysisImpl<Node, Statement extends Node, Expression, Variable,
FlowModel<Variable, Type> breakState = context._breakModel;
FlowModel<Variable, Type> falseCondition = context._conditionInfo.ifFalse;
_current = _join(falseCondition, breakState)
_current = _merge(falseCondition, breakState)
.inheritTested(typeOperations, _current);
}

16
pkg/_fe_analyzer_shared/test/flow_analysis/type_promotion/data/promotion_in_dead_code.dart
View file

@ -53,6 +53,22 @@ doCondition(Object o) {
/*int*/ o;
}
forBreak(Object o) {
return;
for (;;) {
if (o is int) break;
}
/*int*/ o;
}
forContinue(Object o) {
return;
for (;; /*int*/ o) {
if (o is int) continue;
return;
}
}
ifIsNot(Object o) {
return;
if (o is! int) return;