languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-19 20:17:27 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[cfe/ffi] Remove custom FFI checks covered by class modifiers

Browse source 
Tests are in the following files 3.0 and pre-3.0 respectively.
TEST=tests/ffi/vmspecific_static_checks_test.dart
TEST=tests/ffi_2/vmspecific_static_checks_test.dart

Bug: https://github.com/dart-lang/sdk/issues/51683
Change-Id: Ib0b27590748ef788c5475929fde585c790f64e63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291064
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Kallen Tu <kallentu@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
This commit is contained in:
Daco Harkes 2023-03-27 12:15:22 +00:00 committed by Commit Queue
parent f27548aa5a
commit 7a90dd0c4f
3 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/front_end/testcases/class_modifiers/ffi_exception.dart.strong.transformed.expect
View file

@ -1,8 +1,6 @@
//
// Problems outside component:
//
// pkg/front_end/testcases/class_modifiers/ffi_exception.dart: Error: Class 'NativeType' cannot be extended or implemented.
//
// pkg/front_end/testcases/class_modifiers/ffi_exception.dart: Error: Class 'Object' cannot be extended or implemented.
//
library /*isNonNullableByDefault*/;

2
pkg/front_end/testcases/class_modifiers/ffi_exception.dart.weak.transformed.expect
View file

@ -1,8 +1,6 @@
//
// Problems outside component:
//
// pkg/front_end/testcases/class_modifiers/ffi_exception.dart: Error: Class 'NativeType' cannot be extended or implemented.
//
// pkg/front_end/testcases/class_modifiers/ffi_exception.dart: Error: Class 'Object' cannot be extended or implemented.
//
library /*isNonNullableByDefault*/;

6
pkg/vm/lib/transformations/ffi/use_sites.dart
View file

@ -785,12 +785,6 @@ mixin _FfiUseSiteTransformer on FfiTransformer {
}
}
for (final parent in nativeTypesClasses.values) {
if (hierarchy.isSubtypeOf(klass, parent)) {
return parent;
}
}
return null;
}