languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 23:49:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove bogus features from analyzer.

Browse source 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/40860
Change-Id: I9ce962b43cc9d0d865a54d0b31a30245e5f7c001
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153707
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Konstantin Shcheglov 2020-07-09 01:23:23 +00:00 committed by commit-bot@chromium.org
parent 897706edbd
commit 7a87766f23
3 changed files with 1 additions and 124 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/analyzer/CHANGELOG.md
View file

@ -4,6 +4,7 @@
* Added `TypeVisitor` and `DartType.accept(TypeVisitor)`.
* Changed `ConstructorElement.returnType` to `InterfaceType`.
* Added `InterfaceType.asInstanceOf(ClassElement)`.
* Removed deprecated internal `bogus-disabled` and `bogus-enabled`.
## 0.39.12
* Deprecated `canUseSummaries` in `DartSdkManager` constructor.

59
pkg/analyzer/lib/src/dart/analysis/experiments.g.dart
View file

@ -23,11 +23,6 @@ const _knownFeatures = <String, ExperimentalFeature>{
EnableString.spread_collections: ExperimentalFeatures.spread_collections,
EnableString.triple_shift: ExperimentalFeatures.triple_shift,
EnableString.variance: ExperimentalFeatures.variance,
// ignore: deprecated_member_use_from_same_package
EnableString.bogus_disabled: ExperimentalFeatures.bogus_disabled,
// ignore: deprecated_member_use_from_same_package
EnableString.bogus_enabled: ExperimentalFeatures.bogus_enabled,
};
List<bool> _buildExperimentalFlagsArray() => <bool>[
@ -40,8 +35,6 @@ List<bool> _buildExperimentalFlagsArray() => <bool>[
true, // spread-collections
IsEnabledByDefault.triple_shift,
IsEnabledByDefault.variance,
false, // bogus-disabled
true, // bogus-enabled
];
/// Constant strings for enabling each of the currently known experimental
@ -73,14 +66,6 @@ class EnableString {
/// String to enable the experiment "variance"
static const String variance = 'variance';
/// String to enable the experiment "bogus-disabled"
@deprecated
static const String bogus_disabled = 'bogus-disabled';
/// String to enable the experiment "bogus-enabled"
@deprecated
static const String bogus_enabled = 'bogus-enabled';
}
class ExperimentalFeatures {
@ -164,28 +149,6 @@ class ExperimentalFeatures {
documentation: 'Sound variance',
firstSupportedVersion: null,
);
@deprecated
static const bogus_disabled = ExperimentalFeature(
index: 9,
// ignore: deprecated_member_use_from_same_package
enableString: EnableString.bogus_disabled,
isEnabledByDefault: IsEnabledByDefault.bogus_disabled,
isExpired: IsExpired.bogus_disabled,
documentation: null,
firstSupportedVersion: null,
);
@deprecated
static const bogus_enabled = ExperimentalFeature(
index: 10,
// ignore: deprecated_member_use_from_same_package
enableString: EnableString.bogus_enabled,
isEnabledByDefault: IsEnabledByDefault.bogus_enabled,
isExpired: IsExpired.bogus_enabled,
documentation: null,
firstSupportedVersion: '1.0.0',
);
}
/// Constant bools indicating whether each experimental flag is currently
@ -217,14 +180,6 @@ class IsEnabledByDefault {
/// Default state of the experiment "variance"
static const bool variance = false;
/// Default state of the experiment "bogus-disabled"
@deprecated
static const bool bogus_disabled = false;
/// Default state of the experiment "bogus-enabled"
@deprecated
static const bool bogus_enabled = true;
}
/// Constant bools indicating whether each experimental flag is currently
@ -257,23 +212,9 @@ class IsExpired {
/// Expiration status of the experiment "variance"
static const bool variance = false;
/// Expiration status of the experiment "bogus-disabled"
static const bool bogus_disabled = true;
/// Expiration status of the experiment "bogus-enabled"
static const bool bogus_enabled = true;
}
mixin _CurrentState {
/// Current state for the flag "bogus-disabled"
@deprecated
bool get bogus_disabled => isEnabled(ExperimentalFeatures.bogus_disabled);
/// Current state for the flag "bogus-enabled"
@deprecated
bool get bogus_enabled => isEnabled(ExperimentalFeatures.bogus_enabled);
/// Current state for the flag "constant-update-2018"
bool get constant_update_2018 =>
isEnabled(ExperimentalFeatures.constant_update_2018);

65
pkg/analyzer/tool/experiments/generate.dart
View file

@ -107,26 +107,15 @@ List<bool> _buildExperimentalFlagsArray() => <bool>[
out.writeln('IsEnabledByDefault.$id,');
}
}
// TODO(danrubel): Remove bogus entries
out.write('''
false, // bogus-disabled
true, // bogus-enabled
];
''');
}
void generateSection_CurrentState() {
// TODO(danrubel): Remove bogus entries
out.write('''
mixin _CurrentState {
/// Current state for the flag "bogus-disabled"
@deprecated
bool get bogus_disabled => isEnabled(ExperimentalFeatures.bogus_disabled);
/// Current state for the flag "bogus-enabled"
@deprecated
bool get bogus_enabled => isEnabled(ExperimentalFeatures.bogus_enabled);
''');
for (var key in keysSorted) {
var id = keyToIdentifier(key);
@ -164,16 +153,7 @@ class EnableString {
static const String ${keyToIdentifier(key)} = '$key';
''');
}
// TODO(danrubel): Remove bogus entries
out.write('''
/// String to enable the experiment "bogus-disabled"
@deprecated
static const String bogus_disabled = 'bogus-disabled';
/// String to enable the experiment "bogus-enabled"
@deprecated
static const String bogus_enabled = 'bogus-enabled';
}''');
}
@ -205,30 +185,7 @@ class ExperimentalFeatures {
out.writeln(');');
++index;
}
// TODO(danrubel): Remove bogus entries
out.write('''
@deprecated
static const bogus_disabled = ExperimentalFeature(
index: $index,
// ignore: deprecated_member_use_from_same_package
enableString: EnableString.bogus_disabled,
isEnabledByDefault: IsEnabledByDefault.bogus_disabled,
isExpired: IsExpired.bogus_disabled,
documentation: null,
firstSupportedVersion: null,
);
@deprecated
static const bogus_enabled = ExperimentalFeature(
index: ${index + 1},
// ignore: deprecated_member_use_from_same_package
enableString: EnableString.bogus_enabled,
isEnabledByDefault: IsEnabledByDefault.bogus_enabled,
isExpired: IsExpired.bogus_enabled,
documentation: null,
firstSupportedVersion: '1.0.0',
);
}''');
}
@ -247,16 +204,7 @@ class IsEnabledByDefault {
static const bool ${keyToIdentifier(key)} = $shipped;
''');
}
// TODO(danrubel): Remove bogus entries
out.write('''
/// Default state of the experiment "bogus-disabled"
@deprecated
static const bool bogus_disabled = false;
/// Default state of the experiment "bogus-enabled"
@deprecated
static const bool bogus_enabled = true;
}''');
}
@ -280,14 +228,7 @@ class IsExpired {
throw 'Cannot mark shipped feature as "expired: false"';
}
}
// TODO(danrubel): Remove bogus entries
out.write('''
/// Expiration status of the experiment "bogus-disabled"
static const bool bogus_disabled = true;
/// Expiration status of the experiment "bogus-enabled"
static const bool bogus_enabled = true;
}''');
}
@ -303,13 +244,7 @@ const _knownFeatures = <String, ExperimentalFeature>{
EnableString.$id: ExperimentalFeatures.$id,
''');
}
// TODO(danrubel): Remove bogus entries
out.write('''
// ignore: deprecated_member_use_from_same_package
EnableString.bogus_disabled: ExperimentalFeatures.bogus_disabled,
// ignore: deprecated_member_use_from_same_package
EnableString.bogus_enabled: ExperimentalFeatures.bogus_enabled,
};
''');
}