languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 15:09:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ CLI ] Remove --enable-asserts from dart compile exe options

Browse source 
`dart compile exe` creates a product mode binary, which does not support
asserts.

Fixes https://github.com/dart-lang/sdk/issues/50426

TEST=N/A

Change-Id: I46bfabebc1dd08f0a09ba40105cbfe9721ca34fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278141
Reviewed-by: Derek Xu <derekx@google.com>
This commit is contained in:
Ben Konyi 2023-01-03 17:21:41 +00:00
parent e738858aae
commit 778e8d13b2
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/dartdev/lib/src/commands/compile.dart
View file

@ -256,9 +256,13 @@ class CompileNativeCommand extends CompileSubcommandCommand {
help: defineOption.help,
abbr: defineOption.abbr,
valueHelp: defineOption.valueHelp,
)
..addFlag('enable-asserts',
negatable: false, help: 'Enable assert statements.')
);
if (commandName != exeCmdName) {
// dart compile exe creates a product mode binary, which doesn't support asserts.
argParser.addFlag('enable-asserts',
negatable: false, help: 'Enable assert statements.');
}
argParser
..addOption(
packagesOption.flag,
abbr: packagesOption.abbr,
@ -315,7 +319,8 @@ Remove debugging information from the output and save it separately to the speci
outputFile: args['output'],
defines: args['define'],
packages: args['packages'],
enableAsserts: args['enable-asserts'],
enableAsserts:
commandName != exeCmdName ? args['enable-asserts'] : false,
enableExperiment: args.enabledExperiments.join(','),
soundNullSafety: args['sound-null-safety'],
debugFile: args['save-debugging-info'],