languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 14:59:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm] Remove redundant Profiler::DumpStackTrace().

Browse source 
Every FATAL/ASSERT/UNREACHABLE already does this.

Change-Id: Ibc638767e0b58d04f8e453ff7bc1b70858ff4716
Reviewed-on: https://dart-review.googlesource.com/60323
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak 2018-06-14 20:56:44 +00:00 committed by commit-bot@chromium.org
parent 2bc9025be3
commit 7757fa784a
6 changed files with 0 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
runtime/vm/os_thread_android.cc
View file

@ -17,15 +17,12 @@
#include "platform/signal_blocker.h"
#include "platform/utils.h"
#include "vm/profiler.h"
namespace dart {
#define VALIDATE_PTHREAD_RESULT(result) \
if (result != 0) { \
const int kBufferSize = 1024; \
char error_message[kBufferSize]; \
NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
Utils::StrError(result, error_message, kBufferSize); \
FATAL2("pthread error: %d (%s)", result, error_message); \
}
@ -37,7 +34,6 @@ namespace dart {
if (result != 0) { \
const int kBufferSize = 1024; \
char error_message[kBufferSize]; \
NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
Utils::StrError(result, error_message, kBufferSize); \
FATAL3("[%s] pthread error: %d (%s)", name_, result, error_message); \
}

4
runtime/vm/os_thread_linux.cc
View file

@ -19,15 +19,12 @@
#include "platform/signal_blocker.h"
#include "platform/utils.h"
#include "vm/profiler.h"
namespace dart {
#define VALIDATE_PTHREAD_RESULT(result) \
if (result != 0) { \
const int kBufferSize = 1024; \
char error_buf[kBufferSize]; \
NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
FATAL2("pthread error: %d (%s)", result, \
Utils::StrError(result, error_buf, kBufferSize)); \
}
@ -40,7 +37,6 @@ namespace dart {
if (result != 0) { \
const int kBufferSize = 1024; \
char error_buf[kBufferSize]; \
NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
FATAL3("[%s] pthread error: %d (%s)", name_, result, \
Utils::StrError(result, error_buf, kBufferSize)); \
}

4
runtime/vm/os_thread_macos.cc
View file

@ -23,15 +23,12 @@
#include "platform/safe_stack.h"
#include "platform/utils.h"
#include "vm/profiler.h"
namespace dart {
#define VALIDATE_PTHREAD_RESULT(result) \
if (result != 0) { \
const int kBufferSize = 1024; \
char error_message[kBufferSize]; \
NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
Utils::StrError(result, error_message, kBufferSize); \
FATAL2("pthread error: %d (%s)", result, error_message); \
}
@ -43,7 +40,6 @@ namespace dart {
if (result != 0) { \
const int kBufferSize = 1024; \
char error_message[kBufferSize]; \
NOT_IN_PRODUCT(Profiler::DumpStackTrace()); \
Utils::StrError(result, error_message, kBufferSize); \
FATAL3("[%s] pthread error: %d (%s)", name_, result, error_message); \
}

3
runtime/vm/virtual_memory_android.cc
View file

@ -15,7 +15,6 @@
#include "platform/utils.h"
#include "vm/isolate.h"
#include "vm/profiler.h"
namespace dart {
@ -39,7 +38,6 @@ static void unmap(void* address, intptr_t size) {
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("munmap error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
@ -132,7 +130,6 @@ void VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("mprotect error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}

3
runtime/vm/virtual_memory_linux.cc
View file

@ -15,7 +15,6 @@
#include "platform/utils.h"
#include "vm/isolate.h"
#include "vm/profiler.h"
namespace dart {
@ -39,7 +38,6 @@ static void unmap(void* address, intptr_t size) {
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("munmap error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
@ -132,7 +130,6 @@ void VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("mprotect error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}

3
runtime/vm/virtual_memory_macos.cc
View file

@ -15,7 +15,6 @@
#include "platform/utils.h"
#include "vm/isolate.h"
#include "vm/profiler.h"
namespace dart {
@ -39,7 +38,6 @@ static void unmap(void* address, intptr_t size) {
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("munmap error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}
@ -132,7 +130,6 @@ void VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {
int error = errno;
const int kBufferSize = 1024;
char error_buf[kBufferSize];
NOT_IN_PRODUCT(Profiler::DumpStackTrace());
FATAL2("mprotect error: %d (%s)", error,
Utils::StrError(error, error_buf, kBufferSize));
}