languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:27:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add tests for change in https://codereview.chromium.org/2987403002/

Browse source 
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2988403002 .
This commit is contained in:
Johnni Winther 2017-08-03 14:01:07 +02:00
parent 72ba4f6c1c
commit 771415a7c0
2 changed files with 43 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tools/gardening/lib/src/buildbot_structures.dart
View file

@ -138,6 +138,9 @@ class BuildResult {
.where((TestFailure failure) => failure.actual != 'Timeout');
}
/// Returns all [TestFailure]s.
Iterable<TestFailure> get failures => _failures;
String toString() {
StringBuffer sb = new StringBuffer();
sb.write('$buildUri\n');

40
tools/gardening/test/compare_failures_test.dart
View file

@ -23,6 +23,44 @@ main(List<String> args) async {
argParser.addFlag('force', abbr: 'f');
ArgResults argResults = argParser.parse(args);
processArgResults(argResults);
await runSingleTests(argResults);
await runGroupTests(argResults);
}
Future runGroupTests(ArgResults argResults) async {
BuildbotClient client = argResults['logdog']
? new LogdogBuildbotClient()
: new HttpBuildbotClient();
await runGroupTest(client, 'vm-kernel');
client.close();
}
Future runGroupTest(BuildbotClient client, String testGroup) async {
print('Testing group compare-failures: $testGroup runCount=1');
Map<BuildUri, List<BuildResult>> buildResults =
await loadBuildResults(client, [testGroup], runCount: 1);
print('- checking results for ${buildResults.keys}');
buildResults.forEach((BuildUri buildUri, List<BuildResult> results) {
Expect.isTrue(buildUri.buildNumber < 0,
"Expected relative build number for $buildUri");
for (BuildResult result in results) {
Expect.isTrue(
result.buildUri.buildNumber > 0,
"Expected absolute build number for build result "
"${result.buildUri}.");
for (TestFailure failure in result.failures) {
Expect.equals(
result.buildUri.buildNumber,
failure.uri.buildNumber,
"Expected absolute build number for test failure "
"'${failure.id}' from ${failure.uri}.");
}
}
});
}
Future runSingleTests(ArgResults argResults) async {
bool force = argResults['force'];
BuildbotClient client = argResults['logdog']
@ -70,8 +108,10 @@ testSingleResults(
Future runSingleTest(BuildbotClient client, String testUri, int runCount,
Map<int, Map<String, String>> expectedResult) async {
print('Testing single compare-failures: $testUri runCount=$runCount');
Map<BuildUri, List<BuildResult>> buildResults =
await loadBuildResults(client, [testUri], runCount: runCount);
print('- checking results for ${buildResults.keys}');
if (LOG) {
printBuildResultsSummary(buildResults);
}