From 7578614639a907153854cdf3bf7efef1be6d060e Mon Sep 17 00:00:00 2001 From: Kallen Tu Date: Tue, 20 Sep 2022 16:16:06 +0000 Subject: [PATCH] Remove dynamic invocations from custom elements in html_dart2js. Registering custom elements are already broken -- see: https://github.com/dart-lang/sdk/issues/49536. There are plans on deleting this code at some point. This current change cleans up dynamic invocations in the deprecated code. Removes cruft on already-deprecated code and doing it now because I assume dynamic clean up will finish before the issue resolves. Change-Id: Ic6250c139c5d9b08d88650110f55442a7bf5dd42 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259247 Reviewed-by: Sigmund Cherem Reviewed-by: Lasse Nielsen Commit-Queue: Kallen Tu Reviewed-by: Leaf Petersen --- pkg/compiler/test/analyses/api_allowed.json | 5 +---- sdk/lib/html/dart2js/html_dart2js.dart | 7 ++++--- tools/dom/src/dart2js_CustomElementSupport.dart | 7 ++++--- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/pkg/compiler/test/analyses/api_allowed.json b/pkg/compiler/test/analyses/api_allowed.json index 52908c42ef4..71b72de907c 100644 --- a/pkg/compiler/test/analyses/api_allowed.json +++ b/pkg/compiler/test/analyses/api_allowed.json @@ -30,10 +30,7 @@ "Dynamic invocation of 'call'.": 2, "Dynamic access of 'attributes'.": 1, "Dynamic invocation of '[]'.": 1, - "Dynamic invocation of 'toLowerCase'.": 1, - "Dynamic invocation of 'attached'.": 1, - "Dynamic invocation of 'detached'.": 1, - "Dynamic invocation of 'attributeChanged'.": 1 + "Dynamic invocation of 'toLowerCase'.": 1 }, "org-dartlang-sdk:///lib/html/html_common/conversions.dart": { "Dynamic invocation of '[]='.": 1 diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart index cb75d05f3f7..26d027a6229 100644 --- a/sdk/lib/html/dart2js/html_dart2js.dart +++ b/sdk/lib/html/dart2js/html_dart2js.dart @@ -40150,15 +40150,16 @@ _callConstructor(constructor, interceptor) { }; } -_callAttached(receiver) { +_callAttached(Element receiver) { return receiver.attached(); } -_callDetached(receiver) { +_callDetached(Element receiver) { return receiver.detached(); } -_callAttributeChanged(receiver, name, oldValue, newValue) { +_callAttributeChanged( + Element receiver, String name, String oldValue, String newValue) { return receiver.attributeChanged(name, oldValue, newValue); } diff --git a/tools/dom/src/dart2js_CustomElementSupport.dart b/tools/dom/src/dart2js_CustomElementSupport.dart index 8f7a9dd47b1..c4c49bdb391 100644 --- a/tools/dom/src/dart2js_CustomElementSupport.dart +++ b/tools/dom/src/dart2js_CustomElementSupport.dart @@ -16,15 +16,16 @@ _callConstructor(constructor, interceptor) { }; } -_callAttached(receiver) { +_callAttached(Element receiver) { return receiver.attached(); } -_callDetached(receiver) { +_callDetached(Element receiver) { return receiver.detached(); } -_callAttributeChanged(receiver, name, oldValue, newValue) { +_callAttributeChanged( + Element receiver, String name, String oldValue, String newValue) { return receiver.attributeChanged(name, oldValue, newValue); }