languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 14:07:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Macro. Parse merged code only if there are optimization edits.

Browse source 
This saves another 120 ms.

Bug: https://github.com/dart-lang/sdk/issues/55784
Change-Id: I4b195f977b7e49cc5b07dcecd4836b3f25399428
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Konstantin Shcheglov 2024-06-22 16:30:11 +00:00 committed by Commit Queue
parent 1d38fc4bf2
commit 755d4e0531
1 changed files with 20 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
pkg/analyzer/lib/src/summary2/library_builder.dart
View file

@ -533,18 +533,6 @@ class LibraryBuilder with MacroApplicationsContainer {
return;
}
var mergedUnit = performance.run(
'mergedUnit',
(performance) {
performance.getDataInt('length').add(augmentationCode.length);
return kind.file.parseCode(
code: augmentationCode,
errorListener: AnalysisErrorListener.NULL_LISTENER,
performance: performance,
);
},
);
kind.disposeMacroAugmentations(disposeFiles: true);
// Remove import for partial macro augmentations.
@ -636,12 +624,26 @@ class LibraryBuilder with MacroApplicationsContainer {
unitElement: unitElement,
augmentation: augmentation,
).perform(updateConstants: () {
MacroUpdateConstantsForOptimizedCode(
libraryElement: element,
unitNode: mergedUnit,
codeEdits: optimizedCodeEdits,
unitElement: unitElement,
).perform();
if (optimizedCodeEdits.isNotEmpty) {
var mergedUnit = performance.run(
'mergedUnit',
(performance) {
performance.getDataInt('length').add(augmentationCode.length);
return kind.file.parseCode(
code: augmentationCode,
errorListener: AnalysisErrorListener.NULL_LISTENER,
performance: performance,
);
},
);
MacroUpdateConstantsForOptimizedCode(
libraryElement: element,
unitNode: mergedUnit,
codeEdits: optimizedCodeEdits,
unitElement: unitElement,
).perform();
}
});
// Set offsets the same way as when reading from summary.