languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 10:33:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Triage several tests in NonErrorResolverTest_Kernel.

Browse source 
I opened several issues for missing errors and providing actual source
span, not just single offset. We need them anyway, and it is better to
let the FrontEnd know about them sooner, so that they have time to
plan implementing them.

https://github.com/dart-lang/sdk/issues/31626

R=brianwilkerson@google.com

Bug:
Change-Id: I9238a06c8489679fa2a19f853ead2a2b93c39e39
Reviewed-on: https://dart-review.googlesource.com/29042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2017-12-13 15:38:48 +00:00 committed by commit-bot@chromium.org
parent fe7e7df11c
commit 74dcc87393
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/analyzer/test/generated/non_error_resolver_kernel_test.dart
View file

@ -32,7 +32,7 @@ class NonErrorResolverTest_Kernel extends NonErrorResolverTest_Driver {
@override
@failingTest
@potentialAnalyzerProblem
@FastaProblem('https://github.com/dart-lang/sdk/issues/31625')
test_ambiguousImport_showCombinator() async {
return super.test_ambiguousImport_showCombinator();
}
@ -335,14 +335,14 @@ class NonErrorResolverTest_Kernel extends NonErrorResolverTest_Driver {
@override
@failingTest
@potentialAnalyzerProblem
@FastaProblem('https://github.com/dart-lang/sdk/issues/31628')
test_nonConstCaseExpression_constField() async {
return super.test_nonConstCaseExpression_constField();
}
@override
@failingTest
@potentialAnalyzerProblem
@FastaProblem('https://github.com/dart-lang/sdk/issues/31627')
test_nonConstMapKey_constField() async {
return super.test_nonConstMapKey_constField();
}

2
pkg/analyzer/test/src/context/mock_sdk.dart
View file

@ -81,6 +81,8 @@ abstract class Stream<T> {
factory Stream.fromIterable(Iterable<T> data) => null;
}
abstract class StreamIterator<T> {}
abstract class StreamSubscription<T> {
Future cancel();
void onData(void handleData(T data));