languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix handling of default formal parameters in DeclarationResolver.

Browse source 
When visiting a DefaultFormalParameter, we can't call
super.visitDefaultFormalParameter, because that would cause the
default value to be visited twice.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2438113002 .
This commit is contained in:
Paul Berry 2016-10-20 12:34:16 -07:00
parent 78ed4066c8
commit 74d8298777
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analyzer/lib/src/generated/declaration_resolver.dart
View file

@ -126,7 +126,7 @@ class DeclarationResolver extends RecursiveAstVisitor<Object> {
}); });
} }
_walk(new ElementWalker.forParameter(element), () { _walk(new ElementWalker.forParameter(element), () {
super.visitDefaultFormalParameter(node); node.parameter.accept(this);
}); });
_resolveMetadata(node, node.metadata, element); _resolveMetadata(node, node.metadata, element);
return null; return null;

1
pkg/analyzer/test/src/context/context_test.dart
View file

@ -2475,6 +2475,7 @@ void topLevelFunctionWithLocalFunction() {
} }
void functionWithGenericFunctionTypedParam/*<S>*/(/*=T*/ pf/*<T>*/(/*=T*/ e)) {} void functionWithGenericFunctionTypedParam/*<S>*/(/*=T*/ pf/*<T>*/(/*=T*/ e)) {}
void functionWithClosureAsDefaultParam([x = () => null]) {}
'''); ''');
context.resolveCompilationUnit2(source, source); context.resolveCompilationUnit2(source, source);
LibraryElement firstElement = context.computeLibraryElement(source); LibraryElement firstElement = context.computeLibraryElement(source);