languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-05 18:22:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

[tests] Fix language/bool/has_environment_not_new

Browse source 
This test always fails on the VM because unlike other
targets VM allows to invoke this constructor with `new`.

Instead of having an always failing test change this test
to test VM's current behavior. This will also allow us to
catch breaking changes in the future.

Closes https://github.com/dart-lang/sdk/issues/53183

R=eernst@google.com

Change-Id: I4ba63dc94d2bd824df44c604b0ca1c57eb8bd559
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338124
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
This commit is contained in:
Vyacheslav Egorov 2023-11-28 12:50:05 +00:00 committed by Commit Queue
parent d15f56162f
commit 7348441514
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/language/bool/has_environment_not_new_test.dart
View file

@ -4,6 +4,14 @@
import "package:expect/expect.dart";
const bool isVM = const bool.fromEnvironment('dart.isVM');
main() {
Expect.throws(() => new bool.hasEnvironment("Anything"));
// On non-VM targets `new bool.hasEnvironment(...)` just throws, because it
// is only guaranted to work with `const`. However on VM it actually works.
if (!isVM) {
Expect.throws(() => new bool.hasEnvironment("Anything"));
} else {
Expect.isFalse(new bool.hasEnvironment("Anything"));
}
}