From 7344dcc35c66643834e43c49209665a144cd7293 Mon Sep 17 00:00:00 2001 From: "scheglov@google.com" Date: Fri, 15 May 2015 16:22:01 +0000 Subject: [PATCH] [WEB-16445] When create a missing imported library/part, add the edit once. R=brianwilkerson@google.com BUG= https://youtrack.jetbrains.com/issue/WEB-16445 Review URL: https://codereview.chromium.org//1147543002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45813 260f80e4-7a28-3924-810f-c04153c831b5 --- .../lib/src/services/correction/fix_internal.dart | 2 -- pkg/analysis_server/test/services/correction/fix_test.dart | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart index cf8676db313..1b83ef5b643 100644 --- a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart +++ b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart @@ -922,7 +922,6 @@ class FixProcessor { String libName = removeEnd(source.shortName, '.dart'); libName = libName.replaceAll('_', '.'); SourceEdit edit = new SourceEdit(0, 0, 'library $libName;$eol$eol'); - change.addEdit(file, -1, edit); doSourceChange_addSourceEdit(change, context, source, edit); } _addFix(DartFixKind.CREATE_FILE, [file]); @@ -1127,7 +1126,6 @@ class FixProcessor { String file = source.fullName; String libName = unitLibraryElement.name; SourceEdit edit = new SourceEdit(0, 0, 'part of $libName;$eol$eol'); - change.addEdit(file, -1, edit); doSourceChange_addSourceEdit(change, context, source, edit); _addFix(DartFixKind.CREATE_FILE, [file]); } diff --git a/pkg/analysis_server/test/services/correction/fix_test.dart b/pkg/analysis_server/test/services/correction/fix_test.dart index 1b4af7d502d..f09f8c6f742 100644 --- a/pkg/analysis_server/test/services/correction/fix_test.dart +++ b/pkg/analysis_server/test/services/correction/fix_test.dart @@ -1055,6 +1055,7 @@ import 'my_file.dart'; SourceFileEdit fileEdit = change.edits[0]; expect(fileEdit.file, '/my/project/bin/my_file.dart'); expect(fileEdit.fileStamp, -1); + expect(fileEdit.edits, hasLength(1)); expect(fileEdit.edits[0].replacement, contains('library my.file;')); } @@ -1073,6 +1074,7 @@ part 'my_part.dart'; SourceFileEdit fileEdit = change.edits[0]; expect(fileEdit.file, '/my/project/bin/my_part.dart'); expect(fileEdit.fileStamp, -1); + expect(fileEdit.edits, hasLength(1)); expect(fileEdit.edits[0].replacement, contains('part of my.lib;')); }