languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-19 20:17:27 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[ CLI ] Add support for --[no-]sound-null-safety to dart compile {jit-snapshot,kernel}

Browse source 
Fixes https://github.com/dart-lang/sdk/issues/50079

Change-Id: I4a71dab1c9003f13ff74741bc64f3ee239c03195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262620
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Ben Konyi 2022-10-04 17:03:29 +00:00 committed by Commit Queue
parent c8651ac551
commit 72506b826a
2 changed files with 108 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/dartdev/lib/src/commands/compile.dart
View file

@ -127,6 +127,9 @@ class CompileSnapshotCommand extends CompileSubcommandCommand {
abbr: defineOption.abbr,
valueHelp: defineOption.valueHelp,
)
..addFlag('sound-null-safety',
help: 'Respect the nullability of types at runtime.',
defaultsTo: null)
..addExperimentalFlags(verbose: verbose);
}
@ -183,6 +186,11 @@ class CompileSnapshotCommand extends CompileSubcommandCommand {
buildArgs.add('--snapshot-kind=$formatName');
buildArgs.add('--snapshot=${path.canonicalize(outputFile)}');
final bool? soundNullSafety = args['sound-null-safety'];
if (soundNullSafety != null) {
buildArgs.add('--${soundNullSafety ? '' : 'no-'}sound-null-safety');
}
final String? packages = args[packagesOption.flag];
if (packages != null) {
buildArgs.add('--packages=$packages');

100
pkg/dartdev/test/commands/compile_test.dart
View file

@ -962,6 +962,56 @@ void main() {}
reason: 'File not found: $outFile');
});
test('Compile kernel with --sound-null-safety', () async {
final p = project(mainSrc: '''void main() {
print((<int?>[] is List<int>) ? 'oh no' : 'sound');
}''');
final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
final outFile = path.canonicalize(path.join(p.dirPath, 'mydill'));
var result = await p.run(
[
'compile',
'kernel',
'--sound-null-safety',
'-o',
outFile,
inFile,
],
);
expect(result.stderr, isEmpty);
expect(result.stdout, contains(soundNullSafetyMessage));
expect(result.exitCode, 0);
expect(File(outFile).existsSync(), true,
reason: 'File not found: $outFile');
});
test('Compile kernel with --no-sound-null-safety', () async {
final p = project(mainSrc: '''void main() {
print((<int?>[] is List<int>) ? 'unsound' : 'oh no');
}''');
final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
final outFile = path.canonicalize(path.join(p.dirPath, 'mydill'));
var result = await p.run(
[
'compile',
'kernel',
'--no-sound-null-safety',
'-o',
outFile,
inFile,
],
);
expect(result.stderr, isEmpty);
expect(result.stdout, isNot(contains(soundNullSafetyMessage)));
expect(result.exitCode, 0);
expect(File(outFile).existsSync(), true,
reason: 'File not found: $outFile');
});
test('Compile kernel without info', () async {
final p = project(mainSrc: '''void main() {}''');
final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
@ -1085,6 +1135,56 @@ void main() {}
reason: 'File not found: $outFile');
});
test('Compile JIT snapshot with --sound-null-safety', () async {
final p = project(mainSrc: '''void main() {
print((<int?>[] is List<int>) ? 'oh no' : 'sound');
}''');
final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
final outFile = path.canonicalize(path.join(p.dirPath, 'myjit'));
var result = await p.run(
[
'compile',
'jit-snapshot',
'--sound-null-safety',
'-o',
outFile,
inFile,
],
);
expect(result.stderr, isEmpty);
expect(result.stdout, contains(soundNullSafetyMessage));
expect(result.exitCode, 0);
expect(File(outFile).existsSync(), true,
reason: 'File not found: $outFile');
});
test('Compile JIT snapshot with --no-sound-null-safety', () async {
final p = project(mainSrc: '''void main() {
print((<int?>[] is List<int>) ? 'unsound' : 'oh no');
}''');
final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
final outFile = path.canonicalize(path.join(p.dirPath, 'mydill'));
var result = await p.run(
[
'compile',
'jit-snapshot',
'--no-sound-null-safety',
'-o',
outFile,
inFile,
],
);
expect(result.stderr, isEmpty);
expect(result.stdout, isNot(contains(soundNullSafetyMessage)));
expect(result.exitCode, 0);
expect(File(outFile).existsSync(), true,
reason: 'File not found: $outFile');
});
test('Compile JIT snapshot with training args', () async {
final p =
project(mainSrc: '''void main(List<String> args) => print(args);''');