From 708952b3b0f15e5903fc5de193acd3e518bdf7b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Crelier?= Date: Tue, 26 Sep 2017 23:19:15 +0000 Subject: [PATCH] Do not conflate 2 issues into 1 test. Passing the type argument vector in the 'none' configuration is not correct, but this is not what this test is supposed to check. Change-Id: I2afd2987e572a6b4340a7d70ee92878abc67055e Reviewed-on: https://dart-review.googlesource.com/8729 Reviewed-by: Ben Konyi --- .../generic_methods_generic_function_result_test.dart | 2 +- tests/language_2/language_2_dart2js.status | 2 +- tests/language_2/language_2_kernel.status | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/language_2/generic_methods_generic_function_result_test.dart b/tests/language_2/generic_methods_generic_function_result_test.dart index 56e9fa14959..a60140adc4d 100644 --- a/tests/language_2/generic_methods_generic_function_result_test.dart +++ b/tests/language_2/generic_methods_generic_function_result_test.dart @@ -24,5 +24,5 @@ List(); print(list[0].runtimeType); - Expect.equals(123, list[1](100, 23)); + Expect.equals(123, list[1](100, 23)); } diff --git a/tests/language_2/language_2_dart2js.status b/tests/language_2/language_2_dart2js.status index 298c5d5ac15..5b6fc7a1a7d 100644 --- a/tests/language_2/language_2_dart2js.status +++ b/tests/language_2/language_2_dart2js.status @@ -134,7 +134,7 @@ generic_methods_dynamic_test/02: MissingRuntimeError generic_methods_dynamic_test/03: MissingCompileTimeError generic_methods_dynamic_test/04: MissingRuntimeError generic_methods_generic_class_tearoff_test: RuntimeError -generic_methods_generic_function_result_test/none: CompileTimeError # Issue #30208 +generic_methods_generic_function_result_test/01: MissingCompileTimeError # Issue #30208 generic_methods_named_parameters_test: RuntimeError generic_methods_optional_parameters_test: RuntimeError generic_methods_overriding_test/01: MissingCompileTimeError diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status index 4973cd76dc9..35bfda0ca65 100644 --- a/tests/language_2/language_2_kernel.status +++ b/tests/language_2/language_2_kernel.status @@ -11,7 +11,7 @@ constructor_duplicate_final_test/01: MissingCompileTimeError constructor_duplicate_final_test/02: MissingCompileTimeError const_string_test: RuntimeError const_syntax_test/08: MissingCompileTimeError -generic_methods_generic_function_result_test/none: CompileTimeError # Issue #30208 +generic_methods_generic_function_result_test/01: MissingCompileTimeError # Issue #30208 generic_no_such_method_dispatcher_test: CompileTimeError hello_dart_test: Crash # error: expected: cls.is_type_finalized() ct_const2_test: Pass, Crash # Flaky @@ -80,7 +80,6 @@ generic_methods_dynamic_test/02: MissingRuntimeError generic_methods_dynamic_test/03: MissingCompileTimeError generic_methods_dynamic_test/04: MissingRuntimeError generic_methods_generic_class_tearoff_test: RuntimeError -generic_methods_generic_function_result_test/none: RuntimeError generic_methods_named_parameters_test: RuntimeError generic_methods_optional_parameters_test: RuntimeError generic_methods_overriding_test/01: MissingCompileTimeError