languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 16:44:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

[analyzer] Update list of unverified docs

Browse source 
No longer marks a few error codes as unverified if the issue no longer exists or an adjustment of the offset/length was needed.

Change-Id: I78aa557dcffeafb5c3af40b978fa23ba0bc93a0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Kallen Tu <kallentu@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Parker Lougheed 2023-08-10 20:21:08 +00:00 committed by Commit Queue
parent 00b59bd878
commit 6f127b2b47
3 changed files with 6 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/analyzer/messages.yaml
View file

@ -8552,7 +8552,7 @@ CompileTimeErrorCode:
```dart
int f(Null x) {
return [!x!].length;
return x.[!length!];
}
```
@ -14297,7 +14297,7 @@ CompileTimeErrorCode:
```dart
Iterable<int> f() sync* {
[!return 3!];
[!return!] 3;
}
```

16
pkg/analyzer/test/verify_diagnostics_test.dart
View file

@ -34,10 +34,10 @@ class DocumentationValidator {
'CompileTimeErrorCode.AMBIGUOUS_IMPORT',
// Produces two diagnostics when it should only produce one.
'CompileTimeErrorCode.BUILT_IN_IDENTIFIER_AS_TYPE',
// TODO(kallentu) Now reports CONST_EVAL_THROWS_EXCEPTION instead.
'CompileTimeErrorCode.CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH',
// Produces two diagnostics when it should only produce one.
'CompileTimeErrorCode.CONST_DEFERRED_CLASS',
// Produces two diagnostics when it should only produce one.
'CompileTimeErrorCode.CONST_WITH_NON_CONSTANT_ARGUMENT',
// These docs need to be published until there are few enough users that
// are on a pre-3.0 SDK that we're OK with the possibility of them
// encountering a broken link.
@ -57,13 +57,9 @@ class DocumentationValidator {
'CompileTimeErrorCode.IMPORT_INTERNAL_LIBRARY',
// Produces two diagnostics when it should only produce one.
'CompileTimeErrorCode.INVALID_URI',
// Produces two diagnostics when it should only produce one.
'CompileTimeErrorCode.INVALID_USE_OF_NULL_VALUE',
// No example, by design.
'CompileTimeErrorCode.MISSING_DART_LIBRARY',
// Produces two diagnostics when it should only produce one.
'CompileTimeErrorCode.MULTIPLE_SUPER_INITIALIZERS',
// Produces two diagnostics when it should only produce one.
'CompileTimeErrorCode.NON_SYNC_FACTORY',
// Need a way to make auxiliary files that (a) are not included in the
// generated docs or (b) can be made persistent for fixes.
@ -74,8 +70,6 @@ class DocumentationValidator {
'CompileTimeErrorCode.RECURSIVE_CONSTRUCTOR_REDIRECT',
// Produces two diagnostic out of necessity.
'CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE',
// https://github.com/dart-lang/sdk/issues/45960
'CompileTimeErrorCode.RETURN_IN_GENERATOR',
// Produces two diagnostic out of necessity.
'CompileTimeErrorCode.TOP_LEVEL_CYCLE',
// Produces two diagnostic out of necessity.
@ -96,13 +90,7 @@ class DocumentationValidator {
'HintCode.DEPRECATED_COLON_FOR_DEFAULT_VALUE',
// The code has been replaced but is not yet removed.
'HintCode.DEPRECATED_MEMBER_USE',
// Produces two diagnostics when it should only produce one (see
// https://github.com/dart-lang/sdk/issues/43051)
'HintCode.UNNECESSARY_NULL_COMPARISON_FALSE',
// Produces two diagnostics when it should only produce one (see
// https://github.com/dart-lang/sdk/issues/43263)
'StaticWarningCode.DEAD_NULL_AWARE_EXPRESSION',
//
// The following can't currently be verified because the examples aren't
// Dart code.

4
pkg/analyzer/tool/diagnostics/diagnostics.md
View file

@ -10630,7 +10630,7 @@ The following code produces this diagnostic because `x` will always be
{% prettify dart tag=pre+code %}
int f(Null x) {
return [!x!].length;
return x.[!length!];
}
{% endprettify %}
@ -17661,7 +17661,7 @@ generator and is using `return` to return a value:
{% prettify dart tag=pre+code %}
Iterable<int> f() sync* {
[!return 3!];
[!return!] 3;
}
{% endprettify %}