languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-19 23:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Also output --network for testing http server commandline

Browse source 
If for instance running ddc kernel tests via

tools/test.py -mrelease -cdartdevk language_2 -v

one is told that a http server is started with a command line that will
create a http server listening to 0.0.0.0, while generally the one
actually launched by the testing scripts only listen to 127.0.0.1.

This CL adds the extra --network output to the command line given.

Bug:
Change-Id: Ifd9278360efb0b12249fe866c49ed923f7e73b0e
Reviewed-on: https://dart-review.googlesource.com/24102
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
This commit is contained in:
Jens Johansen 2017-11-29 07:30:40 +00:00 committed by commit-bot@chromium.org
parent 69d1301388
commit 6e9c74274c
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tools/testing/dart/http_server.dart
View file

@ -155,6 +155,7 @@ class TestingServers {
}
}
String get network => _serverList[0].address.address;
int get port => _serverList[0].port;
int get crossOriginPort => _serverList[1].port;
DispatchingServer get server => _server;
@ -192,6 +193,8 @@ class TestingServers {
port,
'-c',
crossOriginPort,
'--network',
network,
'--build-directory=$buildDirectory',
'--runtime=${runtime.name}'
];