languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:07:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CFE] Rename 'verifySkipPlatform' to 'skipPlatformVerification'

Browse source 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/180562

Change-Id: I242da8dc94109008d33611067b62f5352d52f454
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180565
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
This commit is contained in:
Jens Johansen 2021-01-25 10:19:52 +00:00 committed by commit-bot@chromium.org
parent 7e5f96bd97
commit 6e191c11e5
7 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/front_end/lib/src/api_prototype/compiler_options.dart
View file

@ -192,7 +192,7 @@ class CompilerOptions {
bool verify = false;
/// Whether to - if verifying - skip the platform.
bool verifySkipPlatform = false;
bool skipPlatformVerification = false;
/// Whether to dump generated components in a text format (also mainly for
/// debugging).
@ -338,7 +338,9 @@ class CompilerOptions {
}
if (!ignoreVerify) {
if (verify != other.verify) return false;
if (verifySkipPlatform != other.verifySkipPlatform) return false;
if (skipPlatformVerification != other.skipPlatformVerification) {
return false;
}
}
if (!ignoreDebugDump) {
if (debugDump != other.debugDump) return false;

2
pkg/front_end/lib/src/base/command_line_options.dart
View file

@ -40,7 +40,7 @@ class Flags {
static const String verbose = "--verbose";
static const String verbosity = "--verbosity";
static const String verify = "--verify";
static const String verifySkipPlatform = "--verify-skip-platform";
static const String skipPlatformVerification = "--skip-platform-verification";
static const String warnOnReachabilityCheck = "--warn-on-reachability-check";
static const String invocationModes = "--invocation-modes";

2
pkg/front_end/lib/src/base/processed_options.dart
View file

@ -167,7 +167,7 @@ class ProcessedOptions {
bool get verify => _raw.verify;
bool get verifySkipPlatform => _raw.verifySkipPlatform;
bool get skipPlatformVerification => _raw.skipPlatformVerification;
bool get debugDump => _raw.debugDump;

4
pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
View file

@ -1334,7 +1334,7 @@ class KernelTarget extends TargetImplementation {
void verify() {
// TODO(ahe): How to handle errors.
verifyComponent(component,
skipPlatform: context.options.verifySkipPlatform);
skipPlatform: context.options.skipPlatformVerification);
ClassHierarchy hierarchy =
new ClassHierarchy(component, new CoreTypes(component),
onAmbiguousSupertypes: (Class cls, Supertype a, Supertype b) {
@ -1342,7 +1342,7 @@ class KernelTarget extends TargetImplementation {
});
verifyGetStaticType(
new TypeEnvironment(loader.coreTypes, hierarchy), component,
skipPlatform: context.options.verifySkipPlatform);
skipPlatform: context.options.skipPlatformVerification);
ticker.logMs("Verified component");
}

2
pkg/front_end/test/fasta/testing/suite.dart
View file

@ -1027,7 +1027,7 @@ CompilationSetup createCompilationSetup(
..allowedExperimentalFlagsForTesting = allowedExperimentalFlags
..experimentEnabledVersionForTesting = experimentEnabledVersion
..experimentReleasedVersionForTesting = experimentReleasedVersion
..verifySkipPlatform = true
..skipPlatformVerification = true
..target = createTarget(folderOptions, context);
if (folderOptions.overwriteCurrentSdkVersion != null) {
compilerOptions.currentSdkVersion =

6
pkg/front_end/tool/_fasta/command_line.dart
View file

@ -197,7 +197,7 @@ const Map<String, ValueSpecification> optionSpecification =
Flags.verbose: const BoolValue(false),
Flags.verbosity: const StringValue(),
Flags.verify: const BoolValue(false),
Flags.verifySkipPlatform: const BoolValue(false),
Flags.skipPlatformVerification: const BoolValue(false),
Flags.warnOnReachabilityCheck: const BoolValue(false),
Flags.linkDependencies: const UriListValue(),
Flags.noDeps: const BoolValue(false),
@ -269,7 +269,7 @@ ProcessedOptions analyzeCommandLine(String programName,
final bool verify = options[Flags.verify];
final bool verifySkipPlatform = options[Flags.verifySkipPlatform];
final bool skipPlatformVerification = options[Flags.skipPlatformVerification];
final bool dumpIr = options[Flags.dumpIr];
@ -355,7 +355,7 @@ ProcessedOptions analyzeCommandLine(String programName,
..omitPlatform = omitPlatform
..verbose = verbose
..verify = verify
..verifySkipPlatform = verifySkipPlatform
..skipPlatformVerification = skipPlatformVerification
..explicitExperimentalFlags = explicitExperimentalFlags
..environmentDefines = noDefines ? null : parsedArguments.defines
..nnbdMode = nnbdMode

2
pkg/test_runner/lib/src/compiler_configuration.dart
View file

@ -1258,7 +1258,7 @@ class FastaCompilerConfiguration extends CompilerConfiguration {
var compilerArguments = [
'--verify',
'--verify-skip-platform',
'--skip-platform-verification',
"-o",
outputFileName,
"--platform",