languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-21 11:27:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't ignore result of EnsureIsFinalized in Precompiler; update helper scripts to use dart_precompiled.

Browse source 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1464933002 .
This commit is contained in:
Ryan Macnak 2015-11-23 09:33:06 -08:00
parent 1e05c35650
commit 6d69da223d
4 changed files with 17 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
runtime/vm/precompiler.cc
View file

@ -124,12 +124,12 @@ void Precompiler::DoCompileAll(
void Precompiler::ClearAllCode() {
class CodeCodeFunctionVisitor : public FunctionVisitor {
class ClearCodeFunctionVisitor : public FunctionVisitor {
void VisitFunction(const Function& function) {
function.ClearCode();
}
};
CodeCodeFunctionVisitor visitor;
ClearCodeFunctionVisitor visitor;
VisitFunctions(&visitor);
}
@ -588,7 +588,11 @@ void Precompiler::AddInstantiatedClass(const Class& cls) {
class_count_++;
cls.set_is_allocated(true);
cls.EnsureIsFinalized(T);
error_ = cls.EnsureIsFinalized(T);
if (!error_.IsNull()) {
Jump(error_);
}
changed_ = true;
if (FLAG_trace_precompiler) {
@ -923,7 +927,10 @@ void Precompiler::FinalizeAllClasses() {
if (cls.IsDynamicClass()) {
continue; // class 'dynamic' is in the read-only VM isolate.
}
cls.EnsureIsFinalized(T);
error_ = cls.EnsureIsFinalized(T);
if (!error_.IsNull()) {
Jump(error_);
}
}
}
I->set_all_classes_finalized(true);

4
tools/precompilation/test_linux.sh
View file

@ -6,8 +6,8 @@
./tools/build.py -mdebug -ax64 runtime
./out/DebugX64/dart_no_snapshot --gen-precompiled-snapshot "$1"
./out/DebugX64/dart_no_snapshot --gen-precompiled-snapshot --package-root=out/DebugX64/packages/ "$1"
gcc -m64 -shared -Wl,-soname,libprecompiled.so -o libprecompiled.so precompiled.S
LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PWD" gdb -ex run --args ./out/DebugX64/dart --run-precompiled-snapshot --observe --profile-vm not_used.dart
LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PWD" gdb -ex run --args ./out/DebugX64/dart_precompiled --run-precompiled-snapshot not_used.dart

4
tools/precompilation/test_linux_simarm.sh
View file

@ -6,8 +6,8 @@
./tools/build.py -mdebug -asimarm runtime
./out/DebugSIMARM/dart_no_snapshot --gen-precompiled-snapshot "$1"
./out/DebugSIMARM/dart_no_snapshot --gen-precompiled-snapshot --package-root=out/DebugX64/packages/ "$1"
gcc -m32 -shared -Wl,-soname,libprecompiled.so -o libprecompiled.so precompiled.S
LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PWD" gdb -ex run --args ./out/DebugSIMARM/dart --run-precompiled-snapshot --observe not_used.dart
LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PWD" gdb -ex run --args ./out/DebugSIMARM/dart_precompiled --run-precompiled-snapshot not_used.dart

4
tools/precompilation/test_macos.sh
View file

@ -6,8 +6,8 @@
./tools/build.py -mdebug -ax64 runtime
./xcodebuild/DebugX64/dart_no_snapshot --gen-precompiled-snapshot "$1"
./xcodebuild/DebugX64/dart_no_snapshot --gen-precompiled-snapshot --package-root=xcodebuild/DebugX64/packages/ "$1"
clang -m64 -dynamiclib -o libprecompiled.dylib precompiled.S
LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PWD" lldb -- ./xcodebuild/DebugX64/dart --run-precompiled-snapshot --observe not_used.dart
LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PWD" lldb -- ./xcodebuild/DebugX64/dart_precompiled --run-precompiled-snapshot not_used.dart