languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:29:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update to latest package:yaml

Browse source 
Closes #38958

Tweak an analyzer test that fails after the update. There is a change in
package:yaml where map keys are now iterated in the order they are
defined in the file rather than an arbitrary order based on hash codes.

It is not clear to me whether this is safe or if it indicates a deeper
bug in the analyzer.

Change-Id: Ie02f1bc4277999f991583f9019e67ef70c33a895
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122029
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Nate Bosch 2019-10-18 20:40:48 +00:00
parent f6eb26dfb6
commit 6c36630958
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
DEPS
View file

@ -148,7 +148,7 @@ vars = {
"web_components_rev": "8f57dac273412a7172c8ade6f361b407e2e4ed02",
"web_socket_channel_tag": "1.0.9",
"WebCore_rev": "fb11e887f77919450e497344da570d780e078bc8",
"yaml_tag": "2.1.15",
"yaml_tag": "2.2.0",
"zlib_rev": "c44fb7248079cc3d5563b14b3f758aee60d6b415",
"crashpad_rev": "bf327d8ceb6a669607b0dbab5a83a275d03f99ed",
"minichromium_rev": "8d641e30a8b12088649606b912c2bc4947419ccc",

2
pkg/analyzer/test/embedder_tests.dart
View file

@ -25,11 +25,11 @@ abstract class EmbedderRelatedTest {
..newFolder('/home/.pub-cache/fox/lib')
..newFile('/home/.pub-cache/fox/lib/_embedder.yaml', r'''
embedded_libs:
"dart:deep": "deep/directory/file.dart"
"dart:core" : "core.dart"
"dart:fox": "slippy.dart"
"dart:bear": "grizzly.dart"
"dart:relative": "../relative.dart"
"dart:deep": "deep/directory/file.dart"
"fart:loudly": "nomatter.dart"
''');
}

4
pkg/analyzer/test/src/lint/config_test.dart
View file

@ -122,9 +122,9 @@ linter:
(RuleConfig rc1, RuleConfig rc2) => rc1.name.compareTo(rc2.name));
expect(ruleConfigs, hasLength(2));
expect(ruleConfigs[0].name, 'camel_case_types');
expect(config.ruleConfigs[0].args['enabled'], isFalse);
expect(ruleConfigs[0].args['enabled'], isTrue);
expect(ruleConfigs[1].name, 'unnecessary_getters');
expect(config.ruleConfigs[1].args['enabled'], isTrue);
expect(ruleConfigs[1].args['enabled'], isFalse);
});
});
});