languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:43:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[web] update transition_event_test.

Browse source 
Similar to the request_animation_test, it's unclear the reasons why this
test is hitting flaky timeouts (rate as high as 70% in DDC!).

This change can hopefully improve handling of
asynchrony in the test and help us investigate further.

Change-Id: I5c6023ccfaa7270b1d1e49d902fe9fa168d0d868
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332169
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
This commit is contained in:
Sigmund Cherem 2023-10-27 02:05:27 +00:00 committed by Commit Queue
parent e0112afc70
commit 6b8224d2e5
2 changed files with 16 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
tests/lib/html/transition_event_test.dart
View file

@ -7,6 +7,7 @@ library transition_event_test;
import 'dart:html';
import 'dart:async';
import 'package:async_helper/async_helper.dart';
import 'package:expect/minitest.dart';
Future testTransitionEnd() async {
@ -33,9 +34,11 @@ Future testTransitionEnd() async {
await done.future;
}
main() async {
expect(CssStyleDeclaration.supportsTransitions, isTrue);
if (CssStyleDeclaration.supportsTransitions) {
await testTransitionEnd();
}
main() {
asyncTest(() async {
expect(CssStyleDeclaration.supportsTransitions, isTrue);
if (CssStyleDeclaration.supportsTransitions) {
await testTransitionEnd();
}
});
}

13
tests/lib_2/html/transition_event_test.dart
View file

@ -9,6 +9,7 @@ library transition_event_test;
import 'dart:html';
import 'dart:async';
import 'package:async_helper/async_helper.dart';
import 'package:expect/minitest.dart';
Future testTransitionEnd() async {
@ -35,9 +36,11 @@ Future testTransitionEnd() async {
await done.future;
}
main() async {
expect(CssStyleDeclaration.supportsTransitions, isTrue);
if (CssStyleDeclaration.supportsTransitions) {
await testTransitionEnd();
}
main() {
asyncTest(() async {
expect(CssStyleDeclaration.supportsTransitions, isTrue);
if (CssStyleDeclaration.supportsTransitions) {
await testTransitionEnd();
}
});
}