Fix fuzzy arrow issues in tests.

Also fixes a variety of miscellaneous accidental strong mode compile time or runtime check violations.

Change-Id: Ia8a41ac291aff3689efae0b11a9c51a2db30ef33
Reviewed-on: https://dart-review.googlesource.com/34924
Reviewed-by: Bob Nystrom <rnystrom@google.com>

tests/corelib_2/corelib_2.status

@@ -25,7 +25,6 @@ iterable_reduce_test/01: CompileTimeError
 map_test: Crash # crash in front_end.
 null_nosuchmethod_test/01: CompileTimeError
 null_nosuchmethod_test/none: CompileTimeError
-splay_tree_from_iterable_test: RuntimeError
 string_from_environment3_test/03: Crash
 symbol_reserved_word_test/04: MissingCompileTimeError
 symbol_reserved_word_test/07: MissingCompileTimeError
@@ -347,7 +346,6 @@ list_replace_range_test: RuntimeError
 list_set_all_test: RuntimeError
 null_nosuchmethod_test/01: CompileTimeError # Issue 31402 (Invocation arguments)
 null_nosuchmethod_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
-splay_tree_from_iterable_test: RuntimeError
 string_case_test/01: RuntimeError
 string_from_environment3_test/03: MissingCompileTimeError
 string_trimlr_test/02: RuntimeError
@@ -379,7 +377,6 @@ list_set_all_test: RuntimeError
 null_nosuchmethod_test/01: CompileTimeError # Issue 31402 (Invocation arguments)
 null_nosuchmethod_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
 regexp/stack-overflow_test: RuntimeError
-splay_tree_from_iterable_test: RuntimeError
 string_case_test/01: RuntimeError
 string_from_environment3_test/03: MissingCompileTimeError
 string_trimlr_test/02: RuntimeError

tests/corelib_2/splay_tree_from_iterable_test.dart

@@ -119,14 +119,14 @@ void genericTypeTest() {
   Expect.isFalse(map is SplayTreeMap<dynamic, int>);
 }
 
-typedef String intToString(int v);
+typedef String objectToString(Object v);
-typedef bool intToBool(int v);
+typedef bool objectToBool(Object v);
 
 // Test in checked mode with explicitly given types.
 void typedTest() {
   // Assign functions to typed function variables.
-  intToString key = (int v) => "$v";
+  objectToString key = (v) => "$v";
-  intToBool value = (int v) => v.isOdd;
+  objectToBool value = (v) => (v as int).isOdd;
   Function id = (int i) => i;
 
   Expect.throws(() {

tests/language_2/dynamic_test.dart

@@ -47,7 +47,7 @@ main() {
   Expect.isTrue(m3 is Iface<String, num>);
   Expect.isTrue(m3 is! Iface<num, String>);
 
-  F1<int> f1 = (String s, int i) => s[i];
+  F1<int> f1 = (dynamic s, int i) => s[i];
   Expect.isTrue(f1 is F1<int>);
 
   HasFieldDynamic has_field = new HasFieldDynamic();

tests/language_2/function_test.dart

@@ -351,6 +351,7 @@ class UseFunctionTypes {
     UntypedFunction2 uf2 = null;
     Foo foo = null;
     Foo<int, String> fooIntString = null;
+    Foo<Object, Object> fooObjectObject = null;
 
     f = uf;
     f = uf2;
@@ -362,9 +363,11 @@ class UseFunctionTypes {
     foo = f;
     fooIntString = f;
 
-    foo = fooIntString;
     fooIntString = foo;
 
+    foo = fooObjectObject;
+    fooObjectObject = foo;
+
     uf = uf2;
     uf2 = uf;
   }

tests/language_2/issue13179_test.dart

@@ -6,7 +6,7 @@ import "package:expect/expect.dart";
 
 int count = 0;
 
-void f([void f([x]) = f]) {
+void f([void f([Null x]) = f]) {
   count++;
   if (f != null) {
     f(null);

tests/language_2/language_2_dartdevc.status

@@ -269,7 +269,6 @@ duplicate_export_negative_test: Fail
 duplicate_implements_test/01: MissingCompileTimeError
 duplicate_implements_test/02: MissingCompileTimeError
 dynamic_prefix_core_test/none: CompileTimeError
-dynamic_test: CompileTimeError
 emit_const_fields_test: CompileTimeError # Issue 31533
 export_ambiguous_main_test: MissingCompileTimeError
 external_test/21: CompileTimeError
@@ -385,7 +384,6 @@ initializing_formal_type_annotation_test/02: MissingCompileTimeError
 instance_call_wrong_argument_count_negative_test: Fail
 instantiate_tearoff_of_call_test: CompileTimeError
 invocation_mirror_test: CompileTimeError # Issue 31402 Error: A value of type 'dart.core::int' can't be assigned to a variable of type 'dart.core::Invocation'.
-issue13179_test: CompileTimeError # Issue 31537
 issue18628_2_test/01: MissingCompileTimeError
 issue31596_test: RuntimeError
 issue_25671a_test/01: CompileTimeError # Warning: The method 'A::noSuchMethod' has fewer positional arguments than those of overridden method 'Object::noSuchMethod'.

tests/language_2/language_2_kernel.status

@@ -459,7 +459,6 @@ initializing_formal_type_annotation_test/01: MissingCompileTimeError
 initializing_formal_type_annotation_test/02: MissingCompileTimeError
 instantiate_tearoff_of_call_test: CompileTimeError
 invocation_mirror_test: CompileTimeError # Issue 31402 (Invocation arguments)
-issue13179_test: CompileTimeError # Issue 31402 (Parameter default value)
 issue18628_2_test/01: MissingCompileTimeError
 issue_1751477_test: CompileTimeError # KernelVM bug: Deferred loading kernel issue 28335.
 issue_25671a_test/01: CompileTimeError # Test assumes Dart 1.0 semantics
@@ -1196,7 +1195,7 @@ duplicate_export_negative_test: Fail # Issue 6134
 duplicate_implements_test/01: MissingCompileTimeError
 duplicate_implements_test/02: MissingCompileTimeError
 dynamic_prefix_core_test/none: CompileTimeError
-dynamic_test: CompileTimeError # Issue 31402 (Variable declaration)
+dynamic_test: RuntimeError # Issue 31402 (Variable declaration)
 emit_const_fields_test: CompileTimeError # Issue 31533
 enum_mirror_test: SkipByDesign
 example_constructor_test: Fail, OK
@@ -1314,7 +1313,6 @@ invocation_mirror2_test: SkipByDesign
 invocation_mirror_invoke_on2_test: SkipByDesign
 invocation_mirror_invoke_on_test: SkipByDesign
 invocation_mirror_test: CompileTimeError # Issue 31402 (Invocation arguments)
-issue13179_test: CompileTimeError # Issue 31402 (Parameter default value)
 issue18628_2_test/01: MissingCompileTimeError
 issue21079_test: SkipByDesign
 issue_1751477_test: CompileTimeError # KernelVM bug: Deferred loading kernel issue 28335.

tests/lib_2/async/slow_consumer2_test.dart

@@ -31,7 +31,8 @@ class SlowConsumer extends StreamConsumer {
   Future addStream(Stream stream) {
     Completer result = new Completer();
     var subscription;
-    subscription = stream.listen((List<int> data) {
+    subscription = stream.listen((Object _data) {
+      List<int> data = _data;
       receivedCount += data.length;
       usedBufferSize += data.length;
       bufferedData.add(data);

tests/lib_2/async/slow_consumer3_test.dart

@@ -31,7 +31,8 @@ class SlowConsumer extends StreamConsumer<List<int>> {
   Future addStream(Stream stream) {
     Completer result = new Completer();
     var subscription;
-    subscription = stream.listen((List<int> data) {
+    subscription = stream.listen((Object _data) {
+      List<int> data = _data;
       receivedCount += data.length;
       usedBufferSize += data.length;
       bufferedData.add(data);

tests/lib_2/async/slow_consumer_test.dart

@@ -29,7 +29,8 @@ class SlowConsumer extends StreamConsumer {
     bool done = false;
     Completer completer = new Completer();
     var subscription;
-    subscription = stream.listen((List<int> data) {
+    subscription = stream.listen((Object _data) {
+      List data = _data;
       current = current.then((count) {
         // Simulated amount of time it takes to handle the data.
         int ms = data.length * 1000 ~/ bytesPerSecond;

tests/lib_2/async/stream_from_iterable_test.dart

@@ -59,7 +59,7 @@ main() {
   });
 
   test("iterable-paused", () {
-    Stream stream = new Stream.fromIterable(iter);
+    var stream = new Stream<int>.fromIterable(iter);
     Events actual = new Events();
     StreamSubscription subscription;
     subscription = stream.listen((int value) {

tests/lib_2/convert/json_toEncodable_reviver_test.dart

@@ -12,7 +12,7 @@ class A {
   A(this.x);
 }
 
-toEncodable(A a) => {"A": a.x};
+toEncodable(Object a) => {"A": (a as A).x};
 reviver(key, value) {
   if (value is Map && value.length == 1 && value["A"] != null) {
     return new A(value["A"]);

tests/lib_2/convert/streamed_conversion_json_utf8_encode_test.dart

@@ -19,7 +19,7 @@ Stream<List<int>> encode(Object o) {
   return controller.stream.transform(jsonUtf8.encoder);
 }
 
-void testUnpaused(List<int> expected, Stream stream) {
+void testUnpaused(List<int> expected, Stream<List<int>> stream) {
   asyncStart();
   stream.toList().then((list) {
     var combined = <int>[];
@@ -29,7 +29,7 @@ void testUnpaused(List<int> expected, Stream stream) {
   });
 }
 
-void testWithPauses(List<int> expected, Stream stream) {
+void testWithPauses(List<int> expected, Stream<List<int>> stream) {
   asyncStart();
   var accumulated = <int>[];
   var sub;

tests/lib_2/convert/streamed_conversion_utf8_encode_test.dart

@@ -25,7 +25,7 @@ Stream<List<int>> encode(String string, int chunkSize) {
   return controller.stream.transform(utf8.encoder);
 }
 
-void testUnpaused(List<int> expected, Stream stream) {
+void testUnpaused(List<int> expected, Stream<List<int>> stream) {
   asyncStart();
   stream.toList().then((list) {
     var combined = [];
@@ -36,7 +36,7 @@ void testUnpaused(List<int> expected, Stream stream) {
   });
 }
 
-void testWithPauses(List<int> expected, Stream stream) {
+void testWithPauses(List<int> expected, Stream<List<int>> stream) {
   asyncStart();
   var combined = <int>[];
   var sub;

tests/lib_2/isolate/browser/typed_data_message_test.dart

@@ -95,7 +95,8 @@ void main([args, port]) {
   test("send objects and receive them back", () {
     ReceivePort response = new ReceivePort();
     Isolate.spawn(pingPong, response.sendPort);
-    response.first.then((SendPort remote) {
+    response.first.then((_remote) {
+      SendPort remote = _remote;
       // Send objects and receive them back.
       for (int i = 0; i < elements.length; i++) {
         var sentObject = elements[i];

tests/lib_2/isolate/count_test.dart

@@ -12,7 +12,8 @@ void countMessages(replyTo) {
   int count = 0;
   var port = new ReceivePort();
   replyTo.send(["init", port.sendPort]);
-  port.listen((int message) {
+  port.listen((_message) {
+    int message = _message;
     if (message == -1) {
       expect(count, 10);
       replyTo.send(["done"]);

tests/lib_2/isolate/handle_error2_test.dart

@@ -33,7 +33,7 @@ isomain1(replyPort) {
 /// Returns a list of `[isolate, commandPort]` in a future.
 Future spawn(entry) {
   ReceivePort reply = new ReceivePort();
-  Future isolate = Isolate.spawn(entry, reply.sendPort, paused: true);
+  var isolate = Isolate.spawn(entry, reply.sendPort, paused: true);
   return isolate.then((Isolate isolate) {
     isolate.setErrorsFatal(false);
     isolate.resume(isolate.pauseCapability);

tests/lib_2/isolate/handle_error3_test.dart

@@ -33,7 +33,7 @@ isomain1(replyPort) {
 /// Returns a list of `[isolate, commandPort]` in a future.
 Future spawn(entry) {
   ReceivePort reply = new ReceivePort();
-  Future isolate = Isolate.spawn(entry, reply.sendPort, paused: true);
+  var isolate = Isolate.spawn(entry, reply.sendPort, paused: true);
   return isolate.then((Isolate isolate) {
     isolate.setErrorsFatal(false);
     isolate.resume(isolate.pauseCapability);

tests/lib_2/isolate/illegal_msg_function_test.dart

@@ -25,7 +25,8 @@ void main() {
   // Ignore returned Future.
   Isolate.spawn(echo, port.sendPort);
 
-  port.first.then((SendPort snd) {
+  port.first.then((_snd) {
+    SendPort snd = _snd;
     int function(x) => x + 2;
     try {
       snd.send(function);

tests/lib_2/isolate/illegal_msg_mirror_test.dart

@@ -31,7 +31,8 @@ void main([args, port]) {
   // Ignore returned Future.
   Isolate.spawn(echo, port.sendPort);
 
-  port.first.then((SendPort snd) {
+  port.first.then((_snd) {
+    SendPort snd = _snd;
     final methodMirror = reflectClass(Class).declarations[#method];
     try {
       snd.send(methodMirror);

tests/lib_2/isolate/isolate_current_test.dart

@@ -59,8 +59,8 @@ void testSpawnReturnVsCurrent(bool asList) {
   };
 
   Isolate.spawn(replyCurrent, [p.sendPort, asList]).then((Isolate isolate) {
-    return response.future.then((Isolate isolate2) {
+    return response.future.then((isolate2) {
-      expectIsolateEquals(isolate, isolate2);
+      expectIsolateEquals(isolate, isolate2 as Isolate);
       asyncEnd();
     });
   });
@@ -98,8 +98,8 @@ void testSpawnReturnVsCurrent2(bool asList) {
   };
 
   Isolate.spawn(expectCurrent, [p.sendPort, asList]).then((Isolate isolate) {
-    return response.future.then((SendPort port) {
+    return response.future.then((port) {
-      port.send(transform(isolate));
+      (port as SendPort).send(transform(isolate));
     });
   });
 }

tests/lib_2/isolate/kill_test.dart

@@ -21,7 +21,8 @@ void main() {
   var completer = new Completer(); // Completed by first reply from isolate.
   RawReceivePort reply = new RawReceivePort(completer.complete);
   Isolate.spawn(isomain1, reply.sendPort).then((Isolate isolate) {
-    completer.future.then((SendPort echoPort) {
+    completer.future.then((_echoPort) {
+      SendPort echoPort = _echoPort;
       List result = [];
       reply.handler = (v) {
         result.add(v);

tests/lib_2/isolate/mandel_isolate_test.dart

@@ -107,8 +107,8 @@ class LineProcessorClient {
   void processLine(int y) {
     ReceivePort reply = new ReceivePort();
     _port.send([y, reply.sendPort]);
-    reply.first.then((List<int> message) {
+    reply.first.then((message) {
-      _state.notifyProcessedLine(this, y, message);
+      _state.notifyProcessedLine(this, y, message as List<int>);
     });
   }
 

tests/lib_2/isolate/message3_test.dart

@@ -256,8 +256,8 @@ void runTests(SendPort ping, Queue checks) {
     x[0] = 22;
     Expect.equals(22, x[0]);
     // Must be extendable.
-    x["gee"] = 499;
+    x[123] = 499;
-    Expect.equals(499, x["gee"]);
+    Expect.equals(499, x[123]);
   });
 
   Map cyclicMap = {};
@@ -457,7 +457,8 @@ void main() {
   Isolate
       .spawn(echoMain, [initialReplyPort.sendPort, testPort.sendPort])
       .then((_) => initialReplyPort.first)
-      .then((SendPort ping) {
+      .then((_ping) {
+        SendPort ping = _ping;
         runTests(ping, checks);
         Expect.isTrue(checks.length > 0);
         completer.future.then((_) => ping.send("halt")).then((_) => asyncEnd());

tests/lib_2/isolate/mint_maker_test.dart

@@ -44,8 +44,8 @@ class MintWrapper {
 
   void createPurse(int balance, handlePurse(PurseWrapper purse)) {
     ReceivePort reply = new ReceivePort();
-    reply.first.then((SendPort purse) {
+    reply.first.then((purse) {
-      handlePurse(new PurseWrapper(purse));
+      handlePurse(new PurseWrapper(purse as SendPort));
     });
     _mint.send([balance, reply.sendPort]);
   }
@@ -103,10 +103,10 @@ class PurseWrapper {
 
   PurseWrapper(this._purse) {}
 
-  void _sendReceive(message, replyHandler(reply)) {
+  void _sendReceive<T>(String message, replyHandler(T reply)) {
     ReceivePort reply = new ReceivePort();
     _purse.send([message, reply.sendPort]);
-    reply.first.then(replyHandler);
+    reply.first.then((a) => replyHandler(a as T));
   }
 
   void queryBalance(handleBalance(int balance)) {
@@ -127,9 +127,9 @@ class PurseWrapper {
 mintMakerWrapper(SendPort replyPort) {
   ReceivePort receiver = new ReceivePort();
   replyPort.send(receiver.sendPort);
-  receiver.listen((SendPort replyTo) {
+  receiver.listen((replyTo) {
     Mint mint = new Mint();
-    replyTo.send(mint.port);
+    (replyTo as SendPort).send(mint.port);
   });
 }
 
@@ -147,8 +147,8 @@ class MintMakerWrapper {
 
   void makeMint(handleMint(MintWrapper mint)) {
     ReceivePort reply = new ReceivePort();
-    reply.first.then((SendPort mint) {
+    reply.first.then((mint) {
-      handleMint(new MintWrapper(mint));
+      handleMint(new MintWrapper(mint as SendPort));
     });
     _port.send(reply.sendPort);
   }

tests/lib_2/isolate/typed_message_test.dart

@@ -16,7 +16,8 @@ void logMessages(SendPort replyTo) {
   print("Starting log server.");
   ReceivePort port = new ReceivePort();
   replyTo.send(port.sendPort);
-  port.first.then((List<int> message) {
+  port.first.then((_message) {
+    List<int> message = _message;
     print("Log $message");
     Expect.equals(5, message.length);
     Expect.equals(0, message[0]);

tests/lib_2/lib_2_dartdevc.status

@@ -9,9 +9,7 @@ html/xhr_test/xhr: RuntimeError # Issue 29922, strong mode cast failure
 [ $compiler == dartdevk ]
 async/future_or_strong_test: RuntimeError
 async/future_value_chain4_test: CompileTimeError
-async/slow_consumer3_test: CompileTimeError
 async/slow_consumer_test: CompileTimeError
-async/stream_from_iterable_test: CompileTimeError
 async/zone_run_unary_test: CompileTimeError # Issue 31537
 collection/list_test: RuntimeError
 convert/chunked_conversion1_test: RuntimeError
@@ -19,7 +17,6 @@ convert/chunked_conversion_utf82_test: RuntimeError
 convert/chunked_conversion_utf86_test: RuntimeError
 convert/chunked_conversion_utf87_test: RuntimeError
 convert/codec1_test: RuntimeError
-convert/json_toEncodable_reviver_test: CompileTimeError
 convert/utf82_test: RuntimeError
 html/debugger_test: CompileTimeError
 html/js_typed_interop_anonymous2_exp_test: Crash

tests/lib_2/lib_2_kernel.status

@@ -41,10 +41,7 @@ async/async_await_sync_completer_test: RuntimeError
 async/future_or_strong_test: RuntimeError
 async/future_value_chain4_test: CompileTimeError # Issue 31616
 async/slow_consumer2_test: CompileTimeError # Issue 31402 (Invocation arguments)
-async/slow_consumer3_test: CompileTimeError # Issue 31402 (Invocation arguments)
-async/slow_consumer_test: CompileTimeError # Issue 31402 (Invocation arguments)
 async/stream_controller_async_test: CompileTimeError # Issue 31402 (Invocation arguments)
-async/stream_from_iterable_test: CompileTimeError # Issue 31402 (Invocation arguments)
 async/stream_join_test: CompileTimeError # Issue 31402 (Invocation arguments)
 async/stream_subscription_as_future_test: CompileTimeError # Issue 31402 (Invocation arguments)
 async/timer_cancel2_test: CompileTimeError # Issue 31402 (Invocation arguments)
@@ -56,63 +53,44 @@ async/zone_run_unary_test: CompileTimeError # Issue 31537
 convert/streamed_conversion_json_utf8_decode_test: Pass, Slow # Infrequent timeouts.
 html/*: SkipByDesign # dart:html not supported on VM.
 isolate/compile_time_error_test/01: MissingCompileTimeError
-isolate/count_test: CompileTimeError # Issue 31402 (Invocation arguments)
 isolate/deferred_in_isolate2_test: Skip # Times out. Deferred loading kernel issue 28335.
 isolate/deferred_in_isolate_test: Skip # Times out. Deferred loading kernel issue 28335.
-isolate/handle_error2_test: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/handle_error3_test: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/illegal_msg_function_test: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/illegal_msg_mirror_test: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/isolate_current_test: CompileTimeError # Issue 31402 (Invocation arguments)
 isolate/issue_21398_parent_isolate1_test: RuntimeError # Issue 31402 (List literal)
 isolate/issue_21398_parent_isolate2_test/01: Skip # Times out. Deferred loading kernel issue 28335.
-isolate/kill_test: CompileTimeError # Issue 31402 (Invocation arguments)
+isolate/message3_test/int32x4: Crash # 31916
-isolate/mandel_isolate_test: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/byteBuffer: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/constInstance: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/constList: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/constList_identical: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/constMap: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/fun: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/int32x4: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
 isolate/message_test: CompileTimeError # Issue 31402 (Invocation arguments)
 isolate/mint_maker_test: CompileTimeError # Issue 31402 (Invocation arguments)
 isolate/ping_pause_test: Pass, Timeout
 isolate/spawn_function_custom_class_test: Pass, Timeout
 isolate/spawn_uri_nested_vm_test: Pass, Timeout
 isolate/static_function_test: Skip # Times out. Issue 31855. CompileTimeError. Issue 31402
-isolate/typed_message_test: CompileTimeError # Issue 31402 (Invocation arguments)
 js/datetime_roundtrip_test: CompileTimeError
 js/null_test: CompileTimeError
 js/prototype_access_test: CompileTimeError
 mirrors/abstract_class_test: RuntimeError
-mirrors/abstract_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/class_declarations_test/01: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/class_declarations_test/01: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/class_declarations_test/none: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/class_declarations_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/class_mirror_location_test: RuntimeError
-mirrors/closures_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/constructor_kinds_test/01: RuntimeError
 mirrors/constructor_kinds_test/none: RuntimeError
 mirrors/constructor_private_name_test: RuntimeError
 mirrors/constructors_test: CompileTimeError # Issue 31402 (Invocation arguments)
-mirrors/dart2js_mirrors_test: CompileTimeError # Issue 31537
+mirrors/dart2js_mirrors_test: Crash # 31916
 mirrors/deferred_mirrors_metadata_test: RuntimeError
 mirrors/deferred_mirrors_metadata_test: CompileTimeError # Deferred loading kernel issue 28335.
 mirrors/deferred_mirrors_metatarget_test: CompileTimeError # Deferred loading kernel issue 28335.
 mirrors/deferred_mirrors_metatarget_test: RuntimeError
-mirrors/deferred_mirrors_test: Crash
+mirrors/deferred_mirrors_test: Crash # 31916
 mirrors/deferred_mirrors_update_test: CompileTimeError # Deferred loading kernel issue 28335.
 mirrors/deferred_mirrors_update_test: RuntimeError
 mirrors/deferred_type_test: CompileTimeError, RuntimeError
 mirrors/empty_test: Crash, RuntimeError
-mirrors/enum_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/enum_test: RuntimeError # Issue 31402 (Invocation arguments)
 mirrors/equality_test: RuntimeError
 mirrors/function_type_mirror_test: RuntimeError
 mirrors/generic_bounded_by_type_parameter_test/02: MissingCompileTimeError
 mirrors/generic_bounded_test/01: MissingCompileTimeError
 mirrors/generic_bounded_test/02: MissingCompileTimeError
-mirrors/generic_class_declaration_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/generic_f_bounded_mixin_application_test: RuntimeError
 mirrors/generic_function_typedef_test: RuntimeError
 mirrors/generic_interface_test/01: MissingCompileTimeError
@@ -128,14 +106,10 @@ mirrors/generics_test/01: MissingCompileTimeError
 mirrors/generics_test/none: RuntimeError
 mirrors/hot_get_field_test: RuntimeError
 mirrors/hot_set_field_test: RuntimeError
-mirrors/inherit_field_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/intercepted_object_test: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/intercepted_class_test: CompileTimeError # Issue 31402 (Invocation arguments)
-mirrors/intercepted_object_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/invoke_private_test: RuntimeError
 mirrors/invoke_private_wrong_library_test: RuntimeError
-mirrors/lazy_static_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/library_declarations_test/none: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/library_declarations_test/01: CompileTimeError # Issue 31402 (Invocation arguments)
-mirrors/library_declarations_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/library_enumeration_deferred_loading_test: CompileTimeError # Deferred loading kernel issue 28335.
 mirrors/library_enumeration_deferred_loading_test: RuntimeError
 mirrors/library_exports_hidden_test: RuntimeError, Crash
@@ -146,11 +120,11 @@ mirrors/library_import_deferred_loading_test: CompileTimeError # Deferred loadin
 mirrors/library_imports_bad_metadata_test/none: Crash
 mirrors/library_imports_deferred_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/library_imports_deferred_test: RuntimeError
-mirrors/library_imports_hidden_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/library_imports_hidden_test: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/library_imports_metadata_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/library_imports_metadata_test: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/library_imports_prefixed_show_hide_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/library_imports_prefixed_show_hide_test: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/library_imports_prefixed_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/library_imports_prefixed_test: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/library_imports_shown_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/library_imports_shown_test: RuntimeError # Issue 31402 (Invocation arguments)
 mirrors/library_metadata_test: RuntimeError
 mirrors/list_constructor_test/01: Crash, RuntimeError
 mirrors/list_constructor_test/none: Crash, RuntimeError
@@ -161,30 +135,28 @@ mirrors/metadata_allowed_values_test/16: Skip # Flaky, crashes.
 mirrors/metadata_constructed_constant_test: Crash, RuntimeError
 mirrors/metadata_scope_test/none: RuntimeError
 mirrors/method_mirror_location_test: RuntimeError
-mirrors/method_mirror_name_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/method_mirror_source_line_ending_test: Crash
 mirrors/method_mirror_source_test: Crash
 mirrors/mirrors_nsm_mismatch_test: CompileTimeError # Issue 31533
 mirrors/mirrors_nsm_test/dart2js: CompileTimeError # Issue 31533
 mirrors/mirrors_nsm_test/none: CompileTimeError # Issue 31533
 mirrors/mirrors_reader_test: Crash
-mirrors/mirrors_test: CompileTimeError # Issue 31537
+mirrors/mirrors_test: Crash
 mirrors/mirrors_used*: SkipByDesign # Invalid tests. MirrorsUsed does not have a specification, and dart:mirrors is not required to hide declarations that are not covered by any MirrorsUsed annotation.
 mirrors/mirrors_used_inheritance_test: RuntimeError
 mirrors/mirrors_used_typedef_declaration_test/01: RuntimeError
 mirrors/mirrors_used_typedef_declaration_test/none: RuntimeError
-mirrors/mixin_application_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/mixin_application_test: RuntimeError # Issue 31402 (Invocation arguments)
 mirrors/mixin_members_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/mixin_simple_test: RuntimeError
 mirrors/mixin_test: RuntimeError
 mirrors/native_class_test: SkipByDesign # Imports dart:html
-mirrors/no_metadata_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/operator_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/other_declarations_location_test: RuntimeError
 mirrors/parameter_annotation_mirror_test: RuntimeError
 mirrors/parameter_metadata_test: RuntimeError
 mirrors/parameter_metadata_test: Crash
-mirrors/parameter_of_mixin_app_constructor_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/parameter_of_mixin_app_constructor_test: RuntimeError # Issue 31402 (Invocation arguments)
 mirrors/parameter_test/01: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/parameter_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/private_class_field_test: RuntimeError
@@ -197,7 +169,6 @@ mirrors/redirecting_factory_test/01: Crash
 mirrors/redirecting_factory_test/02: Crash
 mirrors/redirecting_factory_test/none: Crash
 mirrors/reflect_class_test/none: RuntimeError
-mirrors/reflect_model_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/reflected_type_classes_test/01: RuntimeError
 mirrors/reflected_type_function_type_test: RuntimeError
 mirrors/reflected_type_generics_test/01: RuntimeError
@@ -210,13 +181,10 @@ mirrors/relation_assignable_test: RuntimeError
 mirrors/relation_subclass_test: CompileTimeError # Issue 31533
 mirrors/relation_subtype_test: RuntimeError
 mirrors/repeated_private_anon_mixin_app_test: RuntimeError
-mirrors/return_type_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/static_members_easier_test: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/static_members_easier_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/static_members_test: RuntimeError # Issue 31402 (Invocation arguments)
-mirrors/static_members_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/symbol_validation_test/01: RuntimeError # Issue 31537
-mirrors/static_test: CompileTimeError # Issue 31402 (Invocation arguments)
+mirrors/symbol_validation_test/none: RuntimeError # Issue 31537
-mirrors/symbol_validation_test/01: CompileTimeError # Issue 31537
-mirrors/symbol_validation_test/none: CompileTimeError # Issue 31537
-mirrors/synthetic_accessor_properties_test: CompileTimeError # Issue 31402 (Invocation arguments)
 mirrors/type_variable_is_static_test: RuntimeError
 mirrors/type_variable_owner_test/01: RuntimeError
 mirrors/typearguments_mirror_test: CompileTimeError # Issue 31402 (Invocation arguments)
@@ -255,11 +223,9 @@ mirrors/redirecting_factory_different_type_test/none: Crash
 [ $compiler == dartk && $strong ]
 async/future_test/01: RuntimeError
 async/future_test/none: RuntimeError
-async/slow_consumer2_test: RuntimeError
+async/slow_consumer2_test: RuntimeError # Issue 31402 (Invocation arguments)
-async/slow_consumer_test: RuntimeError
 async/stream_controller_async_test: RuntimeError
 async/stream_distinct_test: RuntimeError
-async/stream_from_iterable_test: RuntimeError
 async/stream_join_test: RuntimeError
 async/stream_subscription_as_future_test: RuntimeError
 async/timer_cancel2_test: RuntimeError
@@ -267,36 +233,18 @@ async/timer_cancel_test: RuntimeError
 async/timer_isActive_test: RuntimeError
 async/timer_repeat_test: RuntimeError
 async/zone_run_unary_test: RuntimeError
-convert/json_toEncodable_reviver_test: CompileTimeError
-isolate/count_test: Timeout
-isolate/illegal_msg_function_test: RuntimeError
-isolate/illegal_msg_mirror_test: RuntimeError
-isolate/isolate_current_test: RuntimeError
 isolate/kill_self_synchronously_test: RuntimeError
-isolate/kill_test: RuntimeError
-isolate/mandel_isolate_test: RuntimeError
-isolate/message3_test/byteBuffer: RuntimeError
-isolate/message3_test/constInstance: RuntimeError
-isolate/message3_test/constList: RuntimeError
-isolate/message3_test/constList_identical: RuntimeError
-isolate/message3_test/constMap: RuntimeError
-isolate/message3_test/fun: RuntimeError
-isolate/message3_test/int32x4: RuntimeError
-isolate/message3_test/none: RuntimeError
 isolate/message_test: RuntimeError
 isolate/mint_maker_test: RuntimeError
 isolate/ping_pause_test: RuntimeError
 isolate/request_reply_test: Pass, Timeout
 isolate/stacktrace_message_test: RuntimeError
-isolate/typed_message_test: RuntimeError
 isolate/unresolved_ports_test: CompileTimeError, Pass, Timeout # Fails to compile on opt counter builder (#31838)
 mirrors/class_mirror_type_variables_test: RuntimeError
-mirrors/closures_test: RuntimeError
 mirrors/constructors_test: RuntimeError
 mirrors/fake_function_with_call_test: RuntimeError
 mirrors/generic_bounded_by_type_parameter_test/none: RuntimeError
 mirrors/generic_bounded_test/none: RuntimeError
-mirrors/generic_class_declaration_test: RuntimeError
 mirrors/generic_f_bounded_test/01: RuntimeError
 mirrors/generic_f_bounded_test/none: RuntimeError
 mirrors/generic_local_function_test: RuntimeError
@@ -313,10 +261,8 @@ mirrors/instance_members_test: RuntimeError
 mirrors/instance_members_unimplemented_interface_test: RuntimeError
 mirrors/instance_members_with_override_test: RuntimeError
 mirrors/instantiate_abstract_class_test: RuntimeError
-mirrors/intercepted_class_test: RuntimeError
 mirrors/invocation_fuzz_test/smi: Crash, Pass # Crashes on opt counter builder (#31838)
 mirrors/invoke_closurization2_test: RuntimeError
-mirrors/library_declarations_test/01: RuntimeError
 mirrors/library_imports_bad_metadata_test/none: RuntimeError
 mirrors/metadata_const_map_test: Crash
 mirrors/mixin_members_test: RuntimeError
@@ -325,7 +271,6 @@ mirrors/operator_test: RuntimeError
 mirrors/parameter_is_const_test/none: RuntimeError
 mirrors/parameter_test/01: RuntimeError
 mirrors/parameter_test/none: RuntimeError
-mirrors/reflect_model_test: RuntimeError
 mirrors/reflected_type_classes_test/01: MissingCompileTimeError
 mirrors/reflected_type_classes_test/02: MissingCompileTimeError
 mirrors/reflected_type_classes_test/03: MissingCompileTimeError
@@ -333,7 +278,6 @@ mirrors/reflected_type_test/01: MissingCompileTimeError
 mirrors/reflected_type_test/02: MissingCompileTimeError
 mirrors/reflected_type_test/03: MissingCompileTimeError
 mirrors/regress_16321_test/none: Crash
-mirrors/return_type_test: RuntimeError
 mirrors/top_level_accessors_test/01: MissingCompileTimeError
 mirrors/type_argument_is_type_variable_test: RuntimeError
 mirrors/typearguments_mirror_test: RuntimeError
@@ -386,9 +330,7 @@ async/future_or_strong_test: RuntimeError
 async/future_test/01: RuntimeError
 async/future_test/none: RuntimeError
 async/future_value_chain4_test: CompileTimeError # Issue 31616
-async/slow_consumer2_test: CompileTimeError # Issue 31402 (Invocation arguments)
+async/slow_consumer2_test: RuntimeError # Issue 31402 (Invocation arguments)
-async/slow_consumer3_test: CompileTimeError # Issue 31402 (Invocation arguments)
-async/slow_consumer_test: CompileTimeError # Issue 31402 (Invocation arguments)
 async/stream_controller_async_test: RuntimeError
 async/stream_distinct_test: RuntimeError
 async/stream_from_iterable_test: CompileTimeError # Issue 31402 (Invocation arguments)
@@ -400,32 +342,19 @@ async/timer_isActive_test: RuntimeError
 async/timer_not_available_test: RuntimeError
 async/timer_repeat_test: RuntimeError
 async/zone_run_unary_test: CompileTimeError # Issue 31537
-convert/json_toEncodable_reviver_test: CompileTimeError
 html/*: SkipByDesign # dart:html not supported on VM.
 isolate/compile_time_error_test/01: Crash
 isolate/compile_time_error_test/01: MissingCompileTimeError
 isolate/deferred_in_isolate2_test: Skip # Times out. Deferred loading kernel issue 28335.
 isolate/deferred_in_isolate_test: Skip # Times out. Deferred loading kernel issue 28335.
-isolate/handle_error2_test: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/handle_error3_test: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/isolate_current_test: CompileTimeError # Issue 31402 (Invocation arguments)
 isolate/issue_21398_parent_isolate2_test/01: Skip # Times out. Deferred loading kernel issue 28335.
 isolate/issue_22778_test: Crash
 isolate/kill_self_synchronously_test: RuntimeError
-isolate/kill_test: CompileTimeError # Issue 31402 (Invocation arguments)
+isolate/message3_test/int32x4: Crash # 31916
-isolate/message3_test/byteBuffer: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/constInstance: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/constList: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/constList_identical: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/constMap: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/fun: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/int32x4: CompileTimeError # Issue 31402 (Invocation arguments)
-isolate/message3_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
 isolate/ping_pause_test: Crash
 isolate/ping_pause_test: Pass, Timeout
 isolate/spawn_function_custom_class_test: Pass, Timeout
 isolate/spawn_uri_nested_vm_test: Pass, Timeout
-isolate/typed_message_test: CompileTimeError # Issue 31402 (Invocation arguments)
 js/datetime_roundtrip_test: CompileTimeError
 js/null_test: CompileTimeError
 js/prototype_access_test: CompileTimeError

tests/lib_2/mirrors/mirrors_test.dart

@@ -194,7 +194,7 @@ testNames(mirrors) {
       equals(const Symbol('MirrorsTest.Class.field')));
 }
 
-testLibraryUri(var value, bool check(Uri)) {
+testLibraryUri(var value, bool check(Uri uri)) {
   var valueMirror = reflect(value);
   ClassMirror valueClass = valueMirror.type;
   LibraryMirror valueLibrary = valueClass.owner;

tests/lib_2/mirrors/stringify.dart

@@ -16,7 +16,8 @@ name(DeclarationMirror mirror) {
 stringifyMap(Map map) {
   var buffer = new StringBuffer();
   bool first = true;
-  for (String key in map.keys.map(MirrorSystem.getName).toList()..sort()) {
+  var names = map.keys.map((s) => MirrorSystem.getName(s)).toList()..sort();
+  for (String key in names) {
     if (!first) buffer.write(', ');
     first = false;
     buffer.write(key);

tests/lib_2/mirrors/symbol_validation_test.dart

@@ -61,7 +61,7 @@ main() {
       .expand((op) => [".$op", "$op.x", "x$op", "_x.$op"])
       .forEach(invalidSymbol);
   operators
-      .expand((op) => operators.contains("$op=") ? [] : ["x.$op=", "$op="])
+      .expand<String>((op) => operators.contains("$op=") ? [] : ["x.$op=", "$op="])
       .forEach(invalidSymbol);
 
   var simpleSymbols = [

tests/standalone_2/io/http_proxy_advanced_test.dart

@@ -150,7 +150,7 @@ class ProxyServer {
   }
 
   Future<ProxyServer> start() {
-    var x = new Completer();
+    var x = new Completer<ProxyServer>();
     var host = ipV6 ? "::1" : "localhost";
     HttpServer.bind(host, 0).then((s) {
       server = s;
@@ -257,8 +257,8 @@ class ProxyServer {
                 .add(HttpHeaders.VIA, "${viaPrefix}1.1 localhost:$port");
             // Copy all content.
             return request.pipe(clientRequest);
-          }).then((HttpClientResponse clientResponse) {
+          }).then((clientResponse) {
-            clientResponse.pipe(request.response);
+            (clientResponse as HttpClientResponse).pipe(request.response);
           });
         }
       });

tests/standalone_2/io/http_proxy_test.dart

@@ -139,7 +139,7 @@ class ProxyServer {
   }
 
   Future<ProxyServer> start() {
-    var x = new Completer();
+    var x = new Completer<ProxyServer>();
     var host = ipV6 ? "::1" : "localhost";
     HttpServer.bind(host, 0).then((s) {
       server = s;
@@ -245,8 +245,8 @@ class ProxyServer {
                 .add(HttpHeaders.VIA, "${viaPrefix}1.1 localhost:$port");
             // Copy all content.
             return request.pipe(clientRequest);
-          }).then((HttpClientResponse clientResponse) {
+          }).then((clientResponse) {
-            clientResponse.pipe(request.response);
+            (clientResponse as HttpClientResponse).pipe(request.response);
           });
         }
       });

tests/standalone_2/standalone_2.status

@@ -99,7 +99,6 @@ io/http_auth_test: RuntimeError
 io/http_cookie_date_test: CompileTimeError
 io/http_headers_test: CompileTimeError
 io/http_parser_test: CompileTimeError
-io/http_proxy_advanced_test: CompileTimeError
 io/http_redirect_test: RuntimeError
 io/http_reuse_server_port_test: RuntimeError
 io/http_server_response_test: RuntimeError

tests/standalone_2/standalone_2_kernel.status

@@ -24,7 +24,6 @@ io/socket_port_test: Pass, Crash
 io/compile_all_test: Crash
 io/http_client_request_test: Pass, Timeout
 io/http_compression_test: RuntimeError
-io/http_proxy_test: CompileTimeError
 io/secure_builtin_roots_test: Timeout
 io/socket_finalizer_test: Pass, Timeout
 no_support_debugger_test: Skip # kernel-service snapshot not compatible with flag disabled