languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

don't lint unnecessary lib names pre unnamedLibraries

Browse source 
Related to: https://github.com/dart-lang/lints/issues/181

Change-Id: I4a247fa93c6659d5082d2cb6047aedc6a13a4209
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This commit is contained in:
pq 2024-03-25 18:48:16 +00:00 committed by Commit Queue
parent 19decc4270
commit 6a9c709afd
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/linter/lib/src/rules/unnecessary_library_name.dart
View file

@ -2,6 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analyzer/dart/analysis/features.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/visitor.dart';
@ -65,6 +66,11 @@ class UnnecessaryLibraryName extends LintRule {
@override
void registerNodeProcessors(
NodeLintRegistry registry, LinterContext context) {
if (!context.currentUnit.unit.featureSet
.isEnabled(Feature.unnamedLibraries)) {
return;
}
var visitor = _Visitor(this);
registry.addLibraryDirective(this, visitor);
}

7
pkg/linter/test/rules/unnecessary_library_name_test.dart
View file

@ -25,6 +25,13 @@ library name;
]);
}
test_namedLibrary_preUnnamedLibraries() async {
await assertNoDiagnostics(r'''
// @dart = 2.14
library name;
''');
}
test_unnamedLibrary() async {
await assertNoDiagnostics(r'''
library;