[pkg] remove duplicate config from the analysis options files

Change-Id: I149a97bbe260600a3de664b28c4d212dd9adb889
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335862
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>

pkg/_js_interop_checks/analysis_options.yaml

@@ -2,6 +2,5 @@ include: package:lints/recommended.yaml
 
 linter:
   rules:
-    depend_on_referenced_packages: true
-    directives_ordering: true
-    sort_pub_dependencies: true
+    - directives_ordering
+    - sort_pub_dependencies

pkg/analysis_server/analysis_options.yaml

@@ -29,10 +29,6 @@ analyzer:
 
 linter:
   rules:
-    - collection_methods_unrelated_type
-    - dangling_library_doc_comments
-    - depend_on_referenced_packages
-    - implicit_call_tearoffs
     - library_annotations
     - prefer_single_quotes
     - unawaited_futures
@@ -40,4 +36,3 @@ linter:
     - unnecessary_library_directive
     - unnecessary_parenthesis
     - unreachable_from_main
-    - use_super_parameters

pkg/analysis_server_client/analysis_options.yaml

@@ -1,13 +1,13 @@
 include: package:lints/recommended.yaml
 
+analyzer:
+  errors:
+    constant_identifier_names: ignore
+    non_constant_identifier_names: ignore
+
 linter:
   rules:
-    # In addition to lints/recommended:
-    always_declare_return_types: true
-    omit_local_variable_types: true
-    prefer_single_quotes: true
-    unawaited_futures: true
-
-    # Remove from lints/recommended:
-    constant_identifier_names: false
-    non_constant_identifier_names: false
+    - always_declare_return_types
+    - omit_local_variable_types
+    - prefer_single_quotes
+    - unawaited_futures

pkg/analyzer/analysis_options.yaml

@@ -40,12 +40,8 @@ linter:
     - always_use_package_imports
     - avoid_dynamic_calls
     - avoid_unused_constructor_parameters
-    - collection_methods_unrelated_type
-    - dangling_library_doc_comments
     - enable_null_safety
-    - implicit_call_tearoffs
     - library_annotations
     - unawaited_futures
     - unnecessary_library_directive
     - unnecessary_parenthesis
-    - use_super_parameters

pkg/analyzer_cli/analysis_options.yaml

@@ -4,44 +4,24 @@ analyzer:
   language:
     strict-casts: true
     strict-inference: true
+  errors:
+    # We import heavily from package:analyzer/src.
+    implementation_imports: ignore
+    non_constant_identifier_names: ignore
   exclude:
     - test/data/**
 
 linter:
   rules:
-    always_declare_return_types: true
-    avoid_empty_else: true
-    avoid_relative_lib_imports: true
-    avoid_shadowing_type_parameters: true
-    avoid_types_as_parameter_names: true
-    avoid_unused_constructor_parameters: true
-    camel_case_extensions: true
-    collection_methods_unrelated_type: true
-    curly_braces_in_flow_control_structures: true
-
-    # Enable when we require Dart 2.19.0.
-    #- dangling_library_doc_comments
-    depend_on_referenced_packages: true
-    directives_ordering: true
-    empty_catches: true
-    enable_null_safety: true
-    flutter_style_todos: true
-
-    # We import heavily from package:analyzer/src.
-    implementation_imports: false
-    implicit_call_tearoffs: true
-    library_annotations: true
-
-    # This rule does not work well with package:test_reflective_loader.
-    no_duplicate_case_values: true
-    non_constant_identifier_names: false
-    omit_local_variable_types: true
-    prefer_is_empty: true
-    prefer_is_not_empty: true
-    prefer_iterable_whereType: true
-    prefer_single_quotes: true
-    unawaited_futures: true
-    unnecessary_library_directive: true
-    unnecessary_parenthesis: true
-    unreachable_from_main: true
-    unrelated_type_equality_checks: true
+    - always_declare_return_types
+    - avoid_unused_constructor_parameters
+    - directives_ordering
+    - enable_null_safety
+    - flutter_style_todos
+    - library_annotations
+    - omit_local_variable_types
+    - prefer_single_quotes
+    - unawaited_futures
+    - unnecessary_library_directive
+    - unnecessary_parenthesis
+    - unreachable_from_main

pkg/analyzer_plugin/analysis_options.yaml

@@ -3,30 +3,23 @@ include: package:lints/recommended.yaml
 analyzer:
   language:
     strict-casts: true
+  errors:
+    # Remove from lints/recommended:
+    constant_identifier_names: ignore
+    implementation_imports: ignore
+    non_constant_identifier_names: ignore
+    # Existing violations (3)
+    library_private_types_in_public_api: ignore
 
 linter:
   rules:
-    # In addition to lints/recommended:
-    always_declare_return_types: true
-    collection_methods_unrelated_type: true
-    # Enable when we require Dart 2.19.0.
-    #dangling_library_doc_comments: true
-    depend_on_referenced_packages: true
-    enable_null_safety: true
-    flutter_style_todos: true
-    implicit_call_tearoffs: true
-    library_annotations: true
-    omit_local_variable_types: true
-    prefer_single_quotes: true
-    unawaited_futures: true
-    unnecessary_library_directive: true
-    unnecessary_parenthesis: true
-    unreachable_from_main: true
-
-    # Remove from lints/recommended:
-    constant_identifier_names: false
-    implementation_imports: false
-    non_constant_identifier_names: false
-
-    # Existing violations (3)
-    library_private_types_in_public_api: false
+    - always_declare_return_types
+    - enable_null_safety
+    - flutter_style_todos
+    - library_annotations
+    - omit_local_variable_types
+    - prefer_single_quotes
+    - unawaited_futures
+    - unnecessary_library_directive
+    - unnecessary_parenthesis
+    - unreachable_from_main

pkg/analyzer_utilities/analysis_options.yaml

@@ -10,11 +10,7 @@ linter:
   rules:
     - avoid_dynamic_calls
     - avoid_unused_constructor_parameters
-    - collection_methods_unrelated_type
-    - dangling_library_doc_comments
-    - depend_on_referenced_packages
     - flutter_style_todos
-    - implicit_call_tearoffs
     - library_annotations
     - prefer_single_quotes
     - unawaited_futures

pkg/dart2native/analysis_options.yaml

@@ -3,6 +3,5 @@ include: package:lints/recommended.yaml
 linter:
   rules:
     # Enable additional rules.
-    depend_on_referenced_packages: true
-    directives_ordering: true
-    sort_pub_dependencies: true
+    - directives_ordering
+    - sort_pub_dependencies

pkg/dartdev/analysis_options.yaml

@@ -1,12 +1,12 @@
 include: package:lints/recommended.yaml
 
+analyzer:
+  errors:
+    # Disable implementation_imports.
+    implementation_imports: ignore
+
 linter:
   rules:
-    # Disable implementation_imports.
-    implementation_imports: false
-
-    # Enable additional rules.
-    depend_on_referenced_packages: true
-    directives_ordering: true
-    prefer_single_quotes: true
-    sort_pub_dependencies: true
+    - directives_ordering
+    - prefer_single_quotes
+    - sort_pub_dependencies

pkg/dds/analysis_options.yaml

@@ -2,7 +2,5 @@ include: package:lints/recommended.yaml
 
 linter:
   rules:
-    - depend_on_referenced_packages
     - directives_ordering
-    - prefer_generic_function_type_aliases
     - prefer_relative_imports

pkg/dev_compiler/analysis_options.yaml

@@ -23,7 +23,6 @@ linter:
   rules:
     # Not enforced by lints at any version.
     - always_declare_return_types
-    - depend_on_referenced_packages
     - directives_ordering
     - omit_local_variable_types
     - prefer_single_quotes

pkg/frontend_server/analysis_options.yaml

@@ -1,12 +1,11 @@
 include: package:lints/recommended.yaml
 
-linter:
-  rules:
-    - depend_on_referenced_packages
-    - directives_ordering
-    - sort_pub_dependencies
-    - unawaited_futures
-
 analyzer:
   exclude:
     - test/fixtures/**
+
+linter:
+  rules:
+    - directives_ordering
+    - sort_pub_dependencies
+    - unawaited_futures

pkg/js/analysis_options.yaml

@@ -3,8 +3,6 @@ include: package:lints/recommended.yaml
 analyzer:
   language:
     strict-casts: true
-
-linter:
-  rules:
+  errors:
     # Ignore this lint (triggered by the annotation definitions in lib/js.dart).
-    library_private_types_in_public_api: false
+    library_private_types_in_public_api: ignore

pkg/js_ast/analysis_options.yaml

@@ -20,7 +20,6 @@ linter:
     # Not enforced by the lints package at any version.
     - always_declare_return_types
     - avoid_dynamic_calls
-    - depend_on_referenced_packages
     - directives_ordering
     - prefer_single_quotes
     - prefer_relative_imports

pkg/linter/analysis_options.yaml

@@ -9,6 +9,7 @@ analyzer:
     - test_data/**
   language:
     strict-casts: true
+
 linter:
   rules:
     - always_put_required_named_parameters_first
@@ -27,13 +28,10 @@ linter:
     - avoid_unused_constructor_parameters
     - cancel_subscriptions
     - cast_nullable_to_non_nullable
-    - collection_methods_unrelated_type
     - comment_references
-    - dangling_library_doc_comments
     - directives_ordering
     - discarded_futures
     - flutter_style_todos
-    - implicit_call_tearoffs
     - join_return_with_assignment
     - library_annotations
     - literal_only_boolean_expressions
@@ -66,5 +64,4 @@ linter:
     - use_late_for_private_fields_and_variables
     - use_setters_to_change_properties
     - use_string_buffers
-    - use_super_parameters
     - use_to_and_as_if_applicable

pkg/nnbd_migration/analysis_options.yaml

@@ -23,19 +23,9 @@ analyzer:
 
 linter:
   rules:
-    - await_only_futures
-    - collection_methods_unrelated_type
-    - dangling_library_doc_comments
-    - depend_on_referenced_packages
-    - empty_constructor_bodies
-    - empty_statements
     - enable_null_safety
-    - implicit_call_tearoffs
     - library_annotations
     - unawaited_futures
-    - unnecessary_brace_in_string_interps
     - unnecessary_library_directive
     - unnecessary_parenthesis
     - unreachable_from_main
-    - use_super_parameters
-    - valid_regexps

pkg/sourcemap_testing/analysis_options.yaml

@@ -12,7 +12,6 @@ linter:
   rules:
     # Not enforced by the lints package at any version.
     - always_declare_return_types
-    - depend_on_referenced_packages
     - directives_ordering
     - prefer_single_quotes
     - prefer_relative_imports

pkg/test_runner/analysis_options.yaml

@@ -21,4 +21,3 @@ linter:
     - unnecessary_lambdas
     - unnecessary_parenthesis
     - unnecessary_statements
-    - unnecessary_string_escapes

pkg/vm_snapshot_analysis/analysis_options.yaml

@@ -6,7 +6,5 @@ analyzer:
 
 linter:
   rules:
-    # Enable additional rules.
-    depend_on_referenced_packages: true
-    directives_ordering: true
-    sort_pub_dependencies: true
+    - directives_ordering
+    - sort_pub_dependencies