languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-20 02:39:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Intrinsify GrowableObjectArray.add.

Browse source 
Review URL: https://chromiumcodereview.appspot.com//10869038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11277 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
srdjan@google.com 2012-08-24 00:07:07 +00:00
parent b77b6f913d
commit 68124e35ca
3 changed files with 59 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
runtime/vm/intrinsifier.h
View file

@ -62,6 +62,7 @@ namespace dart {
V(GrowableObjectArray, []=, GrowableArray_setIndexed) \
V(GrowableObjectArray, _setLength, GrowableArray_setLength) \
V(GrowableObjectArray, set:data, GrowableArray_setData) \
V(GrowableObjectArray, add, GrowableArray_add) \
V(ImmutableArray, [], ImmutableArray_getIndexed) \
V(ImmutableArray, get:length, ImmutableArray_getLength) \
V(::, sqrt, Math_sqrt) \

29
runtime/vm/intrinsifier_ia32.cc
View file

@ -422,6 +422,35 @@ bool Intrinsifier::GrowableArray_setData(Assembler* assembler) {
}
// Add an element to growable array if it doesn't need to grow, otherwise
// call into regular code.
// On stack: growable array (+2), value (+1), return-address (+0).
bool Intrinsifier::GrowableArray_add(Assembler* assembler) {
// In checked mode we need to check the incoming argument.
if (FLAG_enable_type_checks) return false;
Label fall_through;
__ movl(EAX, Address(ESP, + 2 * kWordSize)); // Array.
__ movl(EBX, FieldAddress(EAX, GrowableObjectArray::length_offset()));
// EBX: length.
__ movl(EDI, FieldAddress(EAX, GrowableObjectArray::data_offset()));
// EDI: data.
// Compare length with capacity.
__ cmpl(EBX, FieldAddress(EDI, GrowableObjectArray::length_offset()));
__ j(EQUAL, &fall_through, Assembler::kNearJump); // Must grow data.
const Immediate value_one = Immediate(reinterpret_cast<int32_t>(Smi::New(1)));
// len = len + 1;
__ addl(FieldAddress(EAX, GrowableObjectArray::length_offset()), value_one);
__ movl(EAX, Address(ESP, + 1 * kWordSize)); // Value
ASSERT(kSmiTagShift == 1);
__ StoreIntoObject(EDI,
FieldAddress(EDI, EBX, TIMES_2, sizeof(RawArray)),
EAX);
__ ret();
__ Bind(&fall_through);
return false;
}
// Gets the length of a ByteArray.
bool Intrinsifier::ByteArrayBase_getLength(Assembler* assembler) {
__ movl(EAX, Address(ESP, + 1 * kWordSize));

29
runtime/vm/intrinsifier_x64.cc
View file

@ -363,6 +363,35 @@ bool Intrinsifier::GrowableArray_setData(Assembler* assembler) {
}
// Add an element to growable array if it doesn't need to grow, otherwise
// call into regular code.
// On stack: growable array (+2), value (+1), return-address (+0).
bool Intrinsifier::GrowableArray_add(Assembler* assembler) {
// In checked mode we need to check the incoming argument.
if (FLAG_enable_type_checks) return false;
Label fall_through;
__ movq(RAX, Address(RSP, + 2 * kWordSize)); // Array.
__ movq(RCX, FieldAddress(RAX, GrowableObjectArray::length_offset()));
// RCX: length.
__ movq(RDX, FieldAddress(RAX, GrowableObjectArray::data_offset()));
// RDX: data.
// Compare length with capacity.
__ cmpq(RCX, FieldAddress(RDX, GrowableObjectArray::length_offset()));
__ j(EQUAL, &fall_through, Assembler::kNearJump); // Must grow data.
const Immediate value_one = Immediate(reinterpret_cast<int64_t>(Smi::New(1)));
// len = len + 1;
__ addq(FieldAddress(RAX, GrowableObjectArray::length_offset()), value_one);
__ movq(RAX, Address(RSP, + 1 * kWordSize)); // Value
ASSERT(kSmiTagShift == 1);
__ StoreIntoObject(RDX,
FieldAddress(RDX, RCX, TIMES_4, sizeof(RawArray)),
RAX);
__ ret();
__ Bind(&fall_through);
return false;
}
bool Intrinsifier::ByteArrayBase_getLength(Assembler* assembler) {
__ movq(RAX, Address(RSP, + 1 * kWordSize));
__ movq(RAX, FieldAddress(RAX, ByteArray::length_offset()));