languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:09:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Compute builder redness due to unapproved failures on the builder

Browse source 
Fixes: https://github.com/dart-lang/sdk/issues/41627
Change-Id: Ie197409520b8215047df215429c3febf3ee7000d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144501
Reviewed-by: Karl Klose <karlklose@google.com>
This commit is contained in:
William Hesse 2020-04-23 09:32:35 +00:00
parent 2d865dc69b
commit 665981b4bd
1 changed files with 26 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
tools/bots/get_builder_status.dart
View file

@ -23,8 +23,6 @@ String builder;
String builderBase;
int buildNumber;
String token;
List<String> configurations;
Map<String, List<Map<String, dynamic>>> failures = {};
http.Client client;
String get buildTable => builder.endsWith('-try') ? 'try_builds' : 'builds';
@ -77,19 +75,21 @@ main(List<String> args) async {
if (document != null) {
bool success = booleanFieldOrFalse(document, 'success');
bool completed = booleanFieldOrFalse(document, 'completed');
bool activeFailures = booleanFieldOrFalse(document, 'active_failures');
if (completed) {
if (success) {
print('No unapproved new failures');
if (activeFailures == true) {
print('There are unapproved failures from previous builds');
await printResults();
}
print(success
? 'No new unapproved failures'
: 'There are new unapproved failures on this build');
if (builder.endsWith('-try')) exit(success ? 0 : 1);
final configurations = await getConfigurations();
final failures = await fetchActiveFailures(configurations);
if (failures.isNotEmpty) {
print('There are unapproved failures');
printActiveFailures(failures);
exit(1);
} else {
print('There are unapproved new failures on this build');
await printResults();
print('There are no unapproved failures');
exit(0);
}
exit((success && (activeFailures != true)) ? 0 : 1);
}
String chunks =
(document['fields']['num_chunks'] ?? const {})['integerValue'];
@ -116,12 +116,6 @@ main(List<String> args) async {
exit(2);
}
void printResults() async {
if (builder.endsWith('-try')) return;
configurations = await getConfigurations();
await printActiveFailures();
}
Future<List<String>> getConfigurations() async {
final response = await runFirestoreQuery(configurationsQuery());
if (response.statusCode == HttpStatus.ok) {
@ -153,7 +147,9 @@ Future<String> fetchCommitHash(int index) async {
return 'missing hash for commit $index';
}
Future<void> printActiveFailures() async {
Future<Map<String, List<Map<String, dynamic>>>> fetchActiveFailures(
List<String> configurations) async {
final failures = <String, List<Map<String, dynamic>>>{};
for (final configuration in configurations) {
final response =
await runFirestoreQuery(unapprovedFailuresQuery(configuration));
@ -165,8 +161,10 @@ Future<void> printActiveFailures() async {
final fields = document['fields'];
failures.putIfAbsent(configuration, () => []).add({
'name': fields['name']['stringValue'],
'start': int.parse(fields['blamelist_start_index']['integerValue']),
'end': int.parse(fields['blamelist_end_index']['integerValue']),
'start_commit': await commitHash(
int.parse(fields['blamelist_start_index']['integerValue'])),
'end_commit': await commitHash(
int.parse(fields['blamelist_end_index']['integerValue'])),
'result': fields['result']['stringValue'],
'expected': fields['expected']['stringValue'],
'previous': fields['previous_result']['stringValue'],
@ -174,6 +172,10 @@ Future<void> printActiveFailures() async {
}
}
}
return failures;
}
void printActiveFailures(Map<String, List<Map<String, dynamic>>> failures) {
for (final configuration in failures.keys) {
print('($configuration):');
for (final failure in failures[configuration]) {
@ -187,10 +189,10 @@ Future<void> printActiveFailures() async {
', expected ',
failure['expected'],
') at ',
(await commitHash(failure['start'])).substring(0, 6),
if (failure['start'] != failure['end']) ...[
failure['start_commit'].substring(0, 6),
if (failure['end_commit'] != failure['start_commit']) ...[
'..',
(await commitHash(failure['end'])).substring(0, 6)
failure['end_commit'].substring(0, 6)
]
].join(''));
}